From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932967AbcGOMJy (ORCPT ); Fri, 15 Jul 2016 08:09:54 -0400 Received: from mail-lf0-f66.google.com ([209.85.215.66]:32954 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932779AbcGOMJt (ORCPT ); Fri, 15 Jul 2016 08:09:49 -0400 Date: Fri, 15 Jul 2016 14:09:52 +0200 From: Johan Hovold To: Mathieu OTHACEHE Cc: johan@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 22/36] usb: serial: ti_usb_3410_5052: Change ti_get/set_serial_info function arguments Message-ID: <20160715120952.GM8809@localhost> References: <1463042948-12205-1-git-send-email-m.othacehe@gmail.com> <1463042948-12205-23-git-send-email-m.othacehe@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1463042948-12205-23-git-send-email-m.othacehe@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 12, 2016 at 10:48:54AM +0200, Mathieu OTHACEHE wrote: > It is sufficient to pass usb_serial_port structure to ti_get_serial_info > and ti_set_serial_info. > > Also move functions above ioctl to avoid function prototyping > and use unsigned int instead of unsigned for cwait variable. Avoid changing things in the same patch as you move something, if moving is at all needed. Thanks, Johan