From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751694AbcGORbS (ORCPT ); Fri, 15 Jul 2016 13:31:18 -0400 Received: from mail-pf0-f173.google.com ([209.85.192.173]:35852 "EHLO mail-pf0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751388AbcGORbM (ORCPT ); Fri, 15 Jul 2016 13:31:12 -0400 Date: Fri, 15 Jul 2016 10:31:07 -0700 From: Andrey Pronin To: Guenter Roeck Cc: Jarkko Sakkinen , Peter Huewe , Marcel Selhorst , Jason Gunthorpe , tpmdd-devel@lists.sourceforge.net, linux-kernel , Guenter Roeck , smbarber@chromium.org, Douglas Anderson , devicetree@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala Subject: Re: [PATCH 1/2] tpm: devicetree: document properties for cr50 Message-ID: <20160715173107.GD109276@apronin> References: <1468549218-19215-1-git-send-email-apronin@chromium.org> <1468549218-19215-2-git-send-email-apronin@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 14, 2016 at 09:05:53PM -0700, Guenter Roeck wrote: > On Thu, Jul 14, 2016 at 7:20 PM, Andrey Pronin wrote: > > + > > +Required properties: > > +- compatible: Should be "google,cr50_spi". > > google,cr50, maybe ? The "_spi" seems redundant. > I believe "_spi" is warranted. It's the driver that handles the SPI interface for Cr50 specifically. But if the same firmware ever talks through a different interface (say, I2C), this driver will not be compatible. > Also, I agree with comments from others - the term cr50 really needs > an explanation (Google thinks that it is a motor bike, a scanner, or a > coffee roaster). > Yes, will add a better description of what it is. My original one was too brief and imprecise at the same time. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrey Pronin Subject: Re: [PATCH 1/2] tpm: devicetree: document properties for cr50 Date: Fri, 15 Jul 2016 10:31:07 -0700 Message-ID: <20160715173107.GD109276@apronin> References: <1468549218-19215-1-git-send-email-apronin@chromium.org> <1468549218-19215-2-git-send-email-apronin@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Guenter Roeck Cc: Mark Rutland , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Douglas Anderson , Pawel Moll , Ian Campbell , linux-kernel , smbarber-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, Rob Herring , tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Kumar Gala , Guenter Roeck List-Id: devicetree@vger.kernel.org On Thu, Jul 14, 2016 at 09:05:53PM -0700, Guenter Roeck wrote: > On Thu, Jul 14, 2016 at 7:20 PM, Andrey Pronin wrote: > > + > > +Required properties: > > +- compatible: Should be "google,cr50_spi". > > google,cr50, maybe ? The "_spi" seems redundant. > I believe "_spi" is warranted. It's the driver that handles the SPI interface for Cr50 specifically. But if the same firmware ever talks through a different interface (say, I2C), this driver will not be compatible. > Also, I agree with comments from others - the term cr50 really needs > an explanation (Google thinks that it is a motor bike, a scanner, or a > coffee roaster). > Yes, will add a better description of what it is. My original one was too brief and imprecise at the same time. ------------------------------------------------------------------------------ What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports.http://sdm.link/zohodev2dev