From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751825AbcGOTjl (ORCPT ); Fri, 15 Jul 2016 15:39:41 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:34991 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751750AbcGOTjh (ORCPT ); Fri, 15 Jul 2016 15:39:37 -0400 Date: Fri, 15 Jul 2016 13:39:28 -0600 From: Jason Gunthorpe To: Andrey Pronin Cc: Jarkko Sakkinen , Peter Huewe , Marcel Selhorst , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, groeck@chromium.org, smbarber@chromium.org, dianders@chromium.org Subject: Re: [PATCH 2/2] tpm: fix byte-order for the value read by tpm2_get_tpm_pt Message-ID: <20160715193928.GA20719@obsidianresearch.com> References: <1468544838-9990-1-git-send-email-apronin@chromium.org> <1468544838-9990-3-git-send-email-apronin@chromium.org> <20160715031046.GC9347@obsidianresearch.com> <20160715031701.GA25406@apronin> <20160715033553.GJ9347@obsidianresearch.com> <20160715193143.GA7052@apronin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160715193143.GA7052@apronin> User-Agent: Mutt/1.5.23 (2014-03-12) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.151 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 15, 2016 at 12:31:43PM -0700, Andrey Pronin wrote: > I even tried changing the code there to > __be32 vv = cmd.params.get_tpm_pt_out.value; > u32 ret = vv; > to make it clear what's going on. Still, no complaints from sparse. Hum, I'm not an expert at sparse, but I expect a warning from it here? Maybe Jarkko knows when he gets back? Jason