All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Vagin <avagin@virtuozzo.com>
To: Johannes Sixt <j6t@kdbg.org>
Cc: Andrey Vagin <avagin@openvz.org>,
	Junio C Hamano <gitster@pobox.com>, <git@vger.kernel.org>
Subject: Re: [PATCH] git-clean: remove fifo, devices, socket files
Date: Fri, 15 Jul 2016 14:36:29 -0700	[thread overview]
Message-ID: <20160715213628.GA19021@outlook.office365.com> (raw)
In-Reply-To: <3a6cb604-daa0-6d34-3342-0671a0b23032@kdbg.org>

On Fri, Jul 15, 2016 at 10:33:42PM +0200, Johannes Sixt wrote:
> Am 15.07.2016 um 09:46 schrieb Andrey Vagin:
> > On Thu, Jul 14, 2016 at 10:56 PM, Johannes Sixt <j6t@kdbg.org> wrote:
> > > IOW: These special files are invisible for Git unless it already knows the
> > > names. The latter case is outside 'git clean's domain, and the former case
> > > really means that special files in the working tree are left at the user's
> > > discretion.
> > 
> > I understand your points, but I don't see any reasons to ignore these files.
> > 
> > What will be wrong if 'git status' will reports these files?
> > What will be wrong if 'git add' will returns an error instead of
> > skipping them silently?
> 
> I can buy that 'git add' reports an error for special files. (And I concur
> with Dscho that the behavior should otherwise remain unchanged.) But this is
> not what the commit message sells even if the patch changes the behavior of
> 'git add', too (I haven't tested the patch).

Ok. Thank you for the feedback.

> 
> -- Hannes
> 

      reply	other threads:[~2016-07-16  8:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-15  2:42 [PATCH] git-clean: remove fifo, devices, socket files Andrey Vagin
2016-07-15  5:56 ` Johannes Sixt
2016-07-15  7:46   ` Andrey Vagin
2016-07-15 10:48     ` Johannes Schindelin
2016-07-15 20:33     ` Johannes Sixt
2016-07-15 21:36       ` Andrew Vagin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160715213628.GA19021@outlook.office365.com \
    --to=avagin@virtuozzo.com \
    --cc=avagin@openvz.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=j6t@kdbg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.