From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751935AbcGOW0G (ORCPT <rfc822;w@1wt.eu>);
	Fri, 15 Jul 2016 18:26:06 -0400
Received: from mail.kernel.org ([198.145.29.136]:42824 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751325AbcGOW0D (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 15 Jul 2016 18:26:03 -0400
Date: Fri, 15 Jul 2016 19:25:56 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
        Stephane Eranian <eranian@google.com>, Ingo Molnar <mingo@redhat.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Adrian Hunter <adrian.hunter@intel.com>, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org
Subject: Re: [patch 1/2] perf jit: add missing curly braces
Message-ID: <20160715222556.GE8740@kernel.org>
References: <20160715210712.GA19522@mwanda>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160715210712.GA19522@mwanda>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.6.1 (2016-04-27)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Sat, Jul 16, 2016 at 12:07:12AM +0300, Dan Carpenter escreveu:
> It doesn't change the runtime behavior, but my static checker complains
> that curly braces were intended.

Agreed, applying, thanks!

- Arnaldo
 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/tools/perf/jvmti/jvmti_agent.c b/tools/perf/jvmti/jvmti_agent.c
> index 3573f31..91bf333 100644
> --- a/tools/perf/jvmti/jvmti_agent.c
> +++ b/tools/perf/jvmti/jvmti_agent.c
> @@ -491,10 +491,11 @@ jvmti_write_debug_info(void *agent, uint64_t code, const char *file,
>  		if (sret != 1)
>  			goto error;
>  	}
> -	if (padding_count)
> +	if (padding_count) {
>  		sret = fwrite_unlocked(pad_bytes, padding_count, 1, fp);
>  		if (sret != 1)
>  			goto error;
> +	}
>  
>  	funlockfile(fp);
>  	return 0;

From mboxrd@z Thu Jan  1 00:00:00 1970
From: Arnaldo Carvalho de Melo <acme@kernel.org>
Date: Fri, 15 Jul 2016 22:25:56 +0000
Subject: Re: [patch 1/2] perf jit: add missing curly braces
Message-Id: <20160715222556.GE8740@kernel.org>
List-Id: <kernel-janitors.vger.kernel.org>
References: <20160715210712.GA19522@mwanda>
In-Reply-To: <20160715210712.GA19522@mwanda>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Peter Zijlstra <peterz@infradead.org>, Stephane Eranian <eranian@google.com>, Ingo Molnar <mingo@redhat.com>, Alexander Shishkin <alexander.shishkin@linux.intel.com>, Adrian Hunter <adrian.hunter@intel.com>, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org

Em Sat, Jul 16, 2016 at 12:07:12AM +0300, Dan Carpenter escreveu:
> It doesn't change the runtime behavior, but my static checker complains
> that curly braces were intended.

Agreed, applying, thanks!

- Arnaldo
 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/tools/perf/jvmti/jvmti_agent.c b/tools/perf/jvmti/jvmti_agent.c
> index 3573f31..91bf333 100644
> --- a/tools/perf/jvmti/jvmti_agent.c
> +++ b/tools/perf/jvmti/jvmti_agent.c
> @@ -491,10 +491,11 @@ jvmti_write_debug_info(void *agent, uint64_t code, const char *file,
>  		if (sret != 1)
>  			goto error;
>  	}
> -	if (padding_count)
> +	if (padding_count) {
>  		sret = fwrite_unlocked(pad_bytes, padding_count, 1, fp);
>  		if (sret != 1)
>  			goto error;
> +	}
>  
>  	funlockfile(fp);
>  	return 0;