From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751661AbcGRF2C (ORCPT ); Mon, 18 Jul 2016 01:28:02 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:58186 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750931AbcGRF17 (ORCPT ); Mon, 18 Jul 2016 01:27:59 -0400 Date: Sun, 17 Jul 2016 22:27:58 -0700 (PDT) Message-Id: <20160717.222758.2271369406708475258.davem@davemloft.net> To: bhaktipriya96@gmail.com Cc: lars.persson@axis.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, tj@kernel.org Subject: Re: [PATCH] dwc_eth_qos: Remove deprecated create_singlethread_workqueue From: David Miller In-Reply-To: <20160716082328.GA7254@Karyakshetra> References: <20160716082328.GA7254@Karyakshetra> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 17 Jul 2016 22:27:59 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bhaktipriya Shridhar Date: Sat, 16 Jul 2016 13:53:28 +0530 > alloc_workqueue replaces deprecated create_singlethread_workqueue(). > > A dedicated workqueue has been used since the workitem viz > lp->txtimeout_reinit is involved in reinitialization if a TX timeout > occurs, which is necessary to guarantee forward progress in packet > processing. As a network device can be used during memory reclaim, the > workqueue needs forward progress guarantee under memory pressure. > WQ_MEM_RECLAIM has been set to ensure this. > > Since there is only a single work item, explicit concurrency limit is > unnecessary here. > > Signed-off-by: Bhaktipriya Shridhar Applied.