From: David Miller <davem@davemloft.net>
To: tremyfr@gmail.com
Cc: andrew@lunn.ch, sudipm.mukherjee@gmail.com, mugunthanvnm@ti.com,
felipe.balbi@linux.intel.com, treding@nvidia.com, fw@strlen.de,
linux@roeck-us.net, adi-buildroot-devel@lists.sourceforge.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] net: ethernet: adi: bfin_mac: use phy_ethtool_{get|set}_link_ksettings
Date: Sun, 17 Jul 2016 23:22:51 -0700 (PDT) [thread overview]
Message-ID: <20160717.232251.1118461470001037366.davem@davemloft.net> (raw)
In-Reply-To: <1468710615-31951-2-git-send-email-tremyfr@gmail.com>
From: Philippe Reynes <tremyfr@gmail.com>
Date: Sun, 17 Jul 2016 01:10:15 +0200
> There are two generics functions phy_ethtool_{get|set}_link_ksettings,
> so we can use them instead of defining the same code in the driver.
>
> There was a check on CAP_NET_ADMIN in bfin_mac_ethtool_setsettings,
> but this check is already done in dev_ethtool, so no need to repeat
> it before calling the generic function.
>
> Signed-off-by: Philippe Reynes <tremyfr@gmail.com>
Applied.
next prev parent reply other threads:[~2016-07-18 6:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-16 23:10 [PATCH 1/2] net: ethernet: adi: bfin_mac: use phydev from struct net_device Philippe Reynes
2016-07-16 23:10 ` [PATCH 2/2] net: ethernet: adi: bfin_mac: use phy_ethtool_{get|set}_link_ksettings Philippe Reynes
2016-07-18 6:22 ` David Miller [this message]
2016-07-18 6:22 ` [PATCH 1/2] net: ethernet: adi: bfin_mac: use phydev from struct net_device David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160717.232251.1118461470001037366.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=adi-buildroot-devel@lists.sourceforge.net \
--cc=andrew@lunn.ch \
--cc=felipe.balbi@linux.intel.com \
--cc=fw@strlen.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=treding@nvidia.com \
--cc=tremyfr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.