From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751166AbcGQQL4 (ORCPT ); Sun, 17 Jul 2016 12:11:56 -0400 Received: from mail-sn1nam02on0079.outbound.protection.outlook.com ([104.47.36.79]:16864 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751069AbcGQQLz (ORCPT ); Sun, 17 Jul 2016 12:11:55 -0400 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; lists.infradead.org; dkim=none (message not signed) header.d=none;lists.infradead.org; dmarc=bestguesspass action=none header.from=xilinx.com; Date: Sun, 17 Jul 2016 09:11:10 -0700 From: =?utf-8?B?U8O2cmVu?= Brinkmann To: Masahiro Yamada CC: , Michal Simek , , Michael Turquette , Stephen Boyd , , "Rob Herring" , Mark Rutland , Subject: Re: [PATCH] clk: zynq: avoid retrieving clock names from DT property Message-ID: <20160717161110.GY3847@xsjsorenbubuntu> References: <1468682123-1434-1-git-send-email-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1468682123-1434-1-git-send-email-yamada.masahiro@socionext.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-22454.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.100;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(2980300002)(438002)(24454002)(377424004)(199003)(189002)(83506001)(54356999)(76176999)(50986999)(4326007)(36386004)(9786002)(356003)(2906002)(19580405001)(33656002)(50466002)(19580395003)(92566002)(23676002)(2950100001)(189998001)(586003)(110136002)(57986006)(4001350100001)(63266004)(1076002)(8676002)(87936001)(85182001)(76506005)(81166006)(106466001)(81156014)(305945005)(47776003)(8936002)(4001450100002)(77096005)(2870700001)(11100500001)(9686002)(86362001)(33716001)(85202003)(7846002)(18370500001)(107986001)(5001870100001);DIR:OUT;SFP:1101;SCL:1;SRVR:BL2NAM02HT236;H:xsj-pvapsmtpgw02;FPR:;SPF:Pass;PTR:xapps1.xilinx.com,unknown-60-100.xilinx.com;A:1;MX:1;LANG:en; X-MS-Office365-Filtering-Correlation-Id: 2e888108-a0d6-492e-4970-08d3ae5d1130 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:BL2NAM02HT236; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(13017025)(8121501046)(13023025)(13018025)(13015025)(13024025)(10201501046)(3002001)(6055026);SRVR:BL2NAM02HT236;BCL:0;PCL:0;RULEID:;SRVR:BL2NAM02HT236; X-Forefront-PRVS: 00064751B6 X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2016 16:11:53.1065 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.100];Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2NAM02HT236 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2016-07-17 at 00:15:23 +0900, Masahiro Yamada wrote: > The "clock-output-names" property is useful for generic clock > providers such as fixed-clock, fixed-factor-clock, etc. > > On the other hand, it should not be used for really SoC-specific > clock providers like this one. As you see in "enum zynq_clk" in > this driver, it is written as if it already knows all the clock > names. Besides, this is instantiated only once, so no clock name > conflict would happen even if the clock names are hard-coded in the > driver. > > The device tree (arch/arm/boot/dts/zynq-7000.dtsi) will be fixed > later. > > Signed-off-by: Masahiro Yamada IIRC, this was the only way to allow circular clock routing. E.g. there are use-cases that route an FCLK back into the PS to use it as input for the GEM. With the introduction of deferred probing this might all be possible now but it would be good to verify that this kind of circular clock routing still works with this change. Sören From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?B?U8O2cmVu?= Brinkmann Subject: Re: [PATCH] clk: zynq: avoid retrieving clock names from DT property Date: Sun, 17 Jul 2016 09:11:10 -0700 Message-ID: <20160717161110.GY3847@xsjsorenbubuntu> References: <1468682123-1434-1-git-send-email-yamada.masahiro@socionext.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1468682123-1434-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org To: Masahiro Yamada Cc: linux-clk@vger.kernel.org, Michal Simek , devicetree@vger.kernel.org, Michael Turquette , Stephen Boyd , linux-kernel@vger.kernel.org, Rob Herring , Mark Rutland , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On Sun, 2016-07-17 at 00:15:23 +0900, Masahiro Yamada wrote: > The "clock-output-names" property is useful for generic clock > providers such as fixed-clock, fixed-factor-clock, etc. >=20 > On the other hand, it should not be used for really SoC-specific > clock providers like this one. As you see in "enum zynq_clk" in > this driver, it is written as if it already knows all the clock > names. Besides, this is instantiated only once, so no clock name > conflict would happen even if the clock names are hard-coded in the > driver. >=20 > The device tree (arch/arm/boot/dts/zynq-7000.dtsi) will be fixed > later. >=20 > Signed-off-by: Masahiro Yamada IIRC, this was the only way to allow circular clock routing. E.g. there are use-cases that route an FCLK back into the PS to use it as input fo= r the GEM. With the introduction of deferred probing this might all be possible now but it would be good to verify that this kind of circular clock routing still works with this change. S=C3=B6ren From mboxrd@z Thu Jan 1 00:00:00 1970 From: soren.brinkmann@xilinx.com (=?utf-8?B?U8O2cmVu?= Brinkmann) Date: Sun, 17 Jul 2016 09:11:10 -0700 Subject: [PATCH] clk: zynq: avoid retrieving clock names from DT property In-Reply-To: <1468682123-1434-1-git-send-email-yamada.masahiro@socionext.com> References: <1468682123-1434-1-git-send-email-yamada.masahiro@socionext.com> Message-ID: <20160717161110.GY3847@xsjsorenbubuntu> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sun, 2016-07-17 at 00:15:23 +0900, Masahiro Yamada wrote: > The "clock-output-names" property is useful for generic clock > providers such as fixed-clock, fixed-factor-clock, etc. > > On the other hand, it should not be used for really SoC-specific > clock providers like this one. As you see in "enum zynq_clk" in > this driver, it is written as if it already knows all the clock > names. Besides, this is instantiated only once, so no clock name > conflict would happen even if the clock names are hard-coded in the > driver. > > The device tree (arch/arm/boot/dts/zynq-7000.dtsi) will be fixed > later. > > Signed-off-by: Masahiro Yamada IIRC, this was the only way to allow circular clock routing. E.g. there are use-cases that route an FCLK back into the PS to use it as input for the GEM. With the introduction of deferred probing this might all be possible now but it would be good to verify that this kind of circular clock routing still works with this change. S?ren