From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751366AbcGQW4o (ORCPT ); Sun, 17 Jul 2016 18:56:44 -0400 Received: from mail-oi0-f47.google.com ([209.85.218.47]:34790 "EHLO mail-oi0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751198AbcGQW4m (ORCPT ); Sun, 17 Jul 2016 18:56:42 -0400 Date: Sun, 17 Jul 2016 17:56:36 -0500 From: Michael Welling To: Pavel Machek Cc: kernel list , dmitry.torokhov@gmail.com, linux-input@vger.kernel.org, pali.rohar@gmail.com, sre@kernel.org, aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com, patrikbachan@gmail.com, serge@hallyn.com Subject: Re: v4.1 to v4.7: regression in tsc2005 driver Message-ID: <20160717225636.GB20462@deathstar> References: <20160717175257.GA26719@amd> <20160717182445.GA20058@deathstar> <20160717184209.GA30119@amd> <20160717185134.GA20462@deathstar> <20160717200339.GA29562@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160717200339.GA29562@amd> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 17, 2016 at 10:03:39PM +0200, Pavel Machek wrote: > On Sun 2016-07-17 13:51:34, Michael Welling wrote: > > On Sun, Jul 17, 2016 at 08:42:09PM +0200, Pavel Machek wrote: > > > On Sun 2016-07-17 13:24:45, Michael Welling wrote: > > > > On Sun, Jul 17, 2016 at 07:52:57PM +0200, Pavel Machek wrote: > > > > > Hi! > > > > > > > > > > tsc2005 driver changed input device name, from > > > > > > > > > > drivers/input/touchscreen/tsc2005.c: input_dev->name = "TSC2005 > > > > > touchscreen"; > > > > > > > > > > to "TSC200X touchscreen". Unfortunately, X seems to propagate that > > > > > name to userspace, where it is needed to be able to do > > > > > > > > > > xinput --set-prop --type=int ... > > > > > > > > > > with the right arguments to calibrate touchscreen. (Touchscreen is > > > > > unusable without calibration). > > > > > > > > > > What to do with that? > > > > > > > > The input_dev name could be passed to the common probe function. > > > > > > > > http://lxr.free-electrons.com/source/drivers/input/touchscreen/tsc2005.c#L65 > > > > > > That would be preffered, I guess. > > > > > > How many stable releases are affected? > > > > Well this patch is 9 months old now. Lets see. > > > > It was introduced in v4.4-rc1. So v4.4, v4.5 and v4.6. > > Ok, thanks for the information. I believe changing it back to > "TSC2005" version makes sense (and then fixing it in stable). Lets see if the maintainer has any input before I submit a patch. > > Best regards, > Pavel > -- > (english) http://www.livejournal.com/~pavelmachek > (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html