From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751676AbcGRRjc (ORCPT ); Mon, 18 Jul 2016 13:39:32 -0400 Received: from mail-cys01nam02on0041.outbound.protection.outlook.com ([104.47.37.41]:35504 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751441AbcGRRj3 (ORCPT ); Mon, 18 Jul 2016 13:39:29 -0400 X-Greylist: delayed 958 seconds by postgrey-1.27 at vger.kernel.org; Mon, 18 Jul 2016 13:39:29 EDT Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; lists.infradead.org; dkim=none (message not signed) header.d=none;lists.infradead.org; dmarc=bestguesspass action=none header.from=xilinx.com; Date: Mon, 18 Jul 2016 10:22:44 -0700 From: =?utf-8?B?U8O2cmVu?= Brinkmann To: Masahiro Yamada CC: , Michal Simek , , Michael Turquette , Stephen Boyd , , "Rob Herring" , Mark Rutland , Subject: Re: [PATCH] clk: zynq: avoid retrieving clock names from DT property Message-ID: <20160718172244.GF3847@xsjsorenbubuntu> References: <1468682123-1434-1-git-send-email-yamada.masahiro@socionext.com> <20160717161110.GY3847@xsjsorenbubuntu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160717161110.GY3847@xsjsorenbubuntu> User-Agent: Mutt/1.5.24 (2015-08-30) X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-22458.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.83;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(2980300002)(438002)(24454002)(189002)(377424004)(199003)(586003)(1076002)(356003)(36386004)(2906002)(33656002)(47776003)(8936002)(81156014)(81166006)(87936001)(9786002)(23676002)(110136002)(77096005)(11100500001)(9686002)(2870700001)(2950100001)(4326007)(50986999)(54356999)(76176999)(33716001)(19580395003)(19580405001)(189998001)(4001350100001)(83506001)(92566002)(86362001)(85182001)(8676002)(76506005)(57986006)(63266004)(106466001)(305945005)(50466002)(85202003)(7846002)(18370500001)(107986001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1NAM02HT009;H:xsj-pvapsmtpgw01;FPR:;SPF:Pass;PTR:unknown-60-83.xilinx.com;MX:1;A:1;LANG:en; X-MS-Office365-Filtering-Correlation-Id: c3cc79a6-2bfb-4bbf-49f6-08d3af303bf8 X-Microsoft-Exchange-Diagnostics: 1;CY1NAM02HT009;2:0EkfVJUSZBGMQuLl98MoHuwcWRAqwpYIbNQRyn5ebIOIxNsjp+2zJI8ta8qJwtH+x6FOUMYRghChdK8bIyxr1P+lQDNz48iS1nriUf9RNcwEADAxYhIw6nEQeiWBdOkhzh3W+JoRbCvyWrdKomGO+U42qraIffLk+nxGmWqMLrS1YftYJxDwB+KJhHX7/fwb;3:QzrKuCZT6XpVAfudgAddNyFQjppqV7orGNa063fwwOrDPS3UnzqXChGfvsbvcQejtk+FjkLmd5qllY97dxr6/lj2+/cgYcp/eGghHtFyyy9hBAe8jYPyATJKm/xd4ZSIDWYgYn0QLliU1/opsk/mS4JVY7/jc1DU3EsR6bcav/J5zCoM3LuqFGCx1/YzShvNu3FfVpvF2vDm/SbiGgNr5SL+UTakx+M7XMh5+LVcPzbVJqqYpVuQTf1Rdcucn+sj91ydgDHtoPQjJHu0xw7vrg== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:CY1NAM02HT009; X-Microsoft-Exchange-Diagnostics: 1;CY1NAM02HT009;25:0sIr/sj9VDqQlJAUflqKVNsEespc1xGgUFHg01GVgtbt7N4crCNYQpIzczPh3gfCAuaTaCNCeZLIJv+nWYfdKqNtHJao8lzbtLIcHLZAv77fVO93gLrdoxtKCWjLonUtltwnm0tFE0xIGeHTrRQlYbsz40POuoQ+RaBJh39l/w4ruaK1C7SzxAqDmWRAGqe4K7jGa4LzWX/1yPpbPdVWVRkTBuBTw6GFZHWNbVuahka/aF+TByVQvzIq4Wj+jVq72yQQrJaWOykX6wcK9lrXX7wwfNX+VIsrCsT1oe6uHIfvK7/1nAgvhea9dJX2nB1t755xnMHGajFQj6umurEODE4QEU/zXNjND3UMtpsQDrbanyVYQXrAzre47usRrXB5tdVx6IfOc/JIwjr++j1QCsB+ln3Acr8MWBJEIOLYwTstRu0crvByxFia1c0Bn3ozaAjFwc5/kpHwOBv32JvcoPJs37undHIe6k61dzItUoDC9iBaR8RXkQQRkc9PW6p3XYAH+0BDvdFpr9NQ0exJA6JnazkWukvSf12KsZ7X3EExse9m9iK2XI8ngq5TOg/SlJOtM4shhfKLUM1ualp/qjzxjl18VbgbwSZMNPaPpHgkTN4sBa+ziXIYtfurTenvWCim5mNohZ2ZnPRx3Jj5P8HC6wX3QWJCzH/iIORdVI+uSBZl4+GxD5SMXEKqyDSxYxyM11R7f5yDh6tjFx4sjmqPwZ6VYTkmTISuG7Ur/+F0zWP1CSK089t2GBo85KJW9qe/S2dZ2xjGj6Ao/4FnChCwTOv4C6/f7YU5IIM57CLe4uP3MYq794pdlIwhixLT X-Microsoft-Exchange-Diagnostics: 1;CY1NAM02HT009;31:oLm826jEZIMFXIQLV8FTjcKb2CuGjUBc8ZNUgEpo4EWGj/KNe7Y8tZ0hA8mJyJvLrXfOSdNiaBDjx2ioBy2ah5dMVcGgWEoE/FR/x7dWCt5hLDwy35mSkvC0DzluPvZM8vaEz/QDnYWot5SMGJe6r5P9GjdfWfS3Xbmjt1pfgM3eQ5NR+XC5mOoaIt3opWRGPIDeFs2fEoELwraBXIeBMg==;20:31cAlWxfUpX/2pOG6ytB4C4+2BBzpZFkRgrLuz8Sa8rr4mYGJHVY9k5En1oas/t4CP7NFtKMyCNb/mv5lSk5gujsHVklfG0AO5FxA8cq8cv6BAhTp7ZtVW5DSYEGFEzxJ73zYhAglyvGXfUN1yyBy7elb2Map0St41oaczj6yj16CBYSHE+MX8MbJcMdmLjYO7vh50VilyWa9kmfC3zlkIfimaHy7XoKsFPdrlm4NYXaZVrp2ceTY/kZD5QW18biN2pulNxNxlDbtugj10HBUe3xExgghuzzTgbFJtcBQiXXQwL5uVcCS6GzCyZLPxyRclrj8tvNcmrl1qCPoTe5WhY1TEiWbzMTgmE8vkLBr1rhzQ6m+t5Rrwaf0r0ebBoUQTVHLAl88mQD09LjnwbYeOA9n8k5fomQR6GOAeBeXWGaX1CpGm1GG8zhDrhCxrmJy3hArWrQmPJbiwmSQFwQI4I2Sdl+pNAFK2NlvUYefh4VstIo7PcAshRjTO5jSEmL X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(13018025)(13015025)(13024025)(13023025)(8121501046)(13017025)(5005006)(3002001)(10201501046)(6055026);SRVR:CY1NAM02HT009;BCL:0;PCL:0;RULEID:;SRVR:CY1NAM02HT009; X-Microsoft-Exchange-Diagnostics: 1;CY1NAM02HT009;4:21LAXVkCvWeDRe92zSwEHLQ6Dr2iqhIL82GRSgMqC2Dt1/7IE+FN8oiq85K3C662CK0ZscBaDm2WJaeA74oyv170u+2cRGJZ4eX8fdnDHQzJ5iC4d9IX4W13AzBxnPCkQe5BtNSSmijC0jHT3uHw/PswvT92Gm4TTgZO+45QqA5POHuKgsrQjc1Tt2Yzc8nngpm3m/02p4HGVB+Z21GIqA88xER0NEW4KKnv9jS2l0/sBeq+cSr/SFaMJJO+8qjfaTGrmfc4GwQ3BPFdiegzXermJlw75cGHVlflpF28Ep0UzFcsSzKs/MhYs5MOHQJVoYUpAOz7YjFZ47+51i9anghteUcLWm4d9po+fp0M38dUWtJHjgSJPOtlFqqlDO8hJPuyJOLaWT7ADMoYWYqGrEKgCXn+AbhnBqXNpiRxh1d/ajoA4OAX6+mVLziuKCw9MOOWzRw202hN/5a1lzX+GCQTvmvl/GgbkSJzx3xGbIQ= X-Forefront-PRVS: 00073DB75F X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFOQU0wMkhUMDA5OzIzOko5Q1ZNZFE4Vk0zR0NlQ2p6UE1oWkk3ZTdH?= =?utf-8?B?SW9BajRXbzIwRjl2RllscDFERWlmU2xMOHV6SG1EcjdRdUN5ZDRuNEhyOElo?= =?utf-8?B?bFVaZmtUdzAwTGhYNXZ5aDh3Ymt3SUErNUxuUFZqZDZKMnh0K0xDcDQ0M01I?= =?utf-8?B?dGVEY2VkNkxPOXdscTRDaDVCc3NOcTVrWDFsNXl1SmpNUWVUb3JJL0RLZ0hu?= =?utf-8?B?TGlsNW04WE1aVW15djY4ZmZTZ21NcXptWVl2b01Bck9xZkdrNmtMeTRiYVVn?= =?utf-8?B?SEhmK2t5L3RqbngzcmZnc2RDaW8ydDRqZVlReHhENHhaNWhpT3ZydEZEejVJ?= =?utf-8?B?aklKVW5NNTNaVHphck85VWR6SThwbndyK3dJbHQ1TUM4bHp3OWpIbWYxbjR2?= =?utf-8?B?MnRFc3JrQmwwaGoxN0p5blRtdkJBZTc0U3pjVTFNbktreGZiUVAvUzkyNkpP?= =?utf-8?B?Y2tJVmFjZ1ArM3lIYVFHQnl3MXc0WHJkVnprS2VnUVVveUNCTkV2aGkyN1d0?= =?utf-8?B?bzFNZTkrSlc2Q2dOWU1YU2U5VnpWM2hzWkQzeTd6SCtLSUNzT2NKc0FaalhE?= =?utf-8?B?bHNlZk4zZFNZWkxyUjZMNFZpT0o3OXgrdzVPWEFwbGFRWUFmL3dNcHJ5M1NL?= =?utf-8?B?ZHpGUXRsaWxJcXJaaExCdWFOcnVveHBKTElJb3VqcjFYWFZUdkZsMnk0RXdD?= =?utf-8?B?NytlemFxZDlzam8wdzEvZHl4Y2NGVlhUTWwxZDNDVVRHZ3VQMDVnaWpiZXpC?= =?utf-8?B?VmNKcmFhN1hrUXlzdnVDcVg2OS9CTWRZWVhkTE5CVXdsWjRFNnhDaTJ2OXBE?= =?utf-8?B?cUZMcDVTWFpRMER2NldUdWMwOVM2L1k4Yms0NVFuM2crUnpoSzV0Zzk0WGty?= =?utf-8?B?TjlxQ0pLbmdHVnEwYVNTeXdOWWJEc240dnptaW1IM0ZZTm9Iblo4Tjh1WEo1?= =?utf-8?B?MytZbTVBYTJUUDlxRFYwL3hVWGlSZ1hpaUZvRmRrWjJRbm5nTURIYzVRYjRJ?= =?utf-8?B?RFcybUZBT3lVMXFaMU54azI1OGw1RnppUHpIajFIMGdRMTJCUmFmK084bUhr?= =?utf-8?B?YlBMNkZ3VXI5Tmh6Uks4WnZVNGVEN3Z1QXduRWoyaFZJV25KSXRXbXVzaGEv?= =?utf-8?B?RDZZRFpDa1JURXJab2d3TXVTT2FKTVVuMVM3N3lCRGpsSVRiczFpeC92bHps?= =?utf-8?B?WVZyOXFJNEdaY3VHUlFUVDNVNnMxMVQ5eFVFSG5GUmlFT0FSaURnSHIvNG0w?= =?utf-8?B?Y2x6M3YwWFR4ZHlZRXh0alh3RjFuZEcxZkZyaWdVWFpJZlhwbVJLVHVBU0xU?= =?utf-8?B?cm9VUW1Zb3Q2ZWprZlY0MGtwbmR6S0tDSUNHcjhKNXV6cnBVSFo0QTB4NXVp?= =?utf-8?B?UGo5TzQ2QmZiT1FFQm1CUHNzRzBQMWltWXJ4YVZ3OEYvZEliRWdteENEeHRO?= =?utf-8?B?UzhwMVVhYXJjTHFCQlRpWktDUUYrYjIxSDlKVnREMHpBeXM2YVpVYjNrdFBu?= =?utf-8?B?WjZTei82Sy9xbld1WlRIM1E1MEpsdjF5OFpsdVZkb2ZVTWZkRlkyOTd0U2ox?= =?utf-8?B?THM2SEYxaVBacFk1Y3BSMEVOU0dpbWpxQzZXV1hKdVBpV2w2OXJ6cEhmVUQ1?= =?utf-8?B?cHdhdVNZVlVkeDd6bkROWm1ENEJ3ZHRLTW1mUnVBN0dtb0thSGVHWkNuS2g0?= =?utf-8?Q?SLhnA/ygfXlJremH/AQLpDFHFh0uRZoHr+eFdZw?= X-Microsoft-Exchange-Diagnostics: 1;CY1NAM02HT009;6:e15Vin1zZ3oXl84n8M9lsWPfydXXQ9JYS6gLcEAbAYmM0LbezK614ynP4NOtt/STc5g3S/yTTFB7cAg/BmB6dxdi9gpTZgUTp+W2WbpPL0WefOwXIq8HmMhdjOB4nTb/n9sAey77NgRxwGhpzg9sQgidLjLdQ+XnyA32ZmuM2bzdgiZjYRDQNPspZ+5ka8ipC94kSUC/vgz7zr8QkCr1XmpXIArqZbLpisGsf7LNenAjzWVU0BpWtLSiKyBfX9vvqANr0Xb3vkCrAsAucAi+mFT1CyIZ4P2dJfv2xLisWjfEk5wqbmOdQApc03K8HeEMqwSRaycyvrsnS59u73G4WQ==;5:YcgUV9ldrroSvAq/AVHXCuNdP3AKvujSNGHZawp4Vu1/g9g8UuZDTTsDMhKwYHbr8lbxe8EMjJlOdopV6adC3FAg3gA0MQqMk2OPJv2khLdCh5+zPJltTJs2FyYRjDQwtDbkSu/LHkrsd4yTkeFROw==;24:AfkOw96uEEeQne0Mf8eQwXJ36O+QM3ZLjfDS9/ywl4abtps2L2TSFBBOMAlF4YjdxB8dkt6qyMbyArbnMAQAJ//DuCdoxTnC0o+vzqp0UI8=;7:jXsjhMWk9sILiDirRS3QCADXSvoP0PTLv0ydJ9gD0ugDxQaIYHcOfS+nagrrpBp1n8Q3udsD/cBUvFHbZWMpXBvakt0kz8Kz77hht/dpkHf5LZM+m41m/+pg0qxXE6qkrhp1Yr0VqEArzL+eK8D6AJZ2S5bd3lFoOrtlfn2Ya4oif/27vHXP9Krbzg3MCrtndTfQgU9DyGjIVjo71cRSNpG7uupc68mVf0xj4WRwX1VibVFKOD6Qk7i6sevzzpRX SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2016 17:23:25.5196 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.83];Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1NAM02HT009 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2016-07-17 at 09:11:10 -0700, Sören Brinkmann wrote: > On Sun, 2016-07-17 at 00:15:23 +0900, Masahiro Yamada wrote: > > The "clock-output-names" property is useful for generic clock > > providers such as fixed-clock, fixed-factor-clock, etc. > > > > On the other hand, it should not be used for really SoC-specific > > clock providers like this one. As you see in "enum zynq_clk" in > > this driver, it is written as if it already knows all the clock > > names. Besides, this is instantiated only once, so no clock name > > conflict would happen even if the clock names are hard-coded in the > > driver. > > > > The device tree (arch/arm/boot/dts/zynq-7000.dtsi) will be fixed > > later. > > > > Signed-off-by: Masahiro Yamada > > IIRC, this was the only way to allow circular clock routing. E.g. there > are use-cases that route an FCLK back into the PS to use it as input for > the GEM. With the introduction of deferred probing this might all be > possible now but it would be good to verify that this kind of circular > clock routing still works with this change. Yep, this breaks this kind of routing. E.g. if you remove the clk-output-names from the DT and add an EMIO clock input like this: clocks = <&clkc 15>; clock-names = "gem1_emio_clk"; the code will no longer be able to correctly obtain the clock name for that input. Sören From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?B?U8O2cmVu?= Brinkmann Subject: Re: [PATCH] clk: zynq: avoid retrieving clock names from DT property Date: Mon, 18 Jul 2016 10:22:44 -0700 Message-ID: <20160718172244.GF3847@xsjsorenbubuntu> References: <1468682123-1434-1-git-send-email-yamada.masahiro@socionext.com> <20160717161110.GY3847@xsjsorenbubuntu> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <20160717161110.GY3847@xsjsorenbubuntu> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Masahiro Yamada Cc: linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Michal Simek , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Michael Turquette , Stephen Boyd , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , Mark Rutland , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Sun, 2016-07-17 at 09:11:10 -0700, S=C3=B6ren Brinkmann wrote: > On Sun, 2016-07-17 at 00:15:23 +0900, Masahiro Yamada wrote: > > The "clock-output-names" property is useful for generic clock > > providers such as fixed-clock, fixed-factor-clock, etc. > >=20 > > On the other hand, it should not be used for really SoC-specific > > clock providers like this one. As you see in "enum zynq_clk" in > > this driver, it is written as if it already knows all the clock > > names. Besides, this is instantiated only once, so no clock name > > conflict would happen even if the clock names are hard-coded in the > > driver. > >=20 > > The device tree (arch/arm/boot/dts/zynq-7000.dtsi) will be fixed > > later. > >=20 > > Signed-off-by: Masahiro Yamada >=20 > IIRC, this was the only way to allow circular clock routing. E.g. the= re > are use-cases that route an FCLK back into the PS to use it as input = for > the GEM. With the introduction of deferred probing this might all be > possible now but it would be good to verify that this kind of circula= r > clock routing still works with this change. Yep, this breaks this kind of routing. E.g. if you remove the clk-output-names from the DT and add an EMIO clock input like this: clocks =3D <&clkc 15>; clock-names =3D "gem1_emio_clk"; the code will no longer be able to correctly obtain the clock name for = that input. S=C3=B6ren -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: soren.brinkmann@xilinx.com (=?utf-8?B?U8O2cmVu?= Brinkmann) Date: Mon, 18 Jul 2016 10:22:44 -0700 Subject: [PATCH] clk: zynq: avoid retrieving clock names from DT property In-Reply-To: <20160717161110.GY3847@xsjsorenbubuntu> References: <1468682123-1434-1-git-send-email-yamada.masahiro@socionext.com> <20160717161110.GY3847@xsjsorenbubuntu> Message-ID: <20160718172244.GF3847@xsjsorenbubuntu> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sun, 2016-07-17 at 09:11:10 -0700, S?ren Brinkmann wrote: > On Sun, 2016-07-17 at 00:15:23 +0900, Masahiro Yamada wrote: > > The "clock-output-names" property is useful for generic clock > > providers such as fixed-clock, fixed-factor-clock, etc. > > > > On the other hand, it should not be used for really SoC-specific > > clock providers like this one. As you see in "enum zynq_clk" in > > this driver, it is written as if it already knows all the clock > > names. Besides, this is instantiated only once, so no clock name > > conflict would happen even if the clock names are hard-coded in the > > driver. > > > > The device tree (arch/arm/boot/dts/zynq-7000.dtsi) will be fixed > > later. > > > > Signed-off-by: Masahiro Yamada > > IIRC, this was the only way to allow circular clock routing. E.g. there > are use-cases that route an FCLK back into the PS to use it as input for > the GEM. With the introduction of deferred probing this might all be > possible now but it would be good to verify that this kind of circular > clock routing still works with this change. Yep, this breaks this kind of routing. E.g. if you remove the clk-output-names from the DT and add an EMIO clock input like this: clocks = <&clkc 15>; clock-names = "gem1_emio_clk"; the code will no longer be able to correctly obtain the clock name for that input. S?ren