All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Bhushan Shah <bshah-RoXCvvDuEio@public.gmane.org>
Cc: Andy Gross <andy.gross-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	David Brown <david.brown-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Russell King <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>,
	linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 3/3] ARM: dts: msm8974-hammerhead: Introduce gpio-keys nodes
Date: Mon, 18 Jul 2016 10:39:37 -0700	[thread overview]
Message-ID: <20160718173937.GH13516@tuxbot> (raw)
In-Reply-To: <20160717105208.9596-4-bshah-RoXCvvDuEio@public.gmane.org>

On Sun 17 Jul 03:52 PDT 2016, Bhushan Shah wrote:

> This introduces the gpio-keys node for keys of hammerhead and pinctrl
> state associated with it.
> 
> Cc: Andy Gross <andy.gross-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> Cc: Bjorn Andersson <bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>

Reviewed-by: Bjorn Andersson <bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>

Regards,
Bjorn

> Cc: David Brown <david.brown-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
> Cc: Russell King <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>
> Cc: linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> Cc: linux-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> Signed-off-by: Bhushan Shah <bshah-RoXCvvDuEio@public.gmane.org>
> ---
>  .../dts/qcom-msm8974-lge-nexus5-hammerhead.dts     | 30 ++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts b/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts
> index 29fa0bb..12b6a14 100644
> --- a/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts
> +++ b/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts
> @@ -2,6 +2,7 @@
>  #include "qcom-pm8841.dtsi"
>  #include "qcom-pm8941.dtsi"
>  #include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/input/input.h>
>  #include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
>  
>  / {
> @@ -252,6 +253,27 @@
>  		status = "ok";
>  	};
>  
> +	gpio-keys {
> +		compatible = "gpio-keys";
> +		input-name = "gpio-keys";
> +
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&gpio_keys_pin_a>;
> +
> +		volume-up {
> +			label = "volume_up";
> +			gpios = <&pm8941_gpios 2 GPIO_ACTIVE_LOW>;
> +			linux,input-type = <1>;
> +			linux,code = <KEY_VOLUMEUP>;
> +		};
> +
> +		volume-down {
> +			label = "volume_down";
> +			gpios = <&pm8941_gpios 3 GPIO_ACTIVE_LOW>;
> +			linux,input-type = <1>;
> +			linux,code = <KEY_VOLUMEDOWN>;
> +		};
> +	};
>  };
>  
>  &spmi_bus {
> @@ -261,6 +283,14 @@
>  				pins = "gpio21";
>  				function = "normal";
>  			};
> +
> +			gpio_keys_pin_a: gpio-keys-active {
> +				pins = "gpio2", "gpio3";
> +				function = "normal";
> +
> +				bias-pull-up;
> +				power-source = <PM8941_GPIO_S3>;
> +			};
>  		};
>  	};
>  };
> -- 
> 2.9.0
> 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2016-07-18 17:39 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-17 10:52 [PATCH 0/3] Initial support for LG Nexus 5 phone (hammerhead) Bhushan Shah
2016-07-17 10:52 ` Bhushan Shah
2016-07-17 10:52 ` [PATCH 1/3] ARM: dts: qcom: Add initial DTS for LG Nexus 5 Phone Bhushan Shah
2016-07-17 10:52   ` Bhushan Shah
2016-07-18 17:19   ` Bjorn Andersson
2016-07-18 17:19     ` Bjorn Andersson
2016-07-17 10:52 ` [PATCH 2/3] ARM: dts: msm8974-hammerhead: Add regulator nodes for hammerhead Bhushan Shah
2016-07-17 19:21   ` Arnd Bergmann
2016-07-18  3:34     ` Bhushan Shah
2016-07-18  3:44       ` Bjorn Andersson
     [not found]         ` <CAOCOHw5MNN9QAea1gJobpEHpn1S0=CTA3mEHzd+dVhv-GShYdg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-07-18  7:44           ` Arnd Bergmann
2016-07-18 17:11             ` Bjorn Andersson
2016-07-18 19:12               ` Arnd Bergmann
2016-07-18 17:38   ` Bjorn Andersson
2016-07-17 10:52 ` [PATCH 3/3] ARM: dts: msm8974-hammerhead: Introduce gpio-keys nodes Bhushan Shah
     [not found]   ` <20160717105208.9596-4-bshah-RoXCvvDuEio@public.gmane.org>
2016-07-18 17:39     ` Bjorn Andersson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160718173937.GH13516@tuxbot \
    --to=bjorn.andersson-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
    --cc=andy.gross-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=bshah-RoXCvvDuEio@public.gmane.org \
    --cc=david.brown-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org \
    --cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.