From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44487) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPOb8-0000wS-FC for qemu-devel@nongnu.org; Tue, 19 Jul 2016 02:33:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bPOb6-0002Nc-HY for qemu-devel@nongnu.org; Tue, 19 Jul 2016 02:33:41 -0400 Date: Tue, 19 Jul 2016 14:33:31 +0800 From: Fam Zheng Message-ID: <20160719063331.GI18103@ad.usersys.redhat.com> References: <1468901281-22858-1-git-send-email-eblake@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1468901281-22858-1-git-send-email-eblake@redhat.com> Subject: Re: [Qemu-devel] [PATCH for-2.7 v5 00/14] nbd: efficient write zeroes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, qemu-block@nongnu.org On Mon, 07/18 22:07, Eric Blake wrote: > The upstream NBD protocol is proposing an extension for efficient > write zeroes; having a qemu implementation will be one of the reasons > to promote the proposal from experimental to standard: > https://github.com/yoe/nbd/blob/extension-write-zeroes/doc/proto.md My apologies for the last minute reviewing (I've been doing poor in processing my backlog recently)! The only question I have is about the relationship between NO_HOLE and MAY_UNMAP, maybe you or Paolo can clarify that. Otherwise, the series looks good. I've left a few other superficial questions to individual patches. Thanks for the work! Fam