From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753097AbcGSJ5y (ORCPT ); Tue, 19 Jul 2016 05:57:54 -0400 Received: from foss.arm.com ([217.140.101.70]:34480 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752408AbcGSJ5w (ORCPT ); Tue, 19 Jul 2016 05:57:52 -0400 Date: Tue, 19 Jul 2016 10:57:40 +0100 From: Mark Rutland To: Sebastian Andrzej Siewior Cc: Ingo Molnar , anna-maria@linutronix.de, tglx@linutronix.de, hpa@zytor.com, torvalds@linux-foundation.org, will.deacon@arm.com, peterz@infradead.org, linux-kernel@vger.kernel.org, linux-tip-commits@vger.kernel.org Subject: Re: [PATCH v2] arm/perf: Convert to hotplug state machine Message-ID: <20160719095740.GA27022@leverpostej> References: <20160713153335.794097159@linutronix.de> <20160719073502.GA5550@breakpoint.cc> <20160719074803.GA4150@gmail.com> <20160719090229.GA12193@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160719090229.GA12193@linutronix.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tue, Jul 19, 2016 at 11:02:29AM +0200, Sebastian Andrzej Siewior wrote: > +static int arm_pmu_hp_init(void) > +{ > + int ret; > + > + ret = cpuhp_setup_state_nocalls(CPUHP_AP_PERF_ARM_STARTING, > + "AP_PERF_ARM_STARTING", > + arm_perf_starting_cpu, NULL); > + if (ret) > + pr_err("CPU hotplug notifier for ARM PMU could not be " > + "registered: %d\n", ret); Nit: Per Documentation/CodingStyle strings should always be on one line, even if greater than 80 chars, so they're greppable. I assume that can be fixed up when this is picked. Otherwise, v2 looks correct to me. FWIW: Acked-by: Mark Rutland Thanks, Mark.