Re: [RFC][PATCH 07/10 v2] ASoC: hisilicon: Add hi6210 i2s audio driver

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1407 bytes --]

On Tue, Jul 19, 2016 at 04:22:43PM -0700, John Stultz wrote:

>  sound/soc/Kconfig                |   1 +
>  sound/soc/Makefile               |   1 +
>  sound/soc/hisilicon/Kconfig      |   5 +
>  sound/soc/hisilicon/Makefile     |   1 +
>  sound/soc/hisilicon/hi6210-i2s.c | 678 +++++++++++++++++++++++++++++++++++++++
>  sound/soc/hisilicon/hi6210-i2s.h | 276 ++++++++++++++++
>  6 files changed, 962 insertions(+)

This is adding a new binding without documenting it and still looks like
it's far more than an I2S controller.

> +	switch (params_rate(params)) {
> +	default:
> +		dev_err(cpu_dai->dev, "Bad rate\n");
> +		return -EINVAL;

We should tell the user what rate.

> +	if (bits == HII2S_BITS_24) {
> +		i2s->bits = 32;
> +		dma_data->addr_width = 3;
> +	} else {
> +		i2s->bits = 16;
> +		dma_data->addr_width = 2;
> +	}

This looks like it should be a switch statement, there's some similar
stuff for the channels.

> +	_hi6210_i2s_set_fmt(i2s, substream);

Why is this not in line given that this is the only user?

> +	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> +	if (!res) {
> +		ret = -ENODEV;
> +		goto err2;
> +	}
> +
> +	i2s->base = devm_ioremap_resource(dev, res);

devm_ioremap_resource() will check the error.

> +err3:
> +	while (--i2s->clocks)
> +		clk_put(i2s->clk[i2s->clocks]);
> +
> +err2:
> +	kfree(i2s);

You switched to using devm_ but left the error handling.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]