From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752884AbcGTAbz (ORCPT ); Tue, 19 Jul 2016 20:31:55 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:35068 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752335AbcGTAbx (ORCPT ); Tue, 19 Jul 2016 20:31:53 -0400 Date: Wed, 20 Jul 2016 01:31:42 +0100 From: Mark Brown To: John Stultz Cc: lkml , Zhangfei Gao , Jingoo Han , Krzysztof Kozlowski , Maxime Ripard , Vinod Koul , Dan Williams , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Wei Xu , Rob Herring , Andy Green , Andy Green Message-ID: <20160720003142.GD6509@sirena.org.uk> References: <1468970566-24498-1-git-send-email-john.stultz@linaro.org> <1468970566-24498-10-git-send-email-john.stultz@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fOHHtNG4YXGJ0yqR" Content-Disposition: inline In-Reply-To: <1468970566-24498-10-git-send-email-john.stultz@linaro.org> X-Cookie: Sin boldly. User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [RFC][PATCH 09/10 v2] ASoC: hisilicon: Add hi6210 hdmi codec driver X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --fOHHtNG4YXGJ0yqR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 19, 2016 at 04:22:45PM -0700, John Stultz wrote: > Add codec driver for hi6210 hdmi audio output on hi6220 boards. >=20 > This seems like a lot of code just to fill and register a > snd_soc_dai_driver to 2 channel, 16bits, 48k. I suspect there's > a better way. This appears to be open coding HDMI support without any integration with the video side of HDMI (which we have helpers for, see hdmi-codec.c. --fOHHtNG4YXGJ0yqR Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXjsZtAAoJECTWi3JdVIfQBbgH/00GwVJXziAtFSEMZaEgphpp ZxZOnEFbAasggXtM1UCn2Gck7TF+S77gXSudT44xppit0a9VSOUHYcrB4QQDXUZ6 tU9VukqvT3Zhp2kBN6qPTIdjZRx2LCiWB9WdM2u3k2kPwC61VxLiZA0YVMxamJy1 gMu3aeYQRy2w2gECAegRRMzkjPV+X0LJnOm6hlyEV+2/M0AKzshrGHkpB40njtVs 2VE8452hyZ4krV5OqIMHFmGhkJIoBxqnPTG+QkYs48hotKbNg2SS6IEgxpLJNrsF RrN3j+Thi+2ipBpZaPeooCuHWXaFARR8kYY4J4e0R5EY3kCRCP0tuX5taayxV6c= =+1f3 -----END PGP SIGNATURE----- --fOHHtNG4YXGJ0yqR--