From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754003AbcGTRDx (ORCPT ); Wed, 20 Jul 2016 13:03:53 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:59634 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751874AbcGTRDp (ORCPT ); Wed, 20 Jul 2016 13:03:45 -0400 Date: Wed, 20 Jul 2016 11:03:36 -0600 From: Jason Gunthorpe To: Andrey Pronin Cc: Jarkko Sakkinen , Peter Huewe , Marcel Selhorst , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, groeck@chromium.org, smbarber@chromium.org, dianders@chromium.org, Christophe Ricard Subject: Re: [PATCH 2/2] tpm: add driver for cr50 on SPI Message-ID: <20160720170336.GC21460@obsidianresearch.com> References: <1468549218-19215-1-git-send-email-apronin@chromium.org> <1468549218-19215-3-git-send-email-apronin@chromium.org> <20160715033236.GH9347@obsidianresearch.com> <20160715034444.GA28128@apronin> <20160719125527.GB5047@intel.com> <20160720002411.GA147098@apronin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160720002411.GA147098@apronin> User-Agent: Mutt/1.5.23 (2014-03-12) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.151 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 19, 2016 at 05:24:11PM -0700, Andrey Pronin wrote: > The only two things that bother me with such approach are > (1) whatever names I pick for the new set of functions, they > will be similar to and thus might be confused with the > original tpm_tis_read/writeXX; tpm_tis_helper_read16 ? > (2) these functions are phy-specific, so possibly it's better > to create tpm_tis_spi.h and put them there with proper > name prefixes. And then use in tpm_tis_spi and cr50_spi. No, they are generic to any tis phy that implements read only through read_bytes. (Honestly, I'm not sure we made the best choice here having phy functions for all the versions, we are not that performance sensitive, just getting rid of everything but read_bytes from the phy_ops would probably also be a reasonable thing to do.) Jason From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH 2/2] tpm: add driver for cr50 on SPI Date: Wed, 20 Jul 2016 11:03:36 -0600 Message-ID: <20160720170336.GC21460@obsidianresearch.com> References: <1468549218-19215-1-git-send-email-apronin@chromium.org> <1468549218-19215-3-git-send-email-apronin@chromium.org> <20160715033236.GH9347@obsidianresearch.com> <20160715034444.GA28128@apronin> <20160719125527.GB5047@intel.com> <20160720002411.GA147098@apronin> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20160720002411.GA147098@apronin> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Andrey Pronin Cc: Christophe Ricard , dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, smbarber-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, groeck-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Tue, Jul 19, 2016 at 05:24:11PM -0700, Andrey Pronin wrote: > The only two things that bother me with such approach are > (1) whatever names I pick for the new set of functions, they > will be similar to and thus might be confused with the > original tpm_tis_read/writeXX; tpm_tis_helper_read16 ? > (2) these functions are phy-specific, so possibly it's better > to create tpm_tis_spi.h and put them there with proper > name prefixes. And then use in tpm_tis_spi and cr50_spi. No, they are generic to any tis phy that implements read only through read_bytes. (Honestly, I'm not sure we made the best choice here having phy functions for all the versions, we are not that performance sensitive, just getting rid of everything but read_bytes from the phy_ops would probably also be a reasonable thing to do.) Jason ------------------------------------------------------------------------------ What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports.http://sdm.link/zohodev2dev