From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752650AbcGUAfy (ORCPT ); Wed, 20 Jul 2016 20:35:54 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:46734 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751347AbcGUAfs (ORCPT ); Wed, 20 Jul 2016 20:35:48 -0400 Date: Thu, 21 Jul 2016 02:35:45 +0200 From: Andrew Lunn To: Vivien Didelot Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli Subject: Re: [PATCH net-next] net: dsa: add CONFIG_NET_DSA_LEGACY Message-ID: <20160721003545.GB22834@lunn.ch> References: <20160720222641.30899-1-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160720222641.30899-1-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 20, 2016 at 06:26:41PM -0400, Vivien Didelot wrote: > This patch simply moves the legacy DSA code from dsa.c to legacy.c, > except the few shared symbols which remain in dsa.c. I think it is a bit early for this. Lets convert all in kernel users to the new binding first. > Signed-off-by: Vivien Didelot > --- > drivers/net/dsa/Kconfig | 4 +- > drivers/net/dsa/mv88e6xxx/chip.c | 8 + > include/net/dsa.h | 4 + > net/dsa/Kconfig | 8 + > net/dsa/Makefile | 1 + > net/dsa/dsa.c | 985 ------------------------------------ > net/dsa/legacy.c | 1013 ++++++++++++++++++++++++++++++++++++++ I'm surprised git did not notice this is a rename. Andrew