Re: [PATCH 04/15] drm/arm: Use per-plane rotation property

[Brian Starkey <brian.starkey@arm.com>]

On Fri, Jul 22, 2016 at 04:43:05PM +0300, Ville Syrjälä wrote:
>From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
>The global mode_config.rotation_property is going away, switch over to
>per-plane rotation_property.
>
>Cc: Liviu Dudau <liviu.dudau@arm.com>
>Cc: Brian Starkey <brian.starkey@arm.com>
>Cc: Mali DP Maintainers <malidp@foss.arm.com>
>Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Acked-by: Brian Starkey <brian.starkey@arm.com>

Thanks!

-Brian
>---
> drivers/gpu/drm/arm/malidp_planes.c | 13 +++++--------
> 1 file changed, 5 insertions(+), 8 deletions(-)
>
>diff --git a/drivers/gpu/drm/arm/malidp_planes.c b/drivers/gpu/drm/arm/malidp_planes.c
>index 725098d6179a..7fbe1feec861 100644
>--- a/drivers/gpu/drm/arm/malidp_planes.c
>+++ b/drivers/gpu/drm/arm/malidp_planes.c
>@@ -254,21 +254,18 @@ int malidp_de_planes_init(struct drm_device *drm)
> 		if (ret < 0)
> 			goto cleanup;
>
>-		if (!drm->mode_config.rotation_property) {
>+		/* SMART layer can't be rotated */
>+		if (id != DE_SMART) {
> 			unsigned long flags = BIT(DRM_ROTATE_0) |
> 					      BIT(DRM_ROTATE_90) |
> 					      BIT(DRM_ROTATE_180) |
> 					      BIT(DRM_ROTATE_270) |
> 					      BIT(DRM_REFLECT_X) |
> 					      BIT(DRM_REFLECT_Y);
>-			drm->mode_config.rotation_property =
>-				drm_mode_create_rotation_property(drm, flags);
>+			drm_plane_create_rotation_property(&plane->base,
>+							   BIT(DRM_ROTATE_0),
>+							   flags);
> 		}
>-		/* SMART layer can't be rotated */
>-		if (drm->mode_config.rotation_property && (id != DE_SMART))
>-			drm_object_attach_property(&plane->base.base,
>-						   drm->mode_config.rotation_property,
>-						   BIT(DRM_ROTATE_0));
>
> 		drm_plane_helper_add(&plane->base,
> 				     &malidp_de_plane_helper_funcs);
>-- 
>2.7.4
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx