From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41604) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQxeb-0007vp-DC for qemu-devel@nongnu.org; Sat, 23 Jul 2016 10:11:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQxeY-00056e-US for qemu-devel@nongnu.org; Sat, 23 Jul 2016 10:11:44 -0400 Received: from ozlabs.org ([2401:3900:2:1::2]:34068) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQxeY-00055n-1L for qemu-devel@nongnu.org; Sat, 23 Jul 2016 10:11:42 -0400 Date: Sat, 23 Jul 2016 16:30:31 +1000 From: David Gibson Message-ID: <20160723063031.GZ15941@voom.fritz.box> References: <1469119676-32373-1-git-send-email-lvivier@redhat.com> <20160722064311.GU15941@voom.fritz.box> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="yTwVabqJa5IUz21H" Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v2] test: port postcopy test to ppc64 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier Cc: qemu-devel@nongnu.org, dgilbert@redhat.com, thuth@redhat.com, dgibson@redhat.com --yTwVabqJa5IUz21H Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 22, 2016 at 09:28:58AM +0200, Laurent Vivier wrote: >=20 >=20 > On 22/07/2016 08:43, David Gibson wrote: > > On Thu, Jul 21, 2016 at 06:47:56PM +0200, Laurent Vivier wrote: > >> As userfaultfd syscall is available on powerpc, migration > >> postcopy can be used. > >> > >> This patch adds the support needed to test this on powerpc, > >> instead of using a bootsector to run code to modify memory, > >> we use a FORTH script in "boot-command" property. > >> > >> As spapr machine doesn't support "-prom-env" argument > >> (the nvram is initialized by SLOF and not by QEMU), > >> "boot-command" is provided to SLOF via a file mapped nvram > >> (with "-drive file=3D...,if=3Dpflash") > >> > >> Signed-off-by: Laurent Vivier > >> --- > >> v2: move FORTH script directly in sprintf() > >> use openbios_firmware_abi.h > >> remove useless "default" case > >> > >> tests/Makefile.include | 1 + > >> tests/postcopy-test.c | 116 ++++++++++++++++++++++++++++++++++++++++= +-------- > >> 2 files changed, 98 insertions(+), 19 deletions(-) > >=20 > > There's a mostly cosmetic problem with this. If you run make check > > for a ppc64 target on an x86 machine, you get: > >=20 > > GTESTER check-qtest-ppc64 > > "kvm" accelerator not found. > > "kvm" accelerator not found. >=20 > I think this is because of "-machine accel=3Dkvm:tcg", it tries to use kvm > and fall back to tcg. >=20 > accel.c: >=20 > 80 void configure_accelerator(MachineState *ms) > 81 { > ... > 100 acc =3D accel_find(buf); > 101 if (!acc) { > 102 fprintf(stderr, "\"%s\" accelerator not found.\n", bu= f); > 103 continue; > 104 } >=20 > We can remove the "-machine" argument to use the default instead (tcg or > kvm). That sounds like a good option for a general test. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --yTwVabqJa5IUz21H Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXkw8HAAoJEGw4ysog2bOSlkYQAM9MYa6ZBy1PkPj+nCLFZloz HHkOPy1Z/9Suxi0FNYG/46+I5Fi3BSqQwC7hNBdbBrrb3a2DfwMVNCRWFWOUxE2T RRrAWPwgOc2OoaWT+Vk/PH0rNHwtjnggADhKS7jNhcCJf33Z1aBf2ee6bTSTt1Q1 LhUmzEDwaH21tHg93Nl2h1vMIxbCKRpAsaQgteEOaekno5epKyMrbwU6ckleLV5D n7p9yYKMYWgZVhA5Ml0TQ/XQ7SKbxoBiwcryYoejfdMA0RDyt6MNZMpiIocRwBcP yM6EbMPb+ClyfFdmvrPy5lrHM1glkvjl81upUbF1FJl4KNJD7ugeC5f4ZJWJiLak l+Lo4a0SCjBz1LCjxnO4ZZjdh4KgCLzpnpaDV/0pYsxdfCeK+f9jWwF5iMKO2bt5 wHz49wC/xAzF1syZhp2bBNQUtY5ZDCIhBstZIqXUSW36KrMRN0YqsVNUc8GJfkHp glRmMpQhdt0/uNAdoGgw1rdGwZttg3G4I7g7LYlNTxv2o+NLacyUOExy6C9vMpLw PvWCR6L/b/WnJySewX0IOgZcuh9ViXF33pga6qCLm7j90m8wGPcDWn9NSovQkaoD TeEYJ83leoXhoaXWYhUrkoE8B0YUgyep9mfQ2J2y+W96SUW5I7SpJ5mf2CxpDbbN yKvZ5Yvsf3KtaF6rk1Kd =cOSw -----END PGP SIGNATURE----- --yTwVabqJa5IUz21H--