From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Subject: Re: [PATCH 04/10] dmaending: qcom_hidma: configure DMA and MSI for OF Date: Sun, 24 Jul 2016 12:03:12 +0530 Message-ID: <20160724063312.GZ9681@localhost> References: <1468867177-15007-1-git-send-email-okaya@codeaurora.org> <1468867177-15007-5-git-send-email-okaya@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mga01.intel.com ([192.55.52.88]:62216 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750864AbcGXGZu (ORCPT ); Sun, 24 Jul 2016 02:25:50 -0400 Content-Disposition: inline In-Reply-To: <1468867177-15007-5-git-send-email-okaya@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Sinan Kaya Cc: "dmaengine@vger.kernel.org" , "timur@codeaurora.org" , "devicetree@vger.kernel.org" , "cov@codeaurora.org" , "jcm@redhat.com" , "eric.auger@linaro.org" , "agross@codeaurora.org" , "arnd@arndb.de" , "linux-arm-msm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "Williams, Dan J" , Andy Shevchenko , "linux-kernel@vger.kernel.org" On Tue, Jul 19, 2016 at 12:09:31AM +0530, Sinan Kaya wrote: > Configure the DMA bindings for the device tree based firmware. > > Signed-off-by: Sinan Kaya > --- > drivers/dma/qcom/hidma_mgmt.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/dma/qcom/hidma_mgmt.c b/drivers/dma/qcom/hidma_mgmt.c > index c0e3653..fb30730 100644 > --- a/drivers/dma/qcom/hidma_mgmt.c > +++ b/drivers/dma/qcom/hidma_mgmt.c > @@ -375,8 +375,10 @@ static int __init hidma_mgmt_of_populate_channels(struct device_node *np) > ret = -ENODEV; > goto out; > } > + of_node_get(child); > + new_pdev->dev.of_node = child; > of_dma_configure(&new_pdev->dev, child); > - > + of_msi_configure(&new_pdev->dev, child); How would this work on non MSI platforms? -- ~Vinod From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751973AbcGXGZx (ORCPT ); Sun, 24 Jul 2016 02:25:53 -0400 Received: from mga01.intel.com ([192.55.52.88]:62216 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750864AbcGXGZu (ORCPT ); Sun, 24 Jul 2016 02:25:50 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,412,1464678000"; d="scan'208";a="852210808" Date: Sun, 24 Jul 2016 12:03:12 +0530 From: Vinod Koul To: Sinan Kaya Cc: "dmaengine@vger.kernel.org" , "timur@codeaurora.org" , "devicetree@vger.kernel.org" , "cov@codeaurora.org" , "jcm@redhat.com" , "eric.auger@linaro.org" , "agross@codeaurora.org" , "arnd@arndb.de" , "linux-arm-msm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "Williams, Dan J" , Andy Shevchenko , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 04/10] dmaending: qcom_hidma: configure DMA and MSI for OF Message-ID: <20160724063312.GZ9681@localhost> References: <1468867177-15007-1-git-send-email-okaya@codeaurora.org> <1468867177-15007-5-git-send-email-okaya@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1468867177-15007-5-git-send-email-okaya@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 19, 2016 at 12:09:31AM +0530, Sinan Kaya wrote: > Configure the DMA bindings for the device tree based firmware. > > Signed-off-by: Sinan Kaya > --- > drivers/dma/qcom/hidma_mgmt.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/dma/qcom/hidma_mgmt.c b/drivers/dma/qcom/hidma_mgmt.c > index c0e3653..fb30730 100644 > --- a/drivers/dma/qcom/hidma_mgmt.c > +++ b/drivers/dma/qcom/hidma_mgmt.c > @@ -375,8 +375,10 @@ static int __init hidma_mgmt_of_populate_channels(struct device_node *np) > ret = -ENODEV; > goto out; > } > + of_node_get(child); > + new_pdev->dev.of_node = child; > of_dma_configure(&new_pdev->dev, child); > - > + of_msi_configure(&new_pdev->dev, child); How would this work on non MSI platforms? -- ~Vinod From mboxrd@z Thu Jan 1 00:00:00 1970 From: vinod.koul@intel.com (Vinod Koul) Date: Sun, 24 Jul 2016 12:03:12 +0530 Subject: [PATCH 04/10] dmaending: qcom_hidma: configure DMA and MSI for OF In-Reply-To: <1468867177-15007-5-git-send-email-okaya@codeaurora.org> References: <1468867177-15007-1-git-send-email-okaya@codeaurora.org> <1468867177-15007-5-git-send-email-okaya@codeaurora.org> Message-ID: <20160724063312.GZ9681@localhost> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Jul 19, 2016 at 12:09:31AM +0530, Sinan Kaya wrote: > Configure the DMA bindings for the device tree based firmware. > > Signed-off-by: Sinan Kaya > --- > drivers/dma/qcom/hidma_mgmt.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/dma/qcom/hidma_mgmt.c b/drivers/dma/qcom/hidma_mgmt.c > index c0e3653..fb30730 100644 > --- a/drivers/dma/qcom/hidma_mgmt.c > +++ b/drivers/dma/qcom/hidma_mgmt.c > @@ -375,8 +375,10 @@ static int __init hidma_mgmt_of_populate_channels(struct device_node *np) > ret = -ENODEV; > goto out; > } > + of_node_get(child); > + new_pdev->dev.of_node = child; > of_dma_configure(&new_pdev->dev, child); > - > + of_msi_configure(&new_pdev->dev, child); How would this work on non MSI platforms? -- ~Vinod