From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752010AbcGXHRr (ORCPT <rfc822;w@1wt.eu>);
	Sun, 24 Jul 2016 03:17:47 -0400
Received: from mga03.intel.com ([134.134.136.65]:29782 "EHLO mga03.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751502AbcGXHRq (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sun, 24 Jul 2016 03:17:46 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.28,412,1464678000"; 
   d="scan'208";a="852231020"
Date: Sun, 24 Jul 2016 12:55:09 +0530
From: Vinod Koul <vinod.koul@intel.com>
To: John Stultz <john.stultz@linaro.org>
Cc: lkml <linux-kernel@vger.kernel.org>, Andy Green <andy.green@linaro.org>,
        Zhangfei Gao <zhangfei.gao@linaro.org>,
        Jingoo Han <jg1.han@samsung.com>,
        Krzysztof Kozlowski <k.kozlowski@samsung.com>,
        Maxime Ripard <maxime.ripard@free-electrons.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Mark Brown <broonie@kernel.org>, Andy Green <andy@warmcat.com>
Subject: Re: [PATCH 1/7] k3dma: Fix hisi burst clipping
Message-ID: <20160724072509.GC9681@localhost>
References: <1469073189-9167-1-git-send-email-john.stultz@linaro.org>
 <1469073189-9167-2-git-send-email-john.stultz@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1469073189-9167-2-git-send-email-john.stultz@linaro.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jul 20, 2016 at 08:53:03PM -0700, John Stultz wrote:
> From: Andy Green <andy.green@linaro.org>
> 
> Max burst len is a 4-bit field, but at the moment it's clipped with
> a 5-bit constant... reduce it to that which can be expressed

Maybe we should GENMASK() etc to avoid these errors..

>  	if ((maxburst == 0) || (maxburst > 16))
> -		val = 16;
> +		val = 15;

-- 
~Vinod