Re: [PATCH 4/7] k3dma: Add cyclic mode for audio

From: Vinod Koul <vinod.koul@intel.com>
To: John Stultz <john.stultz@linaro.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
	Andy Green <andy.green@linaro.org>,
	Zhangfei Gao <zhangfei.gao@linaro.org>,
	Jingoo Han <jg1.han@samsung.com>,
	Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	Maxime Ripard <maxime.ripard@free-electrons.com>,
	Dan Williams <dan.j.williams@intel.com>,
	Mark Brown <broonie@kernel.org>, Andy Green <andy@warmcat.com>
Subject: Re: [PATCH 4/7] k3dma: Add cyclic mode for audio
Date: Sun, 24 Jul 2016 13:01:09 +0530	[thread overview]
Message-ID: <20160724073108.GD9681@localhost> (raw)
In-Reply-To: <1469073189-9167-5-git-send-email-john.stultz@linaro.org>

On Wed, Jul 20, 2016 at 08:53:06PM -0700, John Stultz wrote:

>  	ds = kzalloc(sizeof(*ds) + num * sizeof(ds->desc_hw[0]), GFP_ATOMIC);
> -	if (!ds) {
> -		dev_dbg(chan->device->dev, "vchan %p: kzalloc fail\n", &c->vc);
> +	if (!ds)

This is an unrelated change

> +
> +	ds = kzalloc(sizeof(*ds) + num * sizeof(ds->desc_hw[0]), GFP_ATOMIC);

we should use GFP_NOWAIT. And looks like driver doesn't use GFP_NOWAIT< so
you may fix that up as well

> +	if (!ds)
> +		return NULL;
> +
> +	ds->desc_hw_lli = __virt_to_phys((unsigned long)&ds->desc_hw[0]);

why no dma_map_single(()?

Also __api is internal APIs, driver should not use them. Why not plain
virt_to_phys()

-- 
~Vinod