[PATCH] mm: add per-zone lru list stat -fix

[PATCH] mm: add per-zone lru list stat -fix

[Mel Gorman]

This patch renames the zone LRU stats as printed in /proc/vmstat to avoid
confusion. This keeps both the node and zone stats which normally will be
redundant but should always be roughly in sync.

This is a fix to the mmotm patch mm-add-per-zone-lru-list-stat.patch

Signed-off-by: Mel Gorman <mgorman@techsingularity.net>
---
 mm/vmstat.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/mm/vmstat.c b/mm/vmstat.c
index e1a46906c61b..89cec42d19ff 100644
--- a/mm/vmstat.c
+++ b/mm/vmstat.c
@@ -921,11 +921,11 @@ int fragmentation_index(struct zone *zone, unsigned int order)
 const char * const vmstat_text[] = {
 	/* enum zone_stat_item countes */
 	"nr_free_pages",
-	"nr_inactive_anon",
-	"nr_active_anon",
-	"nr_inactive_file",
-	"nr_active_file",
-	"nr_unevictable",
+	"nr_zone_inactive_anon",
+	"nr_zone_active_anon",
+	"nr_zone_inactive_file",
+	"nr_zone_active_file",
+	"nr_zone_unevictable",
 	"nr_zone_write_pending",
 	"nr_mlock",
 	"nr_slab_reclaimable",

[PATCH] mm: add per-zone lru list stat -fix

[Mel Gorman]

This patch renames the zone LRU stats as printed in /proc/vmstat to avoid
confusion. This keeps both the node and zone stats which normally will be
redundant but should always be roughly in sync.

This is a fix to the mmotm patch mm-add-per-zone-lru-list-stat.patch

Signed-off-by: Mel Gorman <mgorman@techsingularity.net>
---
 mm/vmstat.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/mm/vmstat.c b/mm/vmstat.c
index e1a46906c61b..89cec42d19ff 100644
--- a/mm/vmstat.c
+++ b/mm/vmstat.c
@@ -921,11 +921,11 @@ int fragmentation_index(struct zone *zone, unsigned int order)
 const char * const vmstat_text[] = {
 	/* enum zone_stat_item countes */
 	"nr_free_pages",
-	"nr_inactive_anon",
-	"nr_active_anon",
-	"nr_inactive_file",
-	"nr_active_file",
-	"nr_unevictable",
+	"nr_zone_inactive_anon",
+	"nr_zone_active_anon",
+	"nr_zone_inactive_file",
+	"nr_zone_active_file",
+	"nr_zone_unevictable",
 	"nr_zone_write_pending",
 	"nr_mlock",
 	"nr_slab_reclaimable",

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] mm: add per-zone lru list stat -fix

[Minchan Kim]

On Mon, Jul 25, 2016 at 08:23:00AM +0100, Mel Gorman wrote:
> This patch renames the zone LRU stats as printed in /proc/vmstat to avoid
> confusion. This keeps both the node and zone stats which normally will be
> redundant but should always be roughly in sync.
> 
> This is a fix to the mmotm patch mm-add-per-zone-lru-list-stat.patch
> 
> Signed-off-by: Mel Gorman <mgorman@techsingularity.net>

Actually, I don't have any number to prove how much keeping the stat
both zone and node increases performance but I don't object it.

Acked-by: Minchan Kim <minchan@kernel.org>

Thanks.

Re: [PATCH] mm: add per-zone lru list stat -fix

[Minchan Kim]

On Mon, Jul 25, 2016 at 08:23:00AM +0100, Mel Gorman wrote:
> This patch renames the zone LRU stats as printed in /proc/vmstat to avoid
> confusion. This keeps both the node and zone stats which normally will be
> redundant but should always be roughly in sync.
> 
> This is a fix to the mmotm patch mm-add-per-zone-lru-list-stat.patch
> 
> Signed-off-by: Mel Gorman <mgorman@techsingularity.net>

Actually, I don't have any number to prove how much keeping the stat
both zone and node increases performance but I don't object it.

Acked-by: Minchan Kim <minchan@kernel.org>

Thanks.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>