From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755128AbcGZGym (ORCPT ); Tue, 26 Jul 2016 02:54:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33156 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754708AbcGZGyj (ORCPT ); Tue, 26 Jul 2016 02:54:39 -0400 Date: Tue, 26 Jul 2016 08:54:33 +0200 From: Jiri Olsa To: Songshan Gong Cc: acme@kernel.org, jolsa@kernel.org, dsahern@gmail.com, linux-kernel@vger.kernel.org, borntraeger@de.ibm.com Subject: Re: [PATCH] s390/perf: fix 'start' address of module's map Message-ID: <20160726065433.GA4517@krava> References: <1469070651-6447-1-git-send-email-gongss@linux.vnet.ibm.com> <1469070651-6447-2-git-send-email-gongss@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.6.2 (2016-07-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 26 Jul 2016 06:54:38 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 22, 2016 at 10:47:34AM +0800, Songshan Gong wrote: > Has the patch been accepted by upstream? > > 在 7/21/2016 11:10 AM, Song Shan Gong 写道: > > At preset, when creating module's map, perf gets 'start' address by parsing > > '/proc/modules', but it's module base address, isn't the start address of > > '.text' section. In most archs, it's OK. But for s390, it places 'GOT' and > > 'PLT' relocations before '.text' section. So there exists an offset between > > module base address and '.text' section, which will incur wrong symbol > > resolution for modules. > > > > Fix this bug by getting 'start' address of module's map from parsing > > '/sys/module/[module name]/sections/.text', not from '/proc/modules'. > > > > Signed-off-by: Song Shan Gong > > Acked-by: Jiri Olsa I think it's good to go, Arnaldo, could you please take this one? thanks, jirka