From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758560AbcG0VCi (ORCPT ); Wed, 27 Jul 2016 17:02:38 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:33175 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752275AbcG0VCf (ORCPT ); Wed, 27 Jul 2016 17:02:35 -0400 Date: Wed, 27 Jul 2016 14:02:32 -0700 From: Andrey Pronin To: Jason Gunthorpe Cc: Rob Herring , Jarkko Sakkinen , Peter Huewe , Marcel Selhorst , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Christophe Ricard , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , devicetree@vger.kernel.org Subject: Re: [PATCH v2 1/2] tpm: devicetree: document properties for cr50 Message-ID: <20160727210232.GB119121@apronin> References: <1468549218-19215-1-git-send-email-apronin@chromium.org> <5274cc806888a709c639e701dad894543885b2c9.1468985673.git.apronin@chromium.org> <20160720190303.GA5620@rob-hp-laptop> <20160720194912.GA61154@apronin> <20160720195422.GA30947@obsidianresearch.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160720195422.GA30947@obsidianresearch.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 20, 2016 at 01:54:22PM -0600, Jason Gunthorpe wrote: > On Wed, Jul 20, 2016 at 12:49:12PM -0700, Andrey Pronin wrote: > > > Sorry, I just updated this patch description in v2 to indicate why they are not > > hard-coded, but didn't answer explicitly. As the firmware changes, a different > > revision of it can have a different time before it sleeps in its configuration, > > or the time it takes it to startup may be different. Thus, there's a way to > > set it here w/o changing the driver. > > This sort of stuff should be read out of the firmware, not DT.. > > Why has Google created such a non-standard TPM firmware??? > > Jason Thanks, Jason. Will hard-code those in the driver instead of reading from DT. Andrey From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrey Pronin Subject: Re: [PATCH v2 1/2] tpm: devicetree: document properties for cr50 Date: Wed, 27 Jul 2016 14:02:32 -0700 Message-ID: <20160727210232.GB119121@apronin> References: <1468549218-19215-1-git-send-email-apronin@chromium.org> <5274cc806888a709c639e701dad894543885b2c9.1468985673.git.apronin@chromium.org> <20160720190303.GA5620@rob-hp-laptop> <20160720194912.GA61154@apronin> <20160720195422.GA30947@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20160720195422.GA30947-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Jason Gunthorpe Cc: Mark Rutland , Rob Herring , Christophe Ricard , Pawel Moll , Ian Campbell , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Kumar Gala List-Id: devicetree@vger.kernel.org On Wed, Jul 20, 2016 at 01:54:22PM -0600, Jason Gunthorpe wrote: > On Wed, Jul 20, 2016 at 12:49:12PM -0700, Andrey Pronin wrote: > > > Sorry, I just updated this patch description in v2 to indicate why they are not > > hard-coded, but didn't answer explicitly. As the firmware changes, a different > > revision of it can have a different time before it sleeps in its configuration, > > or the time it takes it to startup may be different. Thus, there's a way to > > set it here w/o changing the driver. > > This sort of stuff should be read out of the firmware, not DT.. > > Why has Google created such a non-standard TPM firmware??? > > Jason Thanks, Jason. Will hard-code those in the driver instead of reading from DT. Andrey ------------------------------------------------------------------------------