From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752149AbcG2EAv (ORCPT ); Fri, 29 Jul 2016 00:00:51 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:41000 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752009AbcG2EAt (ORCPT ); Fri, 29 Jul 2016 00:00:49 -0400 Date: Thu, 28 Jul 2016 21:00:48 -0700 (PDT) Message-Id: <20160728.210048.165773321219658930.davem@davemloft.net> To: nitin.m.gupta@oracle.com Cc: akpm@linux-foundation.org, dingel@linux.vnet.ibm.com, schwidefsky@de.ibm.com, kirill.shutemov@linux.intel.com, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] sparc64: Fix pagetable freeing for hugepage regions From: David Miller In-Reply-To: <1466719639-143815-2-git-send-email-nitin.m.gupta@oracle.com> References: <1466719639-143815-1-git-send-email-nitin.m.gupta@oracle.com> <1466719639-143815-2-git-send-email-nitin.m.gupta@oracle.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 28 Jul 2016 21:00:48 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nitin Gupta Date: Thu, 23 Jun 2016 15:05:36 -0700 > 8M pages now allocate page tables till PMD level only. > So, when freeing page table for 8M hugepage backed region, > make sure we don't try to access non-existent PTE level. > > Signed-off-by: Nitin Gupta The manner in which you have submitted this change breaks bisectability. The "problem" you are fixing here is introduced by you in patch #1. You need to combine these two changes together, otherwise there is an intermediate state where the kernel is broken by your changes. From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Date: Fri, 29 Jul 2016 04:00:48 +0000 Subject: Re: [PATCH v2 2/2] sparc64: Fix pagetable freeing for hugepage regions Message-Id: <20160728.210048.165773321219658930.davem@davemloft.net> List-Id: References: <1466719639-143815-1-git-send-email-nitin.m.gupta@oracle.com> <1466719639-143815-2-git-send-email-nitin.m.gupta@oracle.com> In-Reply-To: <1466719639-143815-2-git-send-email-nitin.m.gupta@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: nitin.m.gupta@oracle.com Cc: akpm@linux-foundation.org, dingel@linux.vnet.ibm.com, schwidefsky@de.ibm.com, kirill.shutemov@linux.intel.com, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org From: Nitin Gupta Date: Thu, 23 Jun 2016 15:05:36 -0700 > 8M pages now allocate page tables till PMD level only. > So, when freeing page table for 8M hugepage backed region, > make sure we don't try to access non-existent PTE level. > > Signed-off-by: Nitin Gupta The manner in which you have submitted this change breaks bisectability. The "problem" you are fixing here is introduced by you in patch #1. You need to combine these two changes together, otherwise there is an intermediate state where the kernel is broken by your changes.