From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42015) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSmUC-0001Pu-Lc for qemu-devel@nongnu.org; Thu, 28 Jul 2016 10:40:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bSmUB-0001D2-Pv for qemu-devel@nongnu.org; Thu, 28 Jul 2016 10:40:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54738) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSmUB-0001Cs-Hk for qemu-devel@nongnu.org; Thu, 28 Jul 2016 10:40:31 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1E9FD8122E for ; Thu, 28 Jul 2016 14:40:31 +0000 (UTC) From: marcandre.lureau@redhat.com Date: Thu, 28 Jul 2016 18:38:06 +0400 Message-Id: <20160728143808.13707-36-marcandre.lureau@redhat.com> In-Reply-To: <20160728143808.13707-1-marcandre.lureau@redhat.com> References: <20160728143808.13707-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH v2 35/37] tests: fix rsp leak in postcopy-test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: eblake@redhat.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= From: Marc-Andr=C3=A9 Lureau In all cases, even when the dict doesn't contain 'ram', the qmp response must be unref. Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Eric Blake --- tests/postcopy-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/postcopy-test.c b/tests/postcopy-test.c index 74fa969..f6f6598 100644 --- a/tests/postcopy-test.c +++ b/tests/postcopy-test.c @@ -198,8 +198,8 @@ static uint64_t get_migration_pass(void) } else { rsp_ram =3D qdict_get_qdict(rsp_return, "ram"); result =3D qdict_get_try_int(rsp_ram, "dirty-sync-count", 0); - QDECREF(rsp); } + QDECREF(rsp); return result; } =20 --=20 2.9.0