From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 18/31] drm/i915: Simplify request_alloc by returning the allocated request Date: Thu, 28 Jul 2016 16:10:51 +0100 Message-ID: <20160728151051.GF7626@nuc-i3427.alporthouse.com> References: <1469432687-22756-1-git-send-email-chris@chris-wilson.co.uk> <1469432687-22756-19-git-send-email-chris@chris-wilson.co.uk> <1469438325.5495.36.camel@linux.intel.com> <8836175e-69ea-a46c-bc8d-f404243a6002@intel.com> <20160727152818.GR31051@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id 07B886E84E for ; Thu, 28 Jul 2016 15:10:56 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dave Gordon Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBKdWwgMjgsIDIwMTYgYXQgMDE6NDg6MzJQTSArMDEwMCwgRGF2ZSBHb3Jkb24gd3Jv dGU6Cj4gT24gMjcvMDcvMTYgMTY6MjgsIENocmlzIFdpbHNvbiB3cm90ZToKPiA+T24gV2VkLCBK dWwgMjcsIDIwMTYgYXQgMTI6MDg6MzVQTSArMDEwMCwgRGF2ZSBHb3Jkb24gd3JvdGU6Cj4gPj5P biAyNS8wNy8xNiAxMDoxOCwgSm9vbmFzIExhaHRpbmVuIHdyb3RlOgo+ID4+Pk9uIG1hLCAyMDE2 LTA3LTI1IGF0IDA4OjQ0ICswMTAwLCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4gPj4+PklmIGlzIHNp bXBsZXIgYW5kIGxlYWRzIHRvIG1vcmUgcmVhZGFibGUgY29kZSB0aHJvdWdoIHRoZSBjYWxsc3Rh Y2sgaWYKPiA+Pj4+dGhlIGFsbG9jYXRpb24gcmV0dXJucyB0aGUgYWxsb2NhdGVkIHN0cnVjdCB0 aHJvdWdoIHRoZSByZXR1cm4gdmFsdWUuCj4gPj4+Pgo+ID4+Pj5UaGUgaW1wb3J0YW5jZSBvZiB0 aGlzIGlzIHRoYXQgaXQgbm8gbG9uZ2VyIGxvb2tzIGxpa2Ugd2UgYWNjaWRlbnRhbGx5Cj4gPj4+ PmFsbG9jYXRlIHJlcXVlc3RzIGFzIHNpZGUtZWZmZWN0IG9mIGNhbGxpbmcgLgo+ID4+Pgo+ID4+ PkRhdmUgc2VlbXMgdG8gaGF2ZSBleHByZXNzZWQgdG8gd2lzaCB0byByZXZpZXcgdGhpcyBhcm91 bmQgSmFudWFyeSwgc28KPiA+Pj5DQydpbmcgaGltIGhlcmUuCj4gPj4+Cj4gPj4+RnJvbSBtZSwK PiA+Pj4KPiA+Pj5SZXZpZXdlZC1ieTogSm9vbmFzIExhaHRpbmVuIDxqb29uYXMubGFodGluZW5A bGludXguaW50ZWwuY29tPgo+ID4+Pgo+ID4+Pj5TaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24g PGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiA+Pj4+LS0tCj4gPj4+PmRyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZHJ2LmggICAgICAgICAgICB8ICAzICstCj4gPj4+PmRyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZ2VtLmMgICAgICAgICAgICB8IDc1ICsrKysrKysrLS0tLS0tLS0tLS0tLS0t LS0tLS0tLQo+ID4+Pj5kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9leGVjYnVmZmVyLmMg fCAxMiArKy0tLQo+ID4+Pj5kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9yZXF1ZXN0LmMg ICAgfCA1OCArKysrKysrKy0tLS0tLS0tLS0tLS0tLQo+ID4+Pj5kcml2ZXJzL2dwdS9kcm0vaTkx NS9pOTE1X3RyYWNlLmggICAgICAgICAgfCAxMyArKystLS0KPiA+Pj4+ZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZGlzcGxheS5jICAgICAgIHwgMzYgKysrKysrLS0tLS0tLS0KPiA+Pj4+ZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMgICAgICAgICAgIHwgIDIgKy0KPiA+Pj4+ZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfb3ZlcmxheS5jICAgICAgIHwgMjAgKysrKy0tLS0KPiA+ Pj4+OCBmaWxlcyBjaGFuZ2VkLCA3OSBpbnNlcnRpb25zKCspLCAxNDAgZGVsZXRpb25zKC0pCj4g Pj4KPiA+PlRoZSBhY3R1YWwgY29kZSBsb29rcyBmaW5lLCBidXQgdGhlIHBhdGNoIGFtYWxnYW1h dGVzIHNldmVyYWwKPiA+PmRpZmZlcmVudCBjaGFuZ2VzLCBvbmx5IG9uZSAgb2Ygd2hpY2ggaXMg bWVudGlvbmVkIGluIHRoZQo+ID4+ZGVzY3JpcHRpb24gYWJvdmUuCj4gPj4KPiA+PjEuIENoYW5n ZSB0aGUgc2lnbmF0dXJlIG9mIGk5MTVfZ2VtX29iamVjdF9zeW5jKCkgYW5kIGl0cyBpbnRlcm5h bAo+ID4+ICAgc3ViZnVuY3Rpb24gX19pOTE1X2dlbV9vYmplY3Rfc3luYygpIHRvIGFsd2F5cyBy ZXF1aXJlIGEgcmVxdWVzdAo+ID4+ICAgYXMgaW5wdXQsIHdpdGggY29ycmVzcG9uZGluZyByZXdv cmsgb2YgdGhlIGNhbGxzaXRlcy4gVGhpcyBlbmFibGVzCj4gPj4gICB0aGUgcmVtb3ZhbCBvZiB0 aGUgaW50ZXJuYWwgY2FsbCB0byBpOTE1X2dlbV9yZXF1ZXN0X2FsbG9jKCkuCj4gPj4KPiA+PjIu IENoYW5nZSBBUEkgb2YgaTkxNV9nZW1fcmVxdWVzdF9hbGxvYygpIG5vdCB0byBhbGxvdyBOVUxM IGN0eCwKPiA+PiAgIHdoaWNoIGludm9sdmVzIGNoYW5naW5nIHZhcmlvdXMgb2YgdGhlIHJlbWFp bmluZyBjYWxsc2l0ZXMuCj4gPgo+ID5SZXZlcnRzIHRoZSB1bndhbnRlZCB0aGUgY2hhbmdlLgo+ IAo+IE5vLCAyIGFuZCAzIHRvZ2V0aGVyIGRvIE5PVCByZXZlcnQgdGhlIGNoYW5nZSAyNjgyNzA4 ODMgYmVjYXVzZQo+IHRoYXQncyB3aGF0IG9yaWdpbmFsbHkgY2hhbmdlZCB0aGUgQVBJIG9mIGk5 MTVfZ2VtX3JlcXVlc3RfYWxsb2MoKQo+IHRvIHJldHVybiBhIHBvaW50ZXIgZGlyZWN0bHksIHJh dGhlciB0aGFuIHZpYSBhbiBvdXRwdXQgcGFyYW1ldGVyLgo+IFdoaWNoIGV2ZXJ5b25lIGFncmVl cyBpcyBhIGdvb2QgaWRlYSA6KQo+IAo+IEFsbG93aW5nIE5VTEwgaGVyZSB3YXMgYSB1c2VmdWwg c3RlcCBpbiB0aGUgZWxpbWluYXRpb24gb2YgdGhlCj4gcGVyLXJpbmcgZGVmYXVsdCBjb250ZXh0 ICh3aGljaCB3YXMgYWZ0ZXIgYWxsIHlvdXIgaWRlYSwgSUlSQykuIE5vdwo+IHRoYXQgdGhlcmUg YXJlbid0IHNvIG1hbnkgY2FsbHNpdGVzIGl0J3Mgbm90IHNvIHVnbHkgdG8gaGF2ZSB0aG9zZQo+ IGNhbGxlcnMgbWVudGlvbiB0aGUgKG5vdy11bmlmaWVkKSBrZXJuZWwgY29udGV4dC4KCkknbSBy ZWZlcnJpbmcgdG8gdGhlIGNoYW5nZSB0aGF0IHRvb2sgaXQgZnJvbSB0aGUgQVBJIGhlcmUgdG8g d2hhdCB3YXMKbWVyZ2VkLCBhbmQgc28gcmV2ZXJ0aW5nIGJhY2sgdG8gd2hhdCBJIG9yaWdpbmFs bHkgd3JvdGUuCi1DaHJpcwoKLS0gCkNocmlzIFdpbHNvbiwgSW50ZWwgT3BlbiBTb3VyY2UgVGVj aG5vbG9neSBDZW50cmUKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwt Z2Z4Cg==