All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Oleg Drokin <oleg.drokin@intel.com>
Cc: linux-fsdevel@vger.kernel.org
Subject: insanity in ll_dirty_page_discard_warn()
Date: Thu, 28 Jul 2016 19:26:59 +0100	[thread overview]
Message-ID: <20160728182659.GV2356@ZenIV.linux.org.uk> (raw)

        /* this can be called inside spin lock so use GFP_ATOMIC. */
        buf = (char *)__get_free_page(GFP_ATOMIC);
        if (buf) {
                dentry = d_find_alias(page->mapping->host);
	...
	if (dentry)
		dput(dentry);

If it *can* be called under a spinlock, you have an obvious problem -
dput() can sleep.  d_find_alias() might've picked a hashed dentry with
zero refcount that got unhashed by the time of dput().  Or other references
used to exist, but got dropped by that point...

             reply	other threads:[~2016-07-28 18:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-28 18:26 Al Viro [this message]
2016-07-28 19:25 ` insanity in ll_dirty_page_discard_warn() Oleg Drokin
2016-07-28 19:25   ` [lustre-devel] " Oleg Drokin
2016-07-29 17:22   ` Ben Evans
2016-07-29 17:22     ` Ben Evans
2016-08-01  7:54     ` DEGREMONT Aurelien
2016-08-01 13:14       ` Ben Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160728182659.GV2356@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=oleg.drokin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.