From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751890AbcG1XRU (ORCPT ); Thu, 28 Jul 2016 19:17:20 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:34269 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751147AbcG1XRS (ORCPT ); Thu, 28 Jul 2016 19:17:18 -0400 Date: Thu, 28 Jul 2016 17:17:06 -0600 From: Jason Gunthorpe To: Dmitry Torokhov Cc: Andrey Pronin , Jarkko Sakkinen , Peter Huewe , Marcel Selhorst , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Christophe Ricard , smbarber@chromium.org, dianders@chromium.org Subject: Re: [PATCH v3 2/2] tpm: add driver for cr50 on SPI Message-ID: <20160728231706.GA22087@obsidianresearch.com> References: <1468549218-19215-1-git-send-email-apronin@chromium.org> <1469679917-120240-3-git-send-email-apronin@chromium.org> <20160728230141.GC28623@dtor-ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160728230141.GC28623@dtor-ws> User-Agent: Mutt/1.5.23 (2014-03-12) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.151 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 28, 2016 at 04:01:41PM -0700, Dmitry Torokhov wrote: > > + u8 tx_buf[MAX_SPI_FRAMESIZE]; > > + u8 rx_buf[MAX_SPI_FRAMESIZE]; > > Both of these need to be annotated as "____cacheline_aligned" since we > eye them for use in DMA transfers. Huh. That sure looks true to me.. We make that same mistake in all other tpm SPI drivers. Can someone send a patch please? Thanks, Jason From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH v3 2/2] tpm: add driver for cr50 on SPI Date: Thu, 28 Jul 2016 17:17:06 -0600 Message-ID: <20160728231706.GA22087@obsidianresearch.com> References: <1468549218-19215-1-git-send-email-apronin@chromium.org> <1469679917-120240-3-git-send-email-apronin@chromium.org> <20160728230141.GC28623@dtor-ws> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20160728230141.GC28623@dtor-ws> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Dmitry Torokhov Cc: Christophe Ricard , dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, smbarber-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Thu, Jul 28, 2016 at 04:01:41PM -0700, Dmitry Torokhov wrote: > > + u8 tx_buf[MAX_SPI_FRAMESIZE]; > > + u8 rx_buf[MAX_SPI_FRAMESIZE]; > > Both of these need to be annotated as "____cacheline_aligned" since we > eye them for use in DMA transfers. Huh. That sure looks true to me.. We make that same mistake in all other tpm SPI drivers. Can someone send a patch please? Thanks, Jason ------------------------------------------------------------------------------