From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754976AbcHAT7d (ORCPT ); Mon, 1 Aug 2016 15:59:33 -0400 Received: from mail-db5eur01on0115.outbound.protection.outlook.com ([104.47.2.115]:32255 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754887AbcHAT70 (ORCPT ); Mon, 1 Aug 2016 15:59:26 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=VDavydov@virtuozzo.com; Date: Mon, 1 Aug 2016 16:21:45 +0300 From: Vladimir Davydov To: Michal Hocko CC: Andrew Morton , Mel Gorman , Hillf Danton , Johannes Weiner , Vlastimil Babka , Joonsoo Kim , Minchan Kim , "Rik van Riel" , , Subject: Re: [PATCH] mm: vmscan: fix memcg-aware shrinkers not called on global reclaim Message-ID: <20160801132145.GA19395@esperanza> References: <1470056590-7177-1-git-send-email-vdavydov@virtuozzo.com> <20160801131840.GE13544@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160801131840.GE13544@dhcp22.suse.cz> X-Originating-IP: [195.214.232.10] X-ClientProxiedBy: AM4PR01CA0016.eurprd01.prod.exchangelabs.com (10.164.74.154) To AM5PR0801MB1860.eurprd08.prod.outlook.com (10.168.157.17) X-MS-Office365-Filtering-Correlation-Id: 3569b7e3-294a-4e07-79c1-08d3ba0ecc1a X-Microsoft-Exchange-Diagnostics: 1;AM5PR0801MB1860;2:4MmI0wLubrYeL7b/NLpP19cdcrQ9Oo6hDpwjm+jJi+tKaMAo3Qgr5oaNb6qwDt6/xGyn7yeB43NMxAtQvEqfrtUgA75JvyqEz641kevK73m522wsPQkj4WnS6c5Bc+C4qfYlpjNA7Eo0KxhEQDcTa8gVV2tk2ua1LaWd19iQequciz4Fp4NTGexFRB5xEeH7;3:t9pGnPy5Qd0INT36wYtFn+8LgPqhNZc5u4aLlLAgI0M7vVYB7Bqf2QO04kk/qd0+SQRqKkANo1mQNn0wDzWnym7mCXK8zi0HOGkEmLw+3kBKv2AgoFyuU0rK3CPCmSnT X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM5PR0801MB1860; X-Microsoft-Exchange-Diagnostics: 1;AM5PR0801MB1860;25:PS4om35VX+CCqbt1sB4BmFb4qQMDbnY1YawkQ/9gjtEyBQuI2sRFPO2QxgfxkTCrssi2nOaNjo9G8PVRY8rLaySkgkga2WzybUnp25qonjULASJ5TkOiB+h08sKex9kj1teIR0TyTsEgI+cb1NNvlu/mbFRcIweEiGwUHQ21VrsfE7GmU7zY/1NwN3Ko+57jrrEXWZNt1FlD7JrJbCsIgrkGE5o3B2gKWa2oyjmCN1ZA6gM83U8nlantWneIiUUKB5rR2q5vAdpO/AaIscg3e1NZFt572DGsGUsIr+7kgbG8l1Q1JAQjJzKwLUURXDYujNeV7N7e+nKpGx1ugVi+djNqWSf1oGbC1bcYj3PVi51tfMo06exIuyb9913ugayhZOD2cHHVex21mbxPjhV/EHPfHzI741jYajMbGBrl0sq8tblZj0msddTQk6YbARr4PeI2WbpRIYlDkJABlN3kwNTZOSd0lRGXxL/5VtwwRAezN33AwYGq2W0kb4HIioIVxb7Id0RnlIiUhRez3Jkdo/x5thGH34piWYNGRMaW+qnSCBERAEUunO5Eqw1eeu3uJoed09YvZTyrCS1VmUiYLr1/p/X1DDDFrsKWQxnl4Z9RE4tW0+m6mreo1BEIdWVgEfT/te7njwbv0dCl0rAElZNNqoGBCgUNXjO9SIhZfd/Hhk/B064B59K3lsh+VJuUY/zEKGCUXL4zxirdJaeNAw==;31:Hju99lh/C8M82Za6siKIXMkYJndPyd76+q56qbAbH1enoT1AbekFditZ5sjCmQuJ7rpbk2+fwscWA2F8Q5Bcg93mSFCVXFW7p3cTpH5zOwnXXVH4UeYmfepjm3elz57M3hC7iyW7WkNCERMYna/iqAtqYzTqKxQblfSPpT3+RvstFloBeNgLZf1DZR4PL5iPQQ6ugdlEXnub9PumnaEJ/Qmdg/7AFzInoiWmz3HHmWM= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040130)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6041072)(6043046);SRVR:AM5PR0801MB1860;BCL:0;PCL:0;RULEID:;SRVR:AM5PR0801MB1860; X-Microsoft-Exchange-Diagnostics: 1;AM5PR0801MB1860;4:KEoJ6hHEjFQE9L9vlMHhz605PYlUXNwAJ9J9SehkMEuSY28SM8TDB+FYhUYzjAV4IxBSbNyuUQ68KSInNVnQfZbcy8a6gPjDpb9jKfx3uX8+pCPus90OeJ4uB/fBvfD2m2g4cRq2TN5Y2GnIjEKJl1/pIpWDjvpkm6uGOW8MfaD6BOzaeKeqUktSi/xUTzS2/EvRhQ9dcZGvEF2uFZmGp66dgWcVcf1szcwxEfJu2sAoznjUtxBIMXaV/1Jd58lw3iRVn8G+i3IiPvIKgQItUnN336kWw2rL7XCmgVMM7lAD0qwxNO7tUKdyXQMz8rHpNhfn5g8VnhaTa33rioS8EPLS1p8F9ZbRInUE3K6hNrrd8eSMdYAwyI/IwLs6QRw9Uj8IBoxMAm68NE6pNvQ/mr5mceYq/YyM+Zk2GJJvles= X-Forefront-PRVS: 0021920B5A X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(7916002)(377424004)(189002)(199003)(24454002)(105586002)(101416001)(47776003)(8676002)(92566002)(106356001)(86362001)(33716001)(4326007)(42186005)(2906002)(305945005)(19580395003)(19580405001)(3846002)(586003)(33656002)(7416002)(23726003)(97736004)(46406003)(7736002)(6116002)(2950100001)(9686002)(1076002)(77096005)(110136002)(50466002)(189998001)(80792005)(7846002)(81166006)(54356999)(81156014)(97756001)(76176999)(66066001)(50986999)(68736007);DIR:OUT;SFP:1102;SCL:1;SRVR:AM5PR0801MB1860;H:esperanza;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;AM5PR0801MB1860;23:Vhdq09uSqRNTDiE3ofKQphvk0XZfMJtLRCpPYcW?= =?us-ascii?Q?odYrKYpz2hzq/vU+8AP34pQv14hPoqpppTODIY1RXMWbxvQksTCoKaC24+KR?= =?us-ascii?Q?R+aisxhiipLeeaT+r7kTHJ9w8fVVFw4QIAMMBdN9L1g6/3VkbHyK8QMW5Li9?= =?us-ascii?Q?v4Xa4ABf7Qt2286rI5/UiU8iVXeiYtSPGjVekQRPYcMrMLcwGvKVwUHIdGVS?= =?us-ascii?Q?hP7K+ePcQcro5e+F2lLwEjFkatnuWsCYy8VrdfheB3dxqQlSGyBOtGEjzX4o?= =?us-ascii?Q?n7yEJfvfFrZAIV5eFxNlQMPvQ2Nt0rJodgPTt9QAzTLPAimwxQWg/LccJCIu?= =?us-ascii?Q?vPu+WUsuzdniHlkEhATSV0zsP/GPCX+YZRP7SjrTvzNS5oJzCDagIlgSFMBZ?= =?us-ascii?Q?cZ0Lf2VM/+p4qiVu/sO18Axli/xpMJqnoyofddBJ3I3TrkFHqQql3uiKMf77?= =?us-ascii?Q?zupKyPRdbt5CCgEffiIxeOMhfWUsmT0pc9gKjQHqQNVnLvzoCttaEp3A7KzJ?= =?us-ascii?Q?uS/v1q8nL/Sh+AkVbPzWdjQkmEtyizVHr0ySOyFg5gr1f0FVP8PcwFDR1Vtd?= =?us-ascii?Q?prnm2R2n8ef2pLKBENLieZMcb8+eqg5vcK4L24VwKb3Yx5MHS8VpF/b0p5v4?= =?us-ascii?Q?FvECfvBDRgT+95NL7PLXlt84KAVB04ghQdp4PigyVGlxFbfgSZwQfV4ub2V8?= =?us-ascii?Q?k26zhmoTB/NzaVmMWftxFgrpHEw7HEKBEZbBPL68OiQpWm/lLI+VcDAUH+p/?= =?us-ascii?Q?t3khVdBnyOyXhvp4yDH77/BDtiFwghzhPTw1BqdAf6FzcC/HieW+YK+jEe+z?= =?us-ascii?Q?UyxbJozuRq8c2CLEmo85ZncmQkalGFuPu6jLJk8h9rqW35ITuCpI4LplQQsO?= =?us-ascii?Q?AxVaWOkVX6x06aYcM6E1heIyc0sWDKooYE4Sr1RLqVEGsZxRl7AMi6xfooGm?= =?us-ascii?Q?uJSym9Xgi0pZ2ioM8/+6G+Ld39B9qmqHKyk1az4hpeYPR3ruaalrFHhhVatW?= =?us-ascii?Q?XmkrtI/8TALKntLR9DN1HD2I1/5uXYVB9/bpCqNqTky+YXW0DTDkEpuwcQhS?= =?us-ascii?Q?Exhn+C/khckf73ykc7DP8d7PokvhVwsjHBjcXYqVJPrdeoRdclabOijRNGOn?= =?us-ascii?Q?trOKmV1pvG6iGlE/SaMiSL+148atT/MYsAB5rUylRuLQeHQ5NrqEiyw=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;AM5PR0801MB1860;6:K4otSFJ7dZV1tUun8sKonRwqr/SBibDmZyo/cAgZLz3XNEY3urPu0FaXlkHChNT1+nD3qF4ykVf3coSbJ1dadI7M1mZTZxKiKbtMFVI4bT4ZCydxKhDu+ggl3kR6ZsYJpAwIW46xYCfov/6NfyqLBlilh0HaV7CtZ2UqddoxoikbrgQDZiOmVDQ9AJwp1ryqwU4h11fPo6jfIx4JSzvO/t64cUVFwLTRkDE9hyhXz6nxTHnQBh5xDtcRw+VujPM4SCmNnBsdRBaQ8DL6czcxX9HwSotTLJNKZoqwUI4abapi8K/rJJqwqDRN6oQxW4pg;5:1mUHtgCJ11r8MKXKaNQ0qlwUXqwB4nWHqUqHOwdyEcAAr92Z06lrbvbgS1l26hy6Ptn7iAclRhwVyUWZW+JkZkRDylVCYyGOkt5mW9P6zh1jWG37xs51fFGmxronBaGppbejl/hSc9P5+zyHmTvGcg==;24:uwh10N8Fnvlli+UsadqvWFSCmUWmIFplDxoF5KJJjekQyw68YKfW/1KhYC8oB5WZRMqqtxgPVHrwGIJEiARCp4FquYWj3wUiHG6J3DaNPXM=;7:6GgHAE3TzbdZ7SNqIMirPZ5cMke6AZnz+FtISlnBk8lNiB5bzOZ/C2T38tyv0ElVL14zc+XZ5YPMbgeaZKzMpS9hlqKM0bTb0tl3E8dbc0k3c9aXEGvdsdC8QjU/LZhp83AKk7twIetrnW0qlZDYkgxGeAICfqIYr3ZpuKKkujJ+Liwb7bx5i61cC63KNF5XspuiMcidZ+/R3hqiawRfKMutCzbnZ3tJu0uG1IZ/J6QyhEvwTIoe8NSaH1O3gouD SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;AM5PR0801MB1860;20:9ucw1tiem6KjBafByEcuY+yCVDXr/+Ca0Z7QbAU4DcVBhwbS3+oj+dFYEDtYF8JRMl3fO76aad164gRHvQozt1mLy6TTSoVUWxsu/3iJ0WlERNILefjBswe0xpZCXfZzsuEm5BevLkybIvrgm9S3oO3DaM4vuWFFuFQpVmsccQI= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2016 13:21:49.9452 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1860 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 01, 2016 at 03:18:40PM +0200, Michal Hocko wrote: > On Mon 01-08-16 16:03:10, Vladimir Davydov wrote: > > We must call shrink_slab() for each memory cgroup on both global and > > memcg reclaim in shrink_node_memcg(). Commit d71df22b55099 accidentally > > changed that so that now shrink_slab() is only called with memcg != NULL > > on memcg reclaim. As a result, memcg-aware shrinkers (including > > dentry/inode) are never invoked on global reclaim. Fix that. > > > > Fixes: d71df22b55099 ("mm, vmscan: begin reclaiming pages on a per-node basis") > > I guess you meant b2e18757f2c9. I do not see d71df22b55099 anywhere. I'm basing on top of v4.7-mmotm-2016-07-28-16-33 and there it's d71df22b55099. > > > Signed-off-by: Vladimir Davydov > > The fix looks ok to me otherwise > > Acked-by: Michal Hocko Thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-f70.google.com (mail-it0-f70.google.com [209.85.214.70]) by kanga.kvack.org (Postfix) with ESMTP id 5093E6B0260 for ; Mon, 1 Aug 2016 09:21:54 -0400 (EDT) Received: by mail-it0-f70.google.com with SMTP id d65so10456620ith.0 for ; Mon, 01 Aug 2016 06:21:54 -0700 (PDT) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00103.outbound.protection.outlook.com. [40.107.0.103]) by mx.google.com with ESMTPS id r10si19328303oih.174.2016.08.01.06.21.53 for (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 01 Aug 2016 06:21:53 -0700 (PDT) Date: Mon, 1 Aug 2016 16:21:45 +0300 From: Vladimir Davydov Subject: Re: [PATCH] mm: vmscan: fix memcg-aware shrinkers not called on global reclaim Message-ID: <20160801132145.GA19395@esperanza> References: <1470056590-7177-1-git-send-email-vdavydov@virtuozzo.com> <20160801131840.GE13544@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160801131840.GE13544@dhcp22.suse.cz> Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: Andrew Morton , Mel Gorman , Hillf Danton , Johannes Weiner , Vlastimil Babka , Joonsoo Kim , Minchan Kim , Rik van Riel , linux-mm@kvack.org, linux-kernel@vger.kernel.org On Mon, Aug 01, 2016 at 03:18:40PM +0200, Michal Hocko wrote: > On Mon 01-08-16 16:03:10, Vladimir Davydov wrote: > > We must call shrink_slab() for each memory cgroup on both global and > > memcg reclaim in shrink_node_memcg(). Commit d71df22b55099 accidentally > > changed that so that now shrink_slab() is only called with memcg != NULL > > on memcg reclaim. As a result, memcg-aware shrinkers (including > > dentry/inode) are never invoked on global reclaim. Fix that. > > > > Fixes: d71df22b55099 ("mm, vmscan: begin reclaiming pages on a per-node basis") > > I guess you meant b2e18757f2c9. I do not see d71df22b55099 anywhere. I'm basing on top of v4.7-mmotm-2016-07-28-16-33 and there it's d71df22b55099. > > > Signed-off-by: Vladimir Davydov > > The fix looks ok to me otherwise > > Acked-by: Michal Hocko Thanks! -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org