From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757375AbcHCBNo (ORCPT ); Tue, 2 Aug 2016 21:13:44 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:57838 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757316AbcHCBN0 (ORCPT ); Tue, 2 Aug 2016 21:13:26 -0400 Date: Tue, 02 Aug 2016 18:04:31 -0700 (PDT) Message-Id: <20160802.180431.1364387950717991600.davem@davemloft.net> To: lorenzo@google.com Cc: john.stultz@linaro.org, dsa@cumulusnetworks.com, mateusz.bajorski@nokia.com, linux-kernel@vger.kernel.org, guodong.xu@linaro.org, dimitrysh@google.com, chh@google.com, ejcaruso@google.com, romlem@google.com Subject: Re: [Regression?] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule breaks Android userspace From: David Miller In-Reply-To: References: <20160802.110017.807651313555771477.davem@davemloft.net> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 02 Aug 2016 18:04:32 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lorenzo Colitti Date: Wed, 3 Aug 2016 09:58:09 +0900 > The problem is that the UID routing patches were never accepted > upstream, and because FRA_xxx and RTA_xxx are enums, there's no safe > way to add a new value out of tree like there would be with other > identifiers such as setsockopt values. > > I'm going to make another attempt to upstream the UID routing code > soon. If that doesn't make it, then we could attempt to reserve a > couple RTA_xxx and FRA_xxx values for local use. If upstream rejects the feature, it's because you'll be given a suggested alternative implementation in order to achieve your goals. In that respect, it is inappropriate to expect that we will "reserve" netlink ID space for such a feature that is rejected in that manner upstream.