From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 13/73] drm/i915: Move the modulus for ring emission to the register write Date: Tue, 2 Aug 2016 11:14:42 +0100 Message-ID: <20160802101442.GF1585@nuc-i3427.alporthouse.com> References: <1470042681-25318-1-git-send-email-chris@chris-wilson.co.uk> <1470042681-25318-14-git-send-email-chris@chris-wilson.co.uk> <1470046075.4174.5.camel@linux.intel.com> <20160801101516.GC4252@nuc-i3427.alporthouse.com> <1470061714.4174.23.camel@linux.intel.com> <20160801163225.GD5384@nuc-i3427.alporthouse.com> <914d9ecb-f7e0-10af-4f92-c9105cd0f310@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id 208776E438 for ; Tue, 2 Aug 2016 10:14:49 +0000 (UTC) Content-Disposition: inline In-Reply-To: <914d9ecb-f7e0-10af-4f92-c9105cd0f310@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dave Gordon Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBBdWcgMDIsIDIwMTYgYXQgMTA6NDI6NDdBTSArMDEwMCwgRGF2ZSBHb3Jkb24gd3Jv dGU6Cj4gT24gMDEvMDgvMTYgMTc6MzIsIENocmlzIFdpbHNvbiB3cm90ZToKPiA+T24gTW9uLCBB dWcgMDEsIDIwMTYgYXQgMDU6Mjg6MzRQTSArMDMwMCwgSm9vbmFzIExhaHRpbmVuIHdyb3RlOgo+ ID4+T24gbWEsIDIwMTYtMDgtMDEgYXQgMTE6MTUgKzAxMDAsIENocmlzIFdpbHNvbiB3cm90ZToK PiA+Pj5PbiBNb24sIEF1ZyAwMSwgMjAxNiBhdCAwMTowNzo1NVBNICswMzAwLCBKb29uYXMgTGFo dGluZW4gd3JvdGU6Cj4gPj4+Pgo+ID4+Pj5PbiBtYSwgMjAxNi0wOC0wMSBhdCAxMDoxMCArMDEw MCwgQ2hyaXMgV2lsc29uIHdyb3RlOgo+ID4+Pj4+Cj4gPj4+Pj5TcGFjZSByZXNlcnZhdGlvbiBp cyBhbHJlYWR5IHNhZmUgd2l0aCByZXNwZWN0IHRvIHRoZSByaW5nLT5zaXplCj4gPj4+Pj5tb2R1 bHVzLCBidXQgaGFyZHdhcmUgb25seSBleHBlY3RzIHRvIHNlZSB2YWx1ZXMgaW4gdGhlIHJhbmdl Cj4gPj4+Pj4wLi4ucmluZy0+c2l6ZS0xIChpbmNsdXNpdmUpIGFuZCBzbyByZXF1aXJlcyB0aGUg bW9kdWx1cyB0byBwcmV2ZW50IHVzCj4gPj4+Pj53cml0aW5nIHRoZSB2YWx1ZSByaW5nLT5zaXpl IGluc3RlYWQgb2YgMC4gQXMgdGhpcyBpcyBvbmx5IHJlcXVpcmVkIGZvcgo+ID4+Pj4+dGhlIHJl Z2lzdGVyIGl0c2VsZiwgd2UgY2FuIGRlZmVyIHRoZSBtb2R1bHVzIHRvIHRoZSByZWdpc3RlciB1 cGRhdGUgYW5kCj4gPj4+Pj5ub3QgcGVyZm9ybSBpdCBhZnRlciBldmVyeSBjb21tYW5kIHBhY2tl dC4gV2Uga2VlcCB0aGUKPiA+Pj4+PmludGVsX3JpbmdfYWR2YW5jZSgpIGFyb3VuZCBpbiB0aGUg Y29kZSB0byBwcm92aWRlIGRlbWFyY2F0aW9uIGZvciB0aGUKPiA+Pj4+PmVuZC1vZi1wYWNrZXQg KHdoaWNoIHRoZW4gY2FuIGJlIGNvbXBhcmVkIGFnYWluc3QgaW50ZWxfcmluZ19iZWdpbigpIGFz Cj4gPj4+Pj50aGUgbnVtYmVyIG9mIGR3b3JkcyBlbWl0dGVkIG11c3QgbWF0Y2ggdGhlIHJlc2Vy dmVkIHNwYWNlKS4KPiA+Pj4+Pgo+ID4+Pj4+U2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxj aHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gPj4+Pj5DYzogSm9vbmFzIExhaHRpbmVuIDxqb29u YXMubGFodGluZW5AbGludXguaW50ZWwuY29tPgo+ID4+Pj4+Q2M6IERhdmUgR29yZG9uIDxkYXZp ZC5zLmdvcmRvbkBpbnRlbC5jb20+Cj4gPj4+Pj4tLS0KPiA+Pj4+PiBkcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9scmMuYyAgICAgICAgfCAgMiArLQo+ID4+Pj4+IGRyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX3JpbmdidWZmZXIuYyB8ICA2ICsrKystLQo+ID4+Pj4+IGRyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX3JpbmdidWZmZXIuaCB8IDE3ICsrKysrKysrKysrKystLS0tCj4gPj4+Pj4g MyBmaWxlcyBjaGFuZ2VkLCAxOCBpbnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQo+ID4+Pj4+ Cj4gPj4+Pj5kaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+ID4+Pj4+aW5kZXggYmY0MmE2NmQ2NjI0 Li44MjRmN2VmZTRlNjQgMTAwNjQ0Cj4gPj4+Pj4tLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9scmMuYwo+ID4+Pj4+KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMK PiA+Pj4+PkBAIC0zNzMsNyArMzczLDcgQEAgc3RhdGljIHZvaWQgZXhlY2xpc3RzX3VwZGF0ZV9j b250ZXh0KHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcnEpCj4gPj4+Pj4gCXN0cnVjdCBp OTE1X2h3X3BwZ3R0ICpwcGd0dCA9IHJxLT5jdHgtPnBwZ3R0Owo+ID4+Pj4+IAl1aW50MzJfdCAq cmVnX3N0YXRlID0gcnEtPmN0eC0+ZW5naW5lW2VuZ2luZS0+aWRdLmxyY19yZWdfc3RhdGU7Cj4g Pj4+Pj4KPiA+Pj4+Pi0JcmVnX3N0YXRlW0NUWF9SSU5HX1RBSUwrMV0gPSBycS0+dGFpbDsKPiA+ Pj4+PisJcmVnX3N0YXRlW0NUWF9SSU5HX1RBSUwrMV0gPSBpbnRlbF9yaW5nX29mZnNldChycS0+ cmluZywgcnEtPnRhaWwpOwo+ID4+Pj4+Cj4gPj4+Pj4gCS8qIFRydWUgMzJiIFBQR1RUIHdpdGgg ZHluYW1pYyBwYWdlIGFsbG9jYXRpb246IHVwZGF0ZSBQRFAKPiA+Pj4+PiAJICogcmVnaXN0ZXJz IGFuZCBwb2ludCB0aGUgdW5hbGxvY2F0ZWQgUERQcyB0byBzY3JhdGNoIHBhZ2UuCj4gPj4+Pj5k aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5jIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5jCj4gPj4+Pj5pbmRleCAzMTQyMDg1 YjVjYzAuLjIxZDVlODIwOTQwMCAxMDA2NDQKPiA+Pj4+Pi0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX3JpbmdidWZmZXIuYwo+ID4+Pj4+KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfcmluZ2J1ZmZlci5jCj4gPj4+Pj5AQCAtMTcxOCw3ICsxNzE4LDggQEAgc3RhdGljIHZv aWQgaTl4eF9zdWJtaXRfcmVxdWVzdChzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcXVl c3QpCj4gPj4+Pj4gewo+ID4+Pj4+IAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYg PSByZXF1ZXN0LT5pOTE1Owo+ID4+Pj4+Cj4gPj4+Pj4tCUk5MTVfV1JJVEVfVEFJTChyZXF1ZXN0 LT5lbmdpbmUsIHJlcXVlc3QtPnRhaWwpOwo+ID4+Pj4+KwlJOTE1X1dSSVRFX1RBSUwocmVxdWVz dC0+ZW5naW5lLAo+ID4+Pj4+KwkJCWludGVsX3Jpbmdfb2Zmc2V0KHJlcXVlc3QtPnJpbmcsIHJl cXVlc3QtPnRhaWwpKTsKPiA+Pj4+PiB9Cj4gPj4+Pj4KPiA+Pj4+PiBzdGF0aWMgdm9pZAo+ID4+ Pj4+QEAgLTI1MDUsNyArMjUwNiw4IEBAIHN0YXRpYyB2b2lkIGdlbjZfYnNkX3N1Ym1pdF9yZXF1 ZXN0KHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxdWVzdCkKPiA+Pj4+PiAJCURSTV9F UlJPUigidGltZWQgb3V0IHdhaXRpbmcgZm9yIHRoZSBCU0QgcmluZyB0byB3YWtlIHVwXG4iKTsK PiA+Pj4+Pgo+ID4+Pj4+IAkvKiBOb3cgdGhhdCB0aGUgcmluZyBpcyBmdWxseSBwb3dlcmVkIHVw LCB1cGRhdGUgdGhlIHRhaWwgKi8KPiA+Pj4+Pi0JSTkxNV9XUklURV9GVyhSSU5HX1RBSUwocmVx dWVzdC0+ZW5naW5lLT5tbWlvX2Jhc2UpLCByZXF1ZXN0LT50YWlsKTsKPiA+Pj4+PisJSTkxNV9X UklURV9GVyhSSU5HX1RBSUwocmVxdWVzdC0+ZW5naW5lLT5tbWlvX2Jhc2UpLAo+ID4+Pj4+KwkJ ICAgICAgaW50ZWxfcmluZ19vZmZzZXQocmVxdWVzdC0+cmluZywgcmVxdWVzdC0+dGFpbCkpOwo+ ID4+Pj4+IAlQT1NUSU5HX1JFQURfRlcoUklOR19UQUlMKHJlcXVlc3QtPmVuZ2luZS0+bW1pb19i YXNlKSk7Cj4gPj4+Pj4KPiA+Pj4+PiAJLyogTGV0IHRoZSByaW5nIHNlbmQgSURMRSBtZXNzYWdl cyB0byB0aGUgR1QgYWdhaW4sCj4gPj4+Pj5kaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfcmluZ2J1ZmZlci5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1 ZmZlci5oCj4gPj4+Pj5pbmRleCAxNGQyZWEzNmZiODguLjlhYzk2ZGRiMDFlZSAxMDA2NDQKPiA+ Pj4+Pi0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuaAo+ID4+Pj4+ KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5oCj4gPj4+Pj5AQCAt NDYwLDE0ICs0NjAsMjMgQEAgc3RhdGljIGlubGluZSB2b2lkIGludGVsX3JpbmdfZW1pdF9yZWco c3RydWN0IGludGVsX3JpbmcgKnJpbmcsIGk5MTVfcmVnX3QgcmVnKQo+ID4+Pj4+Cj4gPj4+Pj4g c3RhdGljIGlubGluZSB2b2lkIGludGVsX3JpbmdfYWR2YW5jZShzdHJ1Y3QgaW50ZWxfcmluZyAq cmluZykKPiA+Pj4+PiB7Cj4gPj4+Pj4rCS8qIER1bW15IGZ1bmN0aW9uLgo+ID4+Pj4+KwkgKgo+ ID4+Pj4+KwkgKiBUaGlzIHNlcnZlcyBhcyBhIHBsYWNlaG9sZGVyIGluIHRoZSBjb2RlIHNvIHRo YXQgdGhlIHJlYWRlcgo+ID4+Pj4+KwkgKiBjYW4gY29tcGFyZSBhZ2FpbnN0IHRoZSBwcmVjZWRp bmcgaW50ZWxfcmluZ19iZWdpbigpIGFuZAo+ID4+Pj4+KwkgKiBjaGVjayB0aGF0IHRoZSBudW1i ZXIgb2YgZHdvcmRzIGVtaXR0ZWQgbWF0Y2hlcyB0aGUgc3BhY2UKPiA+Pj4+PisJICogcmVzZXJ2 ZWQgZm9yIHRoZSBjb21tYW5kIHBhY2tldCAoaS5lLiB0aGUgdmFsdWUgcGFzc2VkIHRvCj4gPj4+ Pj4rCSAqIGludGVsX3JpbmdfYmVnaW4oKSkuCj4gPj4+Pj4rCSAqLwo+ID4+Pj4+K30KPiA+Pj4+ PisKPiA+Pj4+PitzdGF0aWMgaW5saW5lIHUzMiBpbnRlbF9yaW5nX29mZnNldChzdHJ1Y3QgaW50 ZWxfcmluZyAqcmluZywgdTMyIHZhbHVlKQo+ID4+Pj4+K3sKPiA+Pj4+PiAJLyogVGhlIG1vZHVs dXMgaXMgcmVxdWlyZWQgc28gdGhhdCB3ZSBhdm9pZCB3cml0aW5nCj4gPj4+Pj4gCSAqIHJlcXVl c3QtPnRhaWwgPT0gcmluZy0+c2l6ZSwgcmF0aGVyIHRoYW4gdGhlIGV4cGVjdGVkIDAsCj4gPj4+ Pj4gCSAqIGludG8gdGhlIFJJTkdfVEFJTCByZWdpc3RlciBhcyB0aGF0IGNhbiBjYXVzZSBhIEdQ VSBoYW5nLgo+ID4+Pj4+LQkgKiBBcyB0aGlzIGlzIG9ubHkgc3RyaWN0bHkgcmVxdWlyZWQgZm9y IHRoZSByZXF1ZXN0LT50YWlsLAo+ID4+Pj4+LQkgKiBhbmQgb25seSB0aGVuIGFzIHdlIHdyaXRl IHRoZSB2YWx1ZSBpbnRvIGhhcmR3YXJlLCB3ZSBjYW4KPiA+Pj4+Pi0JICogb25lIGRheSByZW1v dmUgdGhlIG1vZHVsdXMgYWZ0ZXIgZXZlcnkgY29tbWFuZCBwYWNrZXQuCj4gPj4+Pj4gCSAqLwo+ ID4+Pj4+LQlyaW5nLT50YWlsICY9IHJpbmctPnNpemUgLSAxOwo+ID4+Pj4+KwlyZXR1cm4gdmFs dWUgJiAocmluZy0+c2l6ZSAtIDEpOwo+ID4+Pj4+IH0KPiA+Pj4+VGhlIGNvbW1lbnQgc2VlbXMg b3V0ZGF0ZWQtaXNoIGFzIGl0IHNwZWFrcyBvZiBtb2R1bHVzIHdoaWNoIGlzIG5vd2hlcmUKPiA+ Pj4+dG8gYmUgc2Vlbi4gSSdkIHNwZWFrIG9mICdtYXNraW5nJy4gV2l0aCB0aGF0LAo+ID4+PlRo ZSBvcGVyYXRpb24gaXMgYSBtb2R1bHVzLiBUaGUgY29tbW9uIG9wdGltaXNhdGlvbiBmb3IgbW9k dWxpIHdpdGgKPiA+Pj5hIHBvd2VyLW9mLXR3byBkaXZpc29yIGJlaW5nIGFwcGxpZWQuCj4gPj4K PiA+PlllcywgSSdtIHBlcmZlY3RseSBhd2FyZSBvZiB0aGF0LCBidXQgYXMgZGlzY3Vzc2VkIGlu IElSQywgdGhhdAo+ID4+aW5mb3JtYXRpb24gd291bGQgYmUgZ29vZCB0byBiZSBsb2NhbC4gTW9k dWx1cyBpbiB0aGlzIGNhc2UgYSB0cmljayB0bwo+ID4+YWNoaWV2ZSB2YWx1ZSA9PSByaW5nLT5z aXplID8gMCA6IHZhbHVlOyBXaGljaCB3b3VsZCBhZ2FpbiBiZSBtb3JlCj4gPj5pbmZvcm1hdGl2 ZSwgd2UgZG8gbm90IGV4cGVjdCB3cmFwLCBidXQgd2UgaGF2ZSBvbmUgc3BlY2lhbCB2YWx1ZS4K PiA+Cj4gPkRpdGNoIGFsbCB0aGUgdmVyYmFnZSwgYW5kIGdvIHdpdGggdGhlIHNpbmdsZSBsaW5l Ogo+ID4JLyogRG9uJ3Qgd3JpdGUgcmluZy0+c2l6ZSAoZXF1aXZhbGVudCB0byAwKSBhcyB0aGF0 IGhhbmdzIHNvbWUgR1BVcy4gKi8KPiA+dGhhdCBqdXN0IGZpdHMgaW50byA4MGNvbHMuCj4gPgo+ ID5LZWVwIGl0IHRvIHdoeSBub3QgaG93IGFuZCB3ZSBuZWVkIG5vdCBhcmd1ZSBhYm91dCBsYW5n dWFnZS4KPiA+LUNocmlzCj4gCj4gV2VsbCB5ZXMsIGV4Y2VwdCB0aGlzIGZ1bmN0aW9uIGlzbid0 IHdyaXRpbmcgYW55dGhpbmcgdG8gYW55d2hlcmUsCj4gc28gaXQgc2VlbXMgcmF0aGVyIGRpc2Nv bm5lY3RlZCBmcm9tIHRoZSBwb2ludCBvZiB1c2UuIFBlcmhhcHMKPiAKPiAvKiBlbnN1cmUgdmFs dWUgKHdyaXR0ZW4gdG8gVEFJTCkgaXMgc3RyaWN0bHkgbGVzcyB0aGFuIHJpbmctPnNpemUgKi8K PiAKPiB3aGljaCBpcyBldmVuIHNob3J0ZXIgOikKPiAKPiBCVFcsIGEgY29tcGxldGVseSBkaWZm ZXJlbnQgd2F5IHRvIGF2b2lkIHRoaXMgcHJvYmxlbSB3b3VsZCBqdXN0IGJlCj4gdG8gZW5zdXJl IHRoZSBwYWNrZXQgbmV2ZXIgZmluaXNoZWQgYXQgdGhlIGxhc3Qgd29yZCBvZiB0aGUgcmluZy4K PiBTZXR0aW5nIGVmZmVjdGl2ZV9zaXplID0gc2l6ZS0xIHdvdWxkIGRvIGp1c3QgdGhhdCEKPiAK PiBJZiB3ZSBzZXQgZWZmZWN0aXZlX3NpemUgPCBzaXplIGZvciBlbmdpbmVzIHRoYXQgZG9uJ3Qg bGlrZSBUQUlMID09Cj4gcmluZy0+c2l6ZSAoYXMgd2VsbCBhcyB0aGUgb25lcyB0aGF0IGRvbid0 IGxpa2UgdGhlIGxhc3QgY2FjaGVsaW5lKQo+IHdlIGNvdWxkIHRoZW4gcmVtb3ZlIHRoZSBkb24n dC13cmFwLW1pZHNlcXVlbmNlIHJlc3RyaWN0aW9uIGZyb20gdGhlCj4gb3RoZXJzLCB3aGljaCB3 b3VsZCBtYWtlIGJldHRlciB1c2Ugb2YgdGhlIHJpbmcgc3BhY2UgOikKCldlIGNhbid0IGp1c3Qg cmVtb3ZlIHRoYXQgYXMgd2Ugc3RpbGwgaGF2ZSB0aGUgbGltaXRhdGlvbiB0aGF0IHdlIGNhbid0 CnNwbGl0IGluc3RydWN0aW9ucywgYW5kIHRoZSBpbnRlbF9yaW5nX2JlZ2luKCkgaXMgYWxsIHRo ZSBpbmZvcm1hdGlvbiB3ZQpoYXZlIGF0IHRoYXQgcG9pbnQgcmVnYXJkaW5nIGluc3RydWN0aW9u IGxlbmd0aC4KLUNocmlzCgotLSAKQ2hyaXMgV2lsc29uLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNo bm9sb2d5IENlbnRyZQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1n ZngK