From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966625AbcHBNrL (ORCPT ); Tue, 2 Aug 2016 09:47:11 -0400 Received: from mx2.suse.de ([195.135.220.15]:58346 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965961AbcHBNAI (ORCPT ); Tue, 2 Aug 2016 09:00:08 -0400 Date: Tue, 2 Aug 2016 14:59:44 +0200 From: Petr Mladek To: Miroslav Benes Cc: Jessica Yu , Josh Poimboeuf , Jiri Kosina , Chris J Arges , Eugene Shatokhin , live-patching@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] livepatch/x86: apply alternatives and paravirt patches after relocations Message-ID: <20160802125944.GD4779@pathway.suse.cz> References: <1469078640-26798-1-git-send-email-jeyu@redhat.com> <1469078640-26798-3-git-send-email-jeyu@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 2016-08-02 10:59:07, Miroslav Benes wrote: > On Thu, 21 Jul 2016, Jessica Yu wrote: > > > Implement arch_klp_init_object_loaded() for x86, which applies > > alternatives/paravirt patches. This fixes the order in which relocations > > and alternatives/paravirt patches are applied. > > > > diff --git a/arch/x86/kernel/livepatch.c b/arch/x86/kernel/livepatch.c > > new file mode 100644 > > index 0000000..78209f1 > > --- /dev/null > > +++ b/arch/x86/kernel/livepatch.c > > +#include > > +#include > > +#include > > +#include > > It seems I don't have such header file here and it causes a build error. > Shouldn't it be ? It is in linux-next, see 35de5b0692aaa ("x86/asm: Stop depending on ptrace.h in alternative.h"). I agree with the other Mirek's comments. Otherwise, it looks good. Thanks for working on it, Petr