From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757408AbcHBSfy (ORCPT ); Tue, 2 Aug 2016 14:35:54 -0400 Received: from mga04.intel.com ([192.55.52.120]:38767 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754584AbcHBSfm (ORCPT ); Tue, 2 Aug 2016 14:35:42 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,461,1464678000"; d="scan'208";a="1033821092" Date: Tue, 2 Aug 2016 21:34:04 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Daniel Vetter Cc: Linus Torvalds , Daniel Vetter , DRI mailing list , Linux Kernel Mailing List Subject: Re: [git pull] drm for v4.8 Message-ID: <20160802183404.GD4329@intel.com> References: <20160802081042.GP4329@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 02, 2016 at 08:01:14PM +0200, Daniel Vetter wrote: > On Tue, Aug 2, 2016 at 6:40 PM, Linus Torvalds > wrote: > > On Tue, Aug 2, 2016 at 4:10 AM, Ville Syrjälä > > wrote: > >> > >> So PSR seems more likely. The underruns might point at some watermark > >> fail though :( > >> > >> I have a couple of pending PSR patches you may want to try as well, > >> if i915.enable_psr=0 helps. > >> > >> First set is here: > >> git://github.com/vsyrjala/linux.git psr_setup_time_2 > >> This should be perfectly safe to go in actually, as it will only result > >> in disabling PSR with certain panels. > > > > This first git pull fixes it for me, as far as I can tell. I'm not > > sure that the problem is 100% reproducible, but I booted into each > > kernel twice, and the current git tree is broken, while with your > > psr_setup_time_2 branch pulled it works. So it does seem to be the > > fix. > > > >> The second set is here: > >> git://github.com/vsyrjala/linux.git psr_fixes_2 > > > > I didn't even test that one. > > > > Should I just pull that psr_setup_time2 branch for real? I'd like to > > get a real pull request with explanations etc, but other than that it > > looks good to go. > > Hm, I reviewed all the patches from Ville already. I gues they were > stuck because we didn't have someone who reported that it's fixed, > plus they lacked an ack from Dave for the 2 core patches. + they were part of a series that included a rotten apple responsible for a BAT regression > tbh I'd just > apply them all to drm-intel-fixes and then send out a pull for that > (there's two more bugfix patches on it which missed Dave's main pull > by a notch). Dave/Jani? > -Daniel > -- > Daniel Vetter > Software Engineer, Intel Corporation > +41 (0) 79 365 57 48 - http://blog.ffwll.ch -- Ville Syrjälä Intel OTC From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [git pull] drm for v4.8 Date: Tue, 2 Aug 2016 21:34:04 +0300 Message-ID: <20160802183404.GD4329@intel.com> References: <20160802081042.GP4329@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 896686E644 for ; Tue, 2 Aug 2016 18:34:08 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Daniel Vetter , Linus Torvalds , Linux Kernel Mailing List , DRI mailing list List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBBdWcgMDIsIDIwMTYgYXQgMDg6MDE6MTRQTSArMDIwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBUdWUsIEF1ZyAyLCAyMDE2IGF0IDY6NDAgUE0sIExpbnVzIFRvcnZhbGRzCj4g PHRvcnZhbGRzQGxpbnV4LWZvdW5kYXRpb24ub3JnPiB3cm90ZToKPiA+IE9uIFR1ZSwgQXVnIDIs IDIwMTYgYXQgNDoxMCBBTSwgVmlsbGUgU3lyasOkbMOkCj4gPiA8dmlsbGUuc3lyamFsYUBsaW51 eC5pbnRlbC5jb20+IHdyb3RlOgo+ID4+Cj4gPj4gU28gUFNSIHNlZW1zIG1vcmUgbGlrZWx5LiBU aGUgdW5kZXJydW5zIG1pZ2h0IHBvaW50IGF0IHNvbWUgd2F0ZXJtYXJrCj4gPj4gZmFpbCB0aG91 Z2ggOigKPiA+Pgo+ID4+IEkgaGF2ZSBhIGNvdXBsZSBvZiBwZW5kaW5nIFBTUiBwYXRjaGVzIHlv dSBtYXkgd2FudCB0byB0cnkgYXMgd2VsbCwKPiA+PiBpZiBpOTE1LmVuYWJsZV9wc3I9MCBoZWxw cy4KPiA+Pgo+ID4+IEZpcnN0IHNldCBpcyBoZXJlOgo+ID4+IGdpdDovL2dpdGh1Yi5jb20vdnN5 cmphbGEvbGludXguZ2l0IHBzcl9zZXR1cF90aW1lXzIKPiA+PiBUaGlzIHNob3VsZCBiZSBwZXJm ZWN0bHkgc2FmZSB0byBnbyBpbiBhY3R1YWxseSwgYXMgaXQgd2lsbCBvbmx5IHJlc3VsdAo+ID4+ IGluIGRpc2FibGluZyBQU1Igd2l0aCBjZXJ0YWluIHBhbmVscy4KPiA+Cj4gPiBUaGlzIGZpcnN0 IGdpdCBwdWxsIGZpeGVzIGl0IGZvciBtZSwgYXMgZmFyIGFzIEkgY2FuIHRlbGwuIEknbSBub3QK PiA+IHN1cmUgdGhhdCB0aGUgcHJvYmxlbSBpcyAxMDAlIHJlcHJvZHVjaWJsZSwgYnV0IEkgYm9v dGVkIGludG8gZWFjaAo+ID4ga2VybmVsIHR3aWNlLCBhbmQgdGhlIGN1cnJlbnQgZ2l0IHRyZWUg aXMgYnJva2VuLCB3aGlsZSB3aXRoIHlvdXIKPiA+IHBzcl9zZXR1cF90aW1lXzIgYnJhbmNoIHB1 bGxlZCBpdCB3b3Jrcy4gIFNvIGl0IGRvZXMgc2VlbSB0byBiZSB0aGUKPiA+IGZpeC4KPiA+Cj4g Pj4gVGhlIHNlY29uZCBzZXQgaXMgaGVyZToKPiA+PiBnaXQ6Ly9naXRodWIuY29tL3ZzeXJqYWxh L2xpbnV4LmdpdCBwc3JfZml4ZXNfMgo+ID4KPiA+IEkgZGlkbid0IGV2ZW4gdGVzdCB0aGF0IG9u ZS4KPiA+Cj4gPiBTaG91bGQgSSBqdXN0IHB1bGwgdGhhdCBwc3Jfc2V0dXBfdGltZTIgYnJhbmNo IGZvciByZWFsPyBJJ2QgbGlrZSB0bwo+ID4gZ2V0IGEgcmVhbCBwdWxsIHJlcXVlc3Qgd2l0aCBl eHBsYW5hdGlvbnMgZXRjLCBidXQgb3RoZXIgdGhhbiB0aGF0IGl0Cj4gPiBsb29rcyBnb29kIHRv IGdvLgo+IAo+IEhtLCBJIHJldmlld2VkIGFsbCB0aGUgcGF0Y2hlcyBmcm9tIFZpbGxlIGFscmVh ZHkuIEkgZ3VlcyB0aGV5IHdlcmUKPiBzdHVjayBiZWNhdXNlIHdlIGRpZG4ndCBoYXZlIHNvbWVv bmUgd2hvIHJlcG9ydGVkIHRoYXQgaXQncyBmaXhlZCwKPiBwbHVzIHRoZXkgbGFja2VkIGFuIGFj ayBmcm9tIERhdmUgZm9yIHRoZSAyIGNvcmUgcGF0Y2hlcy4KCisgdGhleSB3ZXJlIHBhcnQgb2Yg YSBzZXJpZXMgdGhhdCBpbmNsdWRlZCBhIHJvdHRlbiBhcHBsZSByZXNwb25zaWJsZQogIGZvciBh IEJBVCByZWdyZXNzaW9uCgo+IHRiaCBJJ2QganVzdAo+IGFwcGx5IHRoZW0gYWxsIHRvIGRybS1p bnRlbC1maXhlcyBhbmQgdGhlbiBzZW5kIG91dCBhIHB1bGwgZm9yIHRoYXQKPiAodGhlcmUncyB0 d28gbW9yZSBidWdmaXggcGF0Y2hlcyBvbiBpdCB3aGljaCBtaXNzZWQgRGF2ZSdzIG1haW4gcHVs bAo+IGJ5IGEgbm90Y2gpLiBEYXZlL0phbmk/Cj4gLURhbmllbAo+IC0tIAo+IERhbmllbCBWZXR0 ZXIKPiBTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KPiArNDEgKDApIDc5IDM2 NSA1NyA0OCAtIGh0dHA6Ly9ibG9nLmZmd2xsLmNoCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVs IE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmkt ZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK