From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39378) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUlu7-0002sV-3q for qemu-devel@nongnu.org; Tue, 02 Aug 2016 22:27:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bUlu5-0004aS-NG for qemu-devel@nongnu.org; Tue, 02 Aug 2016 22:27:31 -0400 Date: Wed, 3 Aug 2016 11:37:04 +1000 From: David Gibson Message-ID: <20160803013704.GF27583@voom.fritz.box> References: <1470035982-31658-1-git-send-email-raji@linux.vnet.ibm.com> <1470035982-31658-2-git-send-email-raji@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="xaMk4Io5JJdpkLEb" Content-Disposition: inline In-Reply-To: <1470035982-31658-2-git-send-email-raji@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH 1/5] target-ppc: add vector insert instructions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Rajalakshmi Srinivasaraghavan Cc: qemu-ppc@nongnu.org, rth@twiddle.net, qemu-devel@nongnu.org, nikunj@linux.vnet.ibm.com, benh@kernel.crashing.org --xaMk4Io5JJdpkLEb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 01, 2016 at 12:49:38PM +0530, Rajalakshmi Srinivasaraghavan wro= te: > The following vector insert instructions are added from ISA 3.0. >=20 > vinsertb - Vector Insert Byte > vinserth - Vector Insert Halfword > vinsertw - Vector Insert Word > vinsertd - Vector Insert Doubleword >=20 > Signed-off-by: Rajalakshmi Srinivasaraghavan > --- > target-ppc/helper.h | 4 ++++ > target-ppc/int_helper.c | 21 +++++++++++++++++++++ > target-ppc/translate/vmx-impl.c | 10 ++++++++++ > target-ppc/translate/vmx-ops.c | 19 ++++++++++++++----- > 4 files changed, 49 insertions(+), 5 deletions(-) >=20 > diff --git a/target-ppc/helper.h b/target-ppc/helper.h > index 93ac9e1..0923779 100644 > --- a/target-ppc/helper.h > +++ b/target-ppc/helper.h > @@ -250,6 +250,10 @@ DEF_HELPER_2(vspltisw, void, avr, i32) > DEF_HELPER_3(vspltb, void, avr, avr, i32) > DEF_HELPER_3(vsplth, void, avr, avr, i32) > DEF_HELPER_3(vspltw, void, avr, avr, i32) > +DEF_HELPER_3(vinsertb, void, avr, avr, i32) > +DEF_HELPER_3(vinserth, void, avr, avr, i32) > +DEF_HELPER_3(vinsertw, void, avr, avr, i32) > +DEF_HELPER_3(vinsertd, void, avr, avr, i32) > DEF_HELPER_2(vupkhpx, void, avr, avr) > DEF_HELPER_2(vupklpx, void, avr, avr) > DEF_HELPER_2(vupkhsb, void, avr, avr) > diff --git a/target-ppc/int_helper.c b/target-ppc/int_helper.c > index 552b2e0..637f0b1 100644 > --- a/target-ppc/int_helper.c > +++ b/target-ppc/int_helper.c > @@ -1790,6 +1790,27 @@ VSPLT(b, u8) > VSPLT(h, u16) > VSPLT(w, u32) > #undef VSPLT > +#if defined(HOST_WORDS_BIGENDIAN) > +#define VINSERT(suffix, element, index) = \ > + void helper_vinsert##suffix(ppc_avr_t *r, ppc_avr_t *b, uint32_t spl= at) \ > + { = \ > + memcpy(&r->u8[SPLAT_ELEMENT(u8)], &b->element[index], = \ > + sizeof(r->element[0])); = \ > + } > +#else > +#define VINSERT(suffix, element, index) = \ > + void helper_vinsert##suffix(ppc_avr_t *r, ppc_avr_t *b, uint32_t spl= at) \ > + { = \ > + memcpy(&r->u8[(16 - splat) - sizeof(r->element[0])], = \ > + &b->element[(ARRAY_SIZE(r->element) - index) - 1], = \ > + sizeof(r->element[0])); = \ > + } > +#endif > +VINSERT(b, u8, 7) > +VINSERT(h, u16, 3) > +VINSERT(w, u32, 1) > +VINSERT(d, u64, 0) > +#undef VINSERT > #undef SPLAT_ELEMENT > #undef _SPLAT_MASKED > =20 > diff --git a/target-ppc/translate/vmx-impl.c b/target-ppc/translate/vmx-i= mpl.c > index ac78caf..4940ae3 100644 > --- a/target-ppc/translate/vmx-impl.c > +++ b/target-ppc/translate/vmx-impl.c > @@ -626,10 +626,20 @@ static void glue(gen_, name)(DisasContext *ctx) = \ > GEN_VXFORM_UIMM(vspltb, 6, 8); > GEN_VXFORM_UIMM(vsplth, 6, 9); > GEN_VXFORM_UIMM(vspltw, 6, 10); > +GEN_VXFORM_UIMM(vinsertb, 6, 12); > +GEN_VXFORM_UIMM(vinserth, 6, 13); > +GEN_VXFORM_UIMM(vinsertw, 6, 14); > +GEN_VXFORM_UIMM(vinsertd, 6, 15); > GEN_VXFORM_UIMM_ENV(vcfux, 5, 12); > GEN_VXFORM_UIMM_ENV(vcfsx, 5, 13); > GEN_VXFORM_UIMM_ENV(vctuxs, 5, 14); > GEN_VXFORM_UIMM_ENV(vctsxs, 5, 15); > +GEN_VXFORM_DUAL(vspltisb, PPC_NONE, PPC2_ALTIVEC_207, > + vinsertb, PPC_NONE, PPC2_ISA300); > +GEN_VXFORM_DUAL(vspltish, PPC_NONE, PPC2_ALTIVEC_207, > + vinserth, PPC_NONE, PPC2_ISA300); > +GEN_VXFORM_DUAL(vspltisw, PPC_NONE, PPC2_ALTIVEC_207, > + vinsertw, PPC_NONE, PPC2_ISA300); > =20 > static void gen_vsldoi(DisasContext *ctx) > { > diff --git a/target-ppc/translate/vmx-ops.c b/target-ppc/translate/vmx-op= s.c > index 7449396..a5534da 100644 > --- a/target-ppc/translate/vmx-ops.c > +++ b/target-ppc/translate/vmx-ops.c > @@ -41,6 +41,9 @@ GEN_HANDLER_E(name, 0x04, opc2, opc3, 0x00000000, PPC_N= ONE, PPC2_ALTIVEC_207) > #define GEN_VXFORM_300(name, opc2, opc3) \ > GEN_HANDLER_E(name, 0x04, opc2, opc3, 0x00000000, PPC_NONE, PPC2_ISA300) > =20 > +#define GEN_VXFORM_300_EXT(name, opc2, opc3, inval) \ > +GEN_HANDLER_E(name, 0x04, opc2, opc3, inval, PPC_NONE, PPC2_ISA300) > + > #define GEN_VXFORM_DUAL(name0, name1, opc2, opc3, type0, type1) \ > GEN_HANDLER_E(name0##_##name1, 0x4, opc2, opc3, 0x00000000, type0, type1) > =20 > @@ -191,11 +194,17 @@ GEN_VXRFORM(vcmpgefp, 3, 7) > GEN_VXRFORM_DUAL(vcmpgtfp, vcmpgtud, 3, 11, PPC_ALTIVEC, PPC_NONE) > GEN_VXRFORM_DUAL(vcmpbfp, vcmpgtsd, 3, 15, PPC_ALTIVEC, PPC_NONE) > =20 > -#define GEN_VXFORM_SIMM(name, opc2, opc3) \ > - GEN_HANDLER(name, 0x04, opc2, opc3, 0x00000000, PPC_ALTIVEC) > -GEN_VXFORM_SIMM(vspltisb, 6, 12), > -GEN_VXFORM_SIMM(vspltish, 6, 13), > -GEN_VXFORM_SIMM(vspltisw, 6, 14), > +#undef GEN_VXFORM_DUAL1 Why the undef? AFAICT this was never defined elsewhere? > +#define GEN_VXFORM_DUAL1(name0, name1, opc2, opc3, inval0, inval1, type)= \ > +GEN_OPCODE_DUAL(name0##_##name1, 0x04, opc2, opc3, inval0, inval1, type,= \ > + PPC_NONE) > +GEN_VXFORM_DUAL1(vspltisb, vinsertb, 6, 12, 0x00000000, 0x100000, > + PPC2_ALTIVEC_207), > +GEN_VXFORM_DUAL1(vspltish, vinserth, 6, 13, 0x00000000, 0x100000, > + PPC2_ALTIVEC_207), > +GEN_VXFORM_DUAL1(vspltisw, vinsertw, 6, 14, 0x00000000, 0x100000, > + PPC2_ALTIVEC_207), > +GEN_VXFORM_300_EXT(vinsertd, 6, 15, 0x100000), Why do you need this in addition to the GEN_VXFORM_DUAL() invocations above? > =20 > #define GEN_VXFORM_NOA(name, opc2, opc3) \ > GEN_HANDLER(name, 0x04, opc2, opc3, 0x001f0000, PPC_ALTIVEC) --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --xaMk4Io5JJdpkLEb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXoUrAAAoJEGw4ysog2bOSFK8P/R0DfdMtcBJyLhwtpBB4hXay v7pIFjmihFPsVibh0Juv+o4d8xabePCsaAwpmF5WCvz3yrXFxMYc++dPDt7u9SYF 9N3xS5drjD3CjVj8fdfLkVP3qO+r7MQJ5bXdieReAtfyzJ7gOytIR9Mv72tzIi/3 oy2mWMUMXfzwiZfGlDszU2SrUIy2WrJ423MmoGRDjGMhZRxaR8namtzFjVv2Hezc 0z/t9z1igB6LiAJekg4SuP35hkCCsI++SvfeN8ZJc63+3RuRc36fI04FPiI17J3X x6OwPwVsPher7ZlL9rYICGMvY3vQc5ua2tXke8j54dGuMfwRbQcFEGh0+cI7EvEM is9DoYiwa4xBNkwH7bwYTxT7LW2g4uHTvBqzpv4ohkro4zf8XuJLRan5FwRCeiZ0 CxGd5apgWcW95+oiZDbjvb/pkJbKufd1UoCftDfwTEjt8Kihp9Bes+mV8T6sajhV 9wKFoGeer/q3Od1iEUBMdV4InbjFlqzcnmwFhHqSQ7rLTtSMFbI3GN3CTDr2ydKL TqoWh4WnmB8ym3RC1uKW9zBBp6MMTQcGpObI+npY7b8ncIe4NFIYhZxUCmj5R5dG 8ZvniFv6/AwRPETQ6XcaxijiCnoiurWI1Iye0Lyrg3HqN1J557WaoNGTCB1nbb0Y ah6WOTWaZUp/Fx3ErLH2 =17FL -----END PGP SIGNATURE----- --xaMk4Io5JJdpkLEb--