From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from aserp1040.oracle.com ([141.146.126.69]:25399 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758410AbcHCWJs (ORCPT ); Wed, 3 Aug 2016 18:09:48 -0400 Date: Wed, 3 Aug 2016 15:09:40 -0700 From: "Darrick J. Wong" Subject: Re: [PATCH 07/17] xfs/128: cycle_mount the scratch device, not the test device Message-ID: <20160803220940.GS8590@birch.djwong.org> References: <146914477514.11762.3144320628851923350.stgit@birch.djwong.org> <146914482100.11762.3197784490090678443.stgit@birch.djwong.org> <20160803093755.GN27776@eguan.usersys.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160803093755.GN27776@eguan.usersys.redhat.com> Sender: fstests-owner@vger.kernel.org To: Eryu Guan Cc: david@fromorbit.com, linux-btrfs@vger.kernel.org, fstests@vger.kernel.org, xfs@oss.sgi.com List-ID: On Wed, Aug 03, 2016 at 05:37:55PM +0800, Eryu Guan wrote: > On Thu, Jul 21, 2016 at 04:47:01PM -0700, Darrick J. Wong wrote: > > This test uses the scratch device, so cycle that, not the test dev. > > This is also a xfs_fsr test, so put it in the fsr group. > > > > Signed-off-by: Darrick J. Wong > > --- > > tests/xfs/128 | 7 ++++--- > > tests/xfs/group | 2 +- > > 2 files changed, 5 insertions(+), 4 deletions(-) > > > > > > diff --git a/tests/xfs/128 b/tests/xfs/128 > > index 8758d7e..2e756d5 100755 > > --- a/tests/xfs/128 > > +++ b/tests/xfs/128 > > @@ -66,7 +66,7 @@ _pwrite_byte 0x61 0 $((blks * blksz)) $testdir/file1 >> $seqres.full > > _cp_reflink $testdir/file1 $testdir/file2 > > _cp_reflink $testdir/file2 $testdir/file3 > > _cp_reflink $testdir/file3 $testdir/file4 > > -_test_cycle_mount > > +_scratch_cycle_mount > > free_blocks1=$(stat -f $testdir -c '%f') > > > > md5sum $testdir/file1 | _filter_scratch > > @@ -82,7 +82,7 @@ c04=$(_md5_checksum $testdir/file4) > > echo "CoW the reflink copies" > > _pwrite_byte 0x62 $blksz $blksz $testdir/file2 >> $seqres.full > > _pwrite_byte 0x63 $(( blksz * (blks - 1) )) $blksz $testdir/file3 >> $seqres.full > > -_test_cycle_mount > > +_scratch_cycle_mount > > free_blocks2=$(stat -f $testdir -c '%f') > > > > md5sum $testdir/file1 | _filter_scratch > > @@ -97,11 +97,12 @@ c14=$(_md5_checksum $testdir/file4) > > > > echo "Defragment" > > lsattr -l $testdir/ | _filter_scratch | _filter_spaces > > +filefrag -v $testdir/file* >> $seqres.full > > Is this intentional? Use $FILEFRAG_PROG instead and add > > _require_command "$FILEFRAG_PROG" "filefrag" > > at the beginning of the test? Oops, that was a mistake. Good catch! --D > > Thanks, > Eryu > > > $XFS_FSR_PROG -v -d $testdir/file1 >> $seqres.full > > $XFS_FSR_PROG -v -d $testdir/file2 >> $seqres.full # fsr probably breaks the link > > $XFS_FSR_PROG -v -d $testdir/file3 >> $seqres.full # fsr probably breaks the link > > $XFS_FSR_PROG -v -d $testdir/file4 >> $seqres.full # fsr probably ignores this file > > -_test_cycle_mount > > +_scratch_cycle_mount > > free_blocks3=$(stat -f $testdir -c '%f') > > > > md5sum $testdir/file1 | _filter_scratch > > diff --git a/tests/xfs/group b/tests/xfs/group > > index aa3b3ec..5ccf3d6 100644 > > --- a/tests/xfs/group > > +++ b/tests/xfs/group > > @@ -125,7 +125,7 @@ > > 125 fuzzers > > 126 fuzzers > > 127 auto quick clone > > -128 auto quick clone > > +128 auto quick clone fsr > > 129 auto quick clone > > 130 fuzzers clone > > 131 auto quick clone > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 9602B7CA1 for ; Wed, 3 Aug 2016 17:09:46 -0500 (CDT) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay2.corp.sgi.com (Postfix) with ESMTP id 687F9304053 for ; Wed, 3 Aug 2016 15:09:46 -0700 (PDT) Received: from aserp1040.oracle.com (aserp1040.oracle.com [141.146.126.69]) by cuda.sgi.com with ESMTP id B2Ip9F94UHIQYDIm (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Wed, 03 Aug 2016 15:09:44 -0700 (PDT) Date: Wed, 3 Aug 2016 15:09:40 -0700 From: "Darrick J. Wong" Subject: Re: [PATCH 07/17] xfs/128: cycle_mount the scratch device, not the test device Message-ID: <20160803220940.GS8590@birch.djwong.org> References: <146914477514.11762.3144320628851923350.stgit@birch.djwong.org> <146914482100.11762.3197784490090678443.stgit@birch.djwong.org> <20160803093755.GN27776@eguan.usersys.redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20160803093755.GN27776@eguan.usersys.redhat.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Eryu Guan Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org, xfs@oss.sgi.com On Wed, Aug 03, 2016 at 05:37:55PM +0800, Eryu Guan wrote: > On Thu, Jul 21, 2016 at 04:47:01PM -0700, Darrick J. Wong wrote: > > This test uses the scratch device, so cycle that, not the test dev. > > This is also a xfs_fsr test, so put it in the fsr group. > > > > Signed-off-by: Darrick J. Wong > > --- > > tests/xfs/128 | 7 ++++--- > > tests/xfs/group | 2 +- > > 2 files changed, 5 insertions(+), 4 deletions(-) > > > > > > diff --git a/tests/xfs/128 b/tests/xfs/128 > > index 8758d7e..2e756d5 100755 > > --- a/tests/xfs/128 > > +++ b/tests/xfs/128 > > @@ -66,7 +66,7 @@ _pwrite_byte 0x61 0 $((blks * blksz)) $testdir/file1 >> $seqres.full > > _cp_reflink $testdir/file1 $testdir/file2 > > _cp_reflink $testdir/file2 $testdir/file3 > > _cp_reflink $testdir/file3 $testdir/file4 > > -_test_cycle_mount > > +_scratch_cycle_mount > > free_blocks1=$(stat -f $testdir -c '%f') > > > > md5sum $testdir/file1 | _filter_scratch > > @@ -82,7 +82,7 @@ c04=$(_md5_checksum $testdir/file4) > > echo "CoW the reflink copies" > > _pwrite_byte 0x62 $blksz $blksz $testdir/file2 >> $seqres.full > > _pwrite_byte 0x63 $(( blksz * (blks - 1) )) $blksz $testdir/file3 >> $seqres.full > > -_test_cycle_mount > > +_scratch_cycle_mount > > free_blocks2=$(stat -f $testdir -c '%f') > > > > md5sum $testdir/file1 | _filter_scratch > > @@ -97,11 +97,12 @@ c14=$(_md5_checksum $testdir/file4) > > > > echo "Defragment" > > lsattr -l $testdir/ | _filter_scratch | _filter_spaces > > +filefrag -v $testdir/file* >> $seqres.full > > Is this intentional? Use $FILEFRAG_PROG instead and add > > _require_command "$FILEFRAG_PROG" "filefrag" > > at the beginning of the test? Oops, that was a mistake. Good catch! --D > > Thanks, > Eryu > > > $XFS_FSR_PROG -v -d $testdir/file1 >> $seqres.full > > $XFS_FSR_PROG -v -d $testdir/file2 >> $seqres.full # fsr probably breaks the link > > $XFS_FSR_PROG -v -d $testdir/file3 >> $seqres.full # fsr probably breaks the link > > $XFS_FSR_PROG -v -d $testdir/file4 >> $seqres.full # fsr probably ignores this file > > -_test_cycle_mount > > +_scratch_cycle_mount > > free_blocks3=$(stat -f $testdir -c '%f') > > > > md5sum $testdir/file1 | _filter_scratch > > diff --git a/tests/xfs/group b/tests/xfs/group > > index aa3b3ec..5ccf3d6 100644 > > --- a/tests/xfs/group > > +++ b/tests/xfs/group > > @@ -125,7 +125,7 @@ > > 125 fuzzers > > 126 fuzzers > > 127 auto quick clone > > -128 auto quick clone > > +128 auto quick clone fsr > > 129 auto quick clone > > 130 fuzzers clone > > 131 auto quick clone > > _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs