All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Cooper <jason@lakedaemon.net>
To: Kees Cook <keescook@chromium.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	"Roberts, William C" <william.c.roberts@intel.com>,
	Yann Droneaud <ydroneaud@opteya.com>
Cc: "Linux-MM" <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"kernel-hardening" <kernel-hardening@lists.openwall.com>,
	"Russell King - ARM Linux" <linux@arm.linux.org.uk>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Theodore Ts'o" <tytso@mit.edu>, Arnd Bergmann <arnd@arndb.de>,
	gregkh@linuxfoundation.org,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Ralf Baechle <ralf@linux-mips.org>,
	benh@kernel.crashing.org, paulus@samba.org,
	"David S. Miller" <davem@davemloft.net>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, viro@zeniv.linux.org.uk,
	Nick Kralevich <nnk@google.com>,
	Jeffrey Vander Stoep <jeffv@google.com>,
	Daniel Cashman <dcashman@android.com>,
	Jason Cooper <jason@lakedaemon.net>
Subject: [PATCH v3 5/7] tile: Use simpler API for random address requests
Date: Wed,  3 Aug 2016 23:39:11 +0000	[thread overview]
Message-ID: <20160803233913.32511-6-jason@lakedaemon.net> (raw)
In-Reply-To: <20160803233913.32511-1-jason@lakedaemon.net>

Currently, all callers to randomize_range() set the length to 0 and
calculate end by adding a constant to the start address.  We can
simplify the API to remove a bunch of needless checks and variables.

Use the new randomize_addr(start, range) call to set the requested
address.

Signed-off-by: Jason Cooper <jason@lakedaemon.net>
---
Changes from v2:
 - s/randomize_addr/randomize_page/ (Kees Cook)

 arch/tile/mm/mmap.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/tile/mm/mmap.c b/arch/tile/mm/mmap.c
index 851a94e6ae58..ef61c597898b 100644
--- a/arch/tile/mm/mmap.c
+++ b/arch/tile/mm/mmap.c
@@ -88,6 +88,5 @@ void arch_pick_mmap_layout(struct mm_struct *mm)
 
 unsigned long arch_randomize_brk(struct mm_struct *mm)
 {
-	unsigned long range_end = mm->brk + 0x02000000;
-	return randomize_range(mm->brk, range_end, 0) ? : mm->brk;
+	return randomize_page(mm->brk, 0x02000000);
 }
-- 
2.9.2

WARNING: multiple messages have this Message-ID (diff)
From: Jason Cooper <jason@lakedaemon.net>
To: Kees Cook <keescook@chromium.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	"Roberts, William C" <william.c.roberts@intel.com>,
	Yann Droneaud <ydroneaud@opteya.com>
Cc: Linux-MM <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>,
	kernel-hardening <kernel-hardening@lists.openwall.com>,
	Russell King - ARM Linux <linux@arm.linux.org.uk>,
	Andrew Morton <akpm@linux-foundation.org>,
	Theodore Ts'o <tytso@mit.edu>, Arnd Bergmann <arnd@arndb.de>,
	gregkh@linuxfoundation.org,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Ralf Baechle <ralf@linux-mips.org>,
	benh@kernel.crashing.org, paulus@samba.org,
	"David S. Miller" <davem@davemloft.net>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, viro@zeniv.linux.org.uk,
	Nick Kralevich <nnk@google.com>,
	Jeffrey Vander Stoep <jeffv@google.com>,
	Daniel Cashman <dcashman@android.com>,
	Jason Cooper <jason@lakedaemon.net>
Subject: [PATCH v3 5/7] tile: Use simpler API for random address requests
Date: Wed,  3 Aug 2016 23:39:11 +0000	[thread overview]
Message-ID: <20160803233913.32511-6-jason@lakedaemon.net> (raw)
In-Reply-To: <20160803233913.32511-1-jason@lakedaemon.net>

Currently, all callers to randomize_range() set the length to 0 and
calculate end by adding a constant to the start address.  We can
simplify the API to remove a bunch of needless checks and variables.

Use the new randomize_addr(start, range) call to set the requested
address.

Signed-off-by: Jason Cooper <jason@lakedaemon.net>
---
Changes from v2:
 - s/randomize_addr/randomize_page/ (Kees Cook)

 arch/tile/mm/mmap.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/tile/mm/mmap.c b/arch/tile/mm/mmap.c
index 851a94e6ae58..ef61c597898b 100644
--- a/arch/tile/mm/mmap.c
+++ b/arch/tile/mm/mmap.c
@@ -88,6 +88,5 @@ void arch_pick_mmap_layout(struct mm_struct *mm)
 
 unsigned long arch_randomize_brk(struct mm_struct *mm)
 {
-	unsigned long range_end = mm->brk + 0x02000000;
-	return randomize_range(mm->brk, range_end, 0) ? : mm->brk;
+	return randomize_page(mm->brk, 0x02000000);
 }
-- 
2.9.2

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Jason Cooper <jason@lakedaemon.net>
To: Kees Cook <keescook@chromium.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	"Roberts, William C" <william.c.roberts@intel.com>,
	Yann Droneaud <ydroneaud@opteya.com>
Cc: Linux-MM <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>,
	kernel-hardening <kernel-hardening@lists.openwall.com>,
	Russell King - ARM Linux <linux@arm.linux.org.uk>,
	Andrew Morton <akpm@linux-foundation.org>,
	Theodore Ts'o <tytso@mit.edu>, Arnd Bergmann <arnd@arndb.de>,
	gregkh@linuxfoundation.org,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Ralf Baechle <ralf@linux-mips.org>,
	benh@kernel.crashing.org, paulus@samba.org,
	"David S. Miller" <davem@davemloft.net>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, viro@zeniv.linux.org.uk,
	Nick Kralevich <nnk@google.com>,
	Jeffrey Vander Stoep <jeffv@google.com>,
	Daniel Cashman <dcashman@android.com>,
	Jason Cooper <jason@lakedaemon.net>
Subject: [kernel-hardening] [PATCH v3 5/7] tile: Use simpler API for random address requests
Date: Wed,  3 Aug 2016 23:39:11 +0000	[thread overview]
Message-ID: <20160803233913.32511-6-jason@lakedaemon.net> (raw)
In-Reply-To: <20160803233913.32511-1-jason@lakedaemon.net>

Currently, all callers to randomize_range() set the length to 0 and
calculate end by adding a constant to the start address.  We can
simplify the API to remove a bunch of needless checks and variables.

Use the new randomize_addr(start, range) call to set the requested
address.

Signed-off-by: Jason Cooper <jason@lakedaemon.net>
---
Changes from v2:
 - s/randomize_addr/randomize_page/ (Kees Cook)

 arch/tile/mm/mmap.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/tile/mm/mmap.c b/arch/tile/mm/mmap.c
index 851a94e6ae58..ef61c597898b 100644
--- a/arch/tile/mm/mmap.c
+++ b/arch/tile/mm/mmap.c
@@ -88,6 +88,5 @@ void arch_pick_mmap_layout(struct mm_struct *mm)
 
 unsigned long arch_randomize_brk(struct mm_struct *mm)
 {
-	unsigned long range_end = mm->brk + 0x02000000;
-	return randomize_range(mm->brk, range_end, 0) ? : mm->brk;
+	return randomize_page(mm->brk, 0x02000000);
 }
-- 
2.9.2

  parent reply	other threads:[~2016-08-03 23:40 UTC|newest]

Thread overview: 111+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-28 20:47 [PATCH 0/7] char/random: Simplify random address requests Jason Cooper
2016-07-28 20:47 ` [kernel-hardening] " Jason Cooper
2016-07-28 20:47 ` Jason Cooper
2016-07-28 20:47 ` [PATCH 1/7] random: Simplify API for " Jason Cooper
2016-07-28 20:47   ` [kernel-hardening] " Jason Cooper
2016-07-28 20:47   ` Jason Cooper
2016-07-29  8:59   ` Yann Droneaud
2016-07-29  8:59     ` [kernel-hardening] " Yann Droneaud
2016-07-29  8:59     ` Yann Droneaud
2016-07-29 18:20     ` Jason Cooper
2016-07-29 18:20       ` [kernel-hardening] " Jason Cooper
2016-07-29 18:20       ` Jason Cooper
2016-07-28 20:47 ` [PATCH 2/7] x86: Use simpler " Jason Cooper
2016-07-28 20:47   ` [kernel-hardening] " Jason Cooper
2016-07-28 20:47   ` Jason Cooper
2016-07-28 20:47 ` [PATCH 3/7] ARM: " Jason Cooper
2016-07-28 20:47   ` [kernel-hardening] " Jason Cooper
2016-07-28 20:47   ` Jason Cooper
2016-07-28 20:47 ` [PATCH 4/7] arm64: " Jason Cooper
2016-07-28 20:47   ` [kernel-hardening] " Jason Cooper
2016-07-28 20:47   ` Jason Cooper
2016-07-29 13:48   ` Will Deacon
2016-07-29 13:48     ` [kernel-hardening] " Will Deacon
2016-07-29 13:48     ` Will Deacon
2016-07-28 20:47 ` [PATCH 5/7] tile: " Jason Cooper
2016-07-28 20:47   ` [kernel-hardening] " Jason Cooper
2016-07-28 20:47   ` Jason Cooper
2016-07-28 20:47 ` [PATCH 6/7] unicore32: " Jason Cooper
2016-07-28 20:47   ` [kernel-hardening] " Jason Cooper
2016-07-28 20:47   ` Jason Cooper
2016-07-28 20:47 ` [PATCH 7/7] random: Remove unused randomize_range() Jason Cooper
2016-07-28 20:47   ` [kernel-hardening] " Jason Cooper
2016-07-28 20:47   ` Jason Cooper
2016-07-30 15:42 ` [PATCH v2 0/7] char/random: Simplify random address requests Jason Cooper
2016-07-30 15:42   ` [kernel-hardening] " Jason Cooper
2016-07-30 15:42   ` Jason Cooper
2016-07-30 15:42   ` [PATCH v2 1/7] random: Simplify API for " Jason Cooper
2016-07-30 15:42     ` [kernel-hardening] " Jason Cooper
2016-07-30 15:42     ` Jason Cooper
2016-07-31 16:46     ` Kees Cook
2016-07-31 16:46       ` [kernel-hardening] " Kees Cook
2016-07-31 16:46       ` Kees Cook
2016-07-31 20:56       ` Jason Cooper
2016-07-31 20:56         ` [kernel-hardening] " Jason Cooper
2016-07-31 20:56         ` Jason Cooper
2016-08-01 19:47         ` Kees Cook
2016-08-01 19:47           ` [kernel-hardening] " Kees Cook
2016-08-01 19:47           ` Kees Cook
2016-08-01 23:17           ` Jason Cooper
2016-08-01 23:17             ` [kernel-hardening] " Jason Cooper
2016-08-01 23:17             ` Jason Cooper
2016-08-02  3:35             ` [kernel-hardening] " Michael Ellerman
2016-08-02  3:35               ` Michael Ellerman
2016-08-02  3:35               ` Michael Ellerman
2016-08-03 18:42               ` Jason Cooper
2016-08-03 18:42                 ` Jason Cooper
2016-08-03 18:42                 ` Jason Cooper
2016-07-30 15:42   ` [PATCH v2 2/7] x86: Use simpler " Jason Cooper
2016-07-30 15:42     ` [kernel-hardening] " Jason Cooper
2016-07-30 15:42     ` Jason Cooper
2016-07-30 15:42   ` [PATCH v2 3/7] ARM: " Jason Cooper
2016-07-30 15:42     ` [kernel-hardening] " Jason Cooper
2016-07-30 15:42     ` Jason Cooper
2016-07-30 15:42   ` [PATCH v2 4/7] arm64: " Jason Cooper
2016-07-30 15:42     ` [kernel-hardening] " Jason Cooper
2016-07-30 15:42     ` Jason Cooper
2016-07-30 15:42   ` [PATCH v2 5/7] tile: " Jason Cooper
2016-07-30 15:42     ` [kernel-hardening] " Jason Cooper
2016-07-30 15:42     ` Jason Cooper
2016-07-30 15:42   ` [PATCH v2 6/7] unicore32: " Jason Cooper
2016-07-30 15:42     ` [kernel-hardening] " Jason Cooper
2016-07-30 15:42     ` Jason Cooper
2016-07-30 15:42   ` [PATCH v2 7/7] random: Remove unused randomize_range() Jason Cooper
2016-07-30 15:42     ` [kernel-hardening] " Jason Cooper
2016-07-30 15:42     ` Jason Cooper
2016-08-03 23:39 ` [PATCH v3 0/7] char/random: Simplify random address requests Jason Cooper
2016-08-03 23:39   ` [kernel-hardening] " Jason Cooper
2016-08-03 23:39   ` Jason Cooper
2016-08-03 23:39   ` [PATCH v3 1/7] random: Simplify API for " Jason Cooper
2016-08-03 23:39     ` [kernel-hardening] " Jason Cooper
2016-08-03 23:39     ` Jason Cooper
2016-08-04 12:47     ` Yann Droneaud
2016-08-04 12:47       ` [kernel-hardening] " Yann Droneaud
2016-08-04 12:47       ` Yann Droneaud
2016-08-03 23:39   ` [PATCH v3 2/7] x86: Use simpler " Jason Cooper
2016-08-03 23:39     ` [kernel-hardening] " Jason Cooper
2016-08-03 23:39     ` Jason Cooper
2016-08-03 23:39   ` [PATCH v3 3/7] ARM: " Jason Cooper
2016-08-03 23:39     ` [kernel-hardening] " Jason Cooper
2016-08-03 23:39     ` Jason Cooper
2016-08-03 23:39   ` [PATCH v3 4/7] arm64: " Jason Cooper
2016-08-03 23:39     ` [kernel-hardening] " Jason Cooper
2016-08-03 23:39     ` Jason Cooper
2016-08-03 23:39   ` Jason Cooper [this message]
2016-08-03 23:39     ` [kernel-hardening] [PATCH v3 5/7] tile: " Jason Cooper
2016-08-03 23:39     ` Jason Cooper
2016-08-03 23:39   ` [PATCH v3 6/7] unicore32: " Jason Cooper
2016-08-03 23:39     ` [kernel-hardening] " Jason Cooper
2016-08-03 23:39     ` Jason Cooper
2016-08-03 23:39   ` [PATCH v3 7/7] random: Remove unused randomize_range() Jason Cooper
2016-08-03 23:39     ` [kernel-hardening] " Jason Cooper
2016-08-03 23:39     ` Jason Cooper
2016-08-03 23:48     ` Andrew Morton
2016-08-03 23:48       ` [kernel-hardening] " Andrew Morton
2016-08-03 23:48       ` Andrew Morton
2016-08-04  0:19       ` Jason Cooper
2016-08-04  0:19         ` [kernel-hardening] " Jason Cooper
2016-08-04  0:19         ` Jason Cooper
2016-08-04  2:41   ` [PATCH v3 0/7] char/random: Simplify random address requests Kees Cook
2016-08-04  2:41     ` [kernel-hardening] " Kees Cook
2016-08-04  2:41     ` Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160803233913.32511-6-jason@lakedaemon.net \
    --to=jason@lakedaemon.net \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=benh@kernel.crashing.org \
    --cc=catalin.marinas@arm.com \
    --cc=davem@davemloft.net \
    --cc=dcashman@android.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpa@zytor.com \
    --cc=jeffv@google.com \
    --cc=keescook@chromium.org \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mingo@redhat.com \
    --cc=mpe@ellerman.id.au \
    --cc=nnk@google.com \
    --cc=paulus@samba.org \
    --cc=ralf@linux-mips.org \
    --cc=tglx@linutronix.de \
    --cc=tytso@mit.edu \
    --cc=viro@zeniv.linux.org.uk \
    --cc=will.deacon@arm.com \
    --cc=william.c.roberts@intel.com \
    --cc=x86@kernel.org \
    --cc=ydroneaud@opteya.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.