From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161265AbcHEMCs (ORCPT ); Fri, 5 Aug 2016 08:02:48 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:35116 "EHLO imgpgp01.kl.imgtec.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S934983AbcHEMCr (ORCPT ); Fri, 5 Aug 2016 08:02:47 -0400 X-PGP-Universal: processed; by imgpgp01.kl.imgtec.org on Fri, 05 Aug 2016 13:02:44 +0100 Date: Fri, 5 Aug 2016 13:02:43 +0100 From: James Hogan To: Mel Gorman CC: Andrew Morton , Linux-MM , Rik van Riel , Vlastimil Babka , "Johannes Weiner" , Minchan Kim , Joonsoo Kim , LKML , metag Subject: Re: [PATCH 03/34] mm, vmscan: move LRU lists to node Message-ID: <20160805120243.GI19514@jhogan-linux.le.imgtec.org> References: <1467970510-21195-1-git-send-email-mgorman@techsingularity.net> <1467970510-21195-4-git-send-email-mgorman@techsingularity.net> <20160805084115.GO2799@techsingularity.net> <20160805105256.GH19514@jhogan-linux.le.imgtec.org> <20160805115526.GS2799@techsingularity.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="CxDuMX1Cv2n9FQfo" Content-Disposition: inline In-Reply-To: <20160805115526.GS2799@techsingularity.net> User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [192.168.154.110] X-ESG-ENCRYPT-TAG: cee91754 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --CxDuMX1Cv2n9FQfo Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 05, 2016 at 12:55:26PM +0100, Mel Gorman wrote: > On Fri, Aug 05, 2016 at 11:52:57AM +0100, James Hogan wrote: > > > What's surprising is that it worked for the zone stats as it appears > > > that calling zone_reclaimable() from that context should also have > > > broken. Did anything change recently that would have avoided the > > > zone->pageset dereference in zone_reclaimable() before? > >=20 > > It appears that zone_pcp_init() was already setting zone->pageset to > > &boot_pageset, via paging_init(): > >=20 >=20 > /me slaps self >=20 > Of course. >=20 > > > The easiest option would be to not call show_mem from arch code until > > > after the pagesets are setup. > >=20 > > Since no other arches seem to do show_mem earily during boot like metag, > > and doing so doesn't really add much value, I'm happy to remove it > > anyway. > >=20 >=20 > Thanks. Can I assume you'll merge such a patch or should I roll one? Yep, I'll take care of it. >=20 > > However could your change break other things and need fixing anyway? > >=20 >=20 > Not that I'm aware of. There would have to be a node-based stat that has > meaning that early in boot to have an effect. If one happened to added > then it would need fixing but until then the complexity is unnecessary. Okay, thanks for the help, Cheers James --CxDuMX1Cv2n9FQfo Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXpIBjAAoJEGwLaZPeOHZ6ByEQAJPHh/rh84UXd+vdhioXMyLi C49Q12KTCXHIVBPO/R3oCIY/PimluH1yeh8fJ0OB43y8Sh7G0iVg9/qBHf7+vuPQ NmY0jyK+/moMCABDSTQDD8WQBIZvDDgNOxASgbksy23lW36jro3erCEqt636V/8Y 93q3kJJvZ2eH/Dm7OXFHQeXjVqMRmv8l1KnmxG9RrZvQwp2HsyBgBFKJvM79K8QC ezvHo5mmBFXECPlhi8+ydiUzqL36Yj6KRLQVRENu5odCop68Cp8FAizFx1MGhH1/ EzMCoUexr2666hnagBpUgZ4STeMWiNtZ1fWDzZxoANHPotwtGAnwebgKsRoyXflj J1psAu7byHOBtckK136vngOR/Nx1eGt3elSTob7PXUIl4rN1J2B5QImH6pc0jHE2 6TonqH7M/LghTe8OlrsNuCKDsmstonpPnz/8/kiROe9XUtEFqD1ADzrrFz0Z90ON vC+5kCOzqmU46NBNrtNDn/jZI+4bZkd54QrNVpdoxPJeXinE8I6Vyd4HK2+0Oa8f hw+BrtmK5leGb5Sbef5LgkifXtOH1vDS8FiL12V5ifJsFEfXtOudlglWRrYhhDLv kKkuhioZX4qSqMh3z/k8JX5f8/h6rKHcXqNQ6ex+yhh2iiMinMFskbC92Tf/aHBn yaGEVIMD3kF+dTNx58jQ =zevg -----END PGP SIGNATURE----- --CxDuMX1Cv2n9FQfo-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Hogan Subject: Re: [PATCH 03/34] mm, vmscan: move LRU lists to node Date: Fri, 5 Aug 2016 13:02:43 +0100 Message-ID: <20160805120243.GI19514@jhogan-linux.le.imgtec.org> References: <1467970510-21195-1-git-send-email-mgorman@techsingularity.net> <1467970510-21195-4-git-send-email-mgorman@techsingularity.net> <20160805084115.GO2799@techsingularity.net> <20160805105256.GH19514@jhogan-linux.le.imgtec.org> <20160805115526.GS2799@techsingularity.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="CxDuMX1Cv2n9FQfo" Return-path: Content-Disposition: inline In-Reply-To: <20160805115526.GS2799-3eNAlZScCAx27rWaFMvyedHuzzzSOjJt@public.gmane.org> Sender: linux-metag-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: To: Mel Gorman Cc: Andrew Morton , Linux-MM , Rik van Riel , Vlastimil Babka , Johannes Weiner , Minchan Kim , Joonsoo Kim , LKML , metag --CxDuMX1Cv2n9FQfo Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 05, 2016 at 12:55:26PM +0100, Mel Gorman wrote: > On Fri, Aug 05, 2016 at 11:52:57AM +0100, James Hogan wrote: > > > What's surprising is that it worked for the zone stats as it appears > > > that calling zone_reclaimable() from that context should also have > > > broken. Did anything change recently that would have avoided the > > > zone->pageset dereference in zone_reclaimable() before? > >=20 > > It appears that zone_pcp_init() was already setting zone->pageset to > > &boot_pageset, via paging_init(): > >=20 >=20 > /me slaps self >=20 > Of course. >=20 > > > The easiest option would be to not call show_mem from arch code until > > > after the pagesets are setup. > >=20 > > Since no other arches seem to do show_mem earily during boot like metag, > > and doing so doesn't really add much value, I'm happy to remove it > > anyway. > >=20 >=20 > Thanks. Can I assume you'll merge such a patch or should I roll one? Yep, I'll take care of it. >=20 > > However could your change break other things and need fixing anyway? > >=20 >=20 > Not that I'm aware of. There would have to be a node-based stat that has > meaning that early in boot to have an effect. If one happened to added > then it would need fixing but until then the complexity is unnecessary. Okay, thanks for the help, Cheers James --CxDuMX1Cv2n9FQfo Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXpIBjAAoJEGwLaZPeOHZ6ByEQAJPHh/rh84UXd+vdhioXMyLi C49Q12KTCXHIVBPO/R3oCIY/PimluH1yeh8fJ0OB43y8Sh7G0iVg9/qBHf7+vuPQ NmY0jyK+/moMCABDSTQDD8WQBIZvDDgNOxASgbksy23lW36jro3erCEqt636V/8Y 93q3kJJvZ2eH/Dm7OXFHQeXjVqMRmv8l1KnmxG9RrZvQwp2HsyBgBFKJvM79K8QC ezvHo5mmBFXECPlhi8+ydiUzqL36Yj6KRLQVRENu5odCop68Cp8FAizFx1MGhH1/ EzMCoUexr2666hnagBpUgZ4STeMWiNtZ1fWDzZxoANHPotwtGAnwebgKsRoyXflj J1psAu7byHOBtckK136vngOR/Nx1eGt3elSTob7PXUIl4rN1J2B5QImH6pc0jHE2 6TonqH7M/LghTe8OlrsNuCKDsmstonpPnz/8/kiROe9XUtEFqD1ADzrrFz0Z90ON vC+5kCOzqmU46NBNrtNDn/jZI+4bZkd54QrNVpdoxPJeXinE8I6Vyd4HK2+0Oa8f hw+BrtmK5leGb5Sbef5LgkifXtOH1vDS8FiL12V5ifJsFEfXtOudlglWRrYhhDLv kKkuhioZX4qSqMh3z/k8JX5f8/h6rKHcXqNQ6ex+yhh2iiMinMFskbC92Tf/aHBn yaGEVIMD3kF+dTNx58jQ =zevg -----END PGP SIGNATURE----- --CxDuMX1Cv2n9FQfo--