From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161365AbcHEM4V (ORCPT ); Fri, 5 Aug 2016 08:56:21 -0400 Received: from mail-wm0-f54.google.com ([74.125.82.54]:38204 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161259AbcHEM4T (ORCPT ); Fri, 5 Aug 2016 08:56:19 -0400 Date: Fri, 5 Aug 2016 13:57:43 +0100 From: Lee Jones To: Paul Gortmaker Cc: linux-kernel@vger.kernel.org, Samuel Ortiz , Sourav Poddar Subject: Re: [PATCH 4/6] mfd: smsc-ece1099: Make it explicitly non-modular Message-ID: <20160805125743.GC5243@dell> References: <20160705012544.14143-1-paul.gortmaker@windriver.com> <20160705012544.14143-5-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160705012544.14143-5-paul.gortmaker@windriver.com> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 04 Jul 2016, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > drivers/mfd/Kconfig:config MFD_SMSC > drivers/mfd/Kconfig: bool "SMSC ECE1099 series chips" > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. > > Since module_init was not in use by this code, the init ordering > remains unchanged with this commit. > > We replace module.h with init.h and delete an unused moduleparam.h > include. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > We also delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments. > > Cc: Samuel Ortiz > Cc: Lee Jones > Cc: Sourav Poddar > Signed-off-by: Paul Gortmaker > --- > drivers/mfd/smsc-ece1099.c | 11 ++--------- > 1 file changed, 2 insertions(+), 9 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/smsc-ece1099.c b/drivers/mfd/smsc-ece1099.c > index cd18c09827ef..1f40baf1234e 100644 > --- a/drivers/mfd/smsc-ece1099.c > +++ b/drivers/mfd/smsc-ece1099.c > @@ -11,8 +11,7 @@ > * > */ > > -#include > -#include > +#include > #include > #include > #include > @@ -81,7 +80,6 @@ static const struct i2c_device_id smsc_i2c_id[] = { > { "smscece1099", 0}, > {}, > }; > -MODULE_DEVICE_TABLE(i2c, smsc_i2c_id); > > static struct i2c_driver smsc_i2c_driver = { > .driver = { > @@ -90,9 +88,4 @@ static struct i2c_driver smsc_i2c_driver = { > .probe = smsc_i2c_probe, > .id_table = smsc_i2c_id, > }; > - > -module_i2c_driver(smsc_i2c_driver); > - > -MODULE_AUTHOR("Sourav Poddar "); > -MODULE_DESCRIPTION("SMSC chip multi-function driver"); > -MODULE_LICENSE("GPL v2"); > +builtin_i2c_driver(smsc_i2c_driver); -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog