From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1422790AbcHEQCD (ORCPT <rfc822;w@1wt.eu>);
	Fri, 5 Aug 2016 12:02:03 -0400
Received: from mx1.redhat.com ([209.132.183.28]:46348 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1759928AbcHEQCB (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 5 Aug 2016 12:02:01 -0400
Date: Fri, 5 Aug 2016 11:01:57 -0500
From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Nilay Vaish <nilayvaish@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@kernel.org>,
        "H . Peter Anvin" <hpa@zytor.com>, x86 <x86@kernel.org>,
        Linux Kernel list <linux-kernel@vger.kernel.org>,
        Andy Lutomirski <luto@amacapital.net>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Steven Rostedt <rostedt@goodmis.org>, Brian Gerst <brgerst@gmail.com>,
        Kees Cook <keescook@chromium.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Byungchul Park <byungchul.park@lge.com>
Subject: Re: [PATCH v2 03/44] x86/asm/head: rename 'stack_start' ->
 'initial_stack'
Message-ID: <20160805160157.7blwronmj4tecrud@treble>
References: <cover.1470345772.git.jpoimboe@redhat.com>
 <0070e6dc7c24fe73c17d20e3a7f9885c10616abc.1470345772.git.jpoimboe@redhat.com>
 <CACbG309-9_pVraDYNTKczATMMLSdSjQ_Jyvb=pFkabuos9pQrg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CACbG309-9_pVraDYNTKczATMMLSdSjQ_Jyvb=pFkabuos9pQrg@mail.gmail.com>
User-Agent: Mutt/1.6.0.1 (2016-04-01)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 05 Aug 2016 16:02:00 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Aug 05, 2016 at 10:28:39AM -0500, Nilay Vaish wrote:
> On 4 August 2016 at 17:21, Josh Poimboeuf <jpoimboe@redhat.com> wrote:
> > The 'stack_start' variable is similar in usage to 'initial_code' and
> > 'initial_gs': they're all stored in head_64.S and they're all updated by
> > SMP and ACPI suspend before starting a CPU.
> >
> > Rename it to 'initial_stack' to be consistent with the others.
> >
> 
> May be change the following line as well:
> 
> ./arch/x86/kernel/head_64.S:69:     * Setup stack for verify_cpu().
> "-8" because stack_start is defined

Ah, yeah, I missed that one.

And also, now that I see that comment, and the line below it:

  leaq    (__end_init_task - 8)(%rip), %rsp

The 8 should be changed to SIZEOF_PTREGS in a later patch
("x86/asm/head: standardize the end of the stack for idle tasks").

-- 
Josh