From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37657) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bWgQz-0003Uj-2Q for qemu-devel@nongnu.org; Mon, 08 Aug 2016 05:01:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bWgQu-0007CD-58 for qemu-devel@nongnu.org; Mon, 08 Aug 2016 05:01:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60908) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bWgQt-0007C9-W2 for qemu-devel@nongnu.org; Mon, 08 Aug 2016 05:01:16 -0400 Date: Mon, 8 Aug 2016 17:01:11 +0800 From: Peter Xu Message-ID: <20160808090111.GH3825@pxdev.xzpeter.org> References: <1470127147-12442-1-git-send-email-davidkiarie4@gmail.com> <1470127147-12442-2-git-send-email-davidkiarie4@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1470127147-12442-2-git-send-email-davidkiarie4@gmail.com> Subject: Re: [Qemu-devel] [V15 1/4] hw/pci: Prepare for AMD IOMMU List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Kiarie Cc: qemu-devel@nongnu.org, rkrcmar@redhat.com, jan.kiszka@web.de, valentine.sinitsyn@gmail.com, ehabkost@redhat.com, mst@redhat.com On Tue, Aug 02, 2016 at 11:39:04AM +0300, David Kiarie wrote: > Introduce PCI macros from for use by AMD IOMMU > > Signed-off-by: David Kiarie > --- > include/hw/pci/pci.h | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h > index 929ec2f..d47e0e6 100644 > --- a/include/hw/pci/pci.h > +++ b/include/hw/pci/pci.h > @@ -11,11 +11,14 @@ > #include "hw/pci/pcie.h" > > /* PCI bus */ > - > +#define PCI_BDF(bus, devfn) ((((uint16_t)(bus)) << 8) | (devfn)) Seems the same as PCI_BUILD_BDF() below? > #define PCI_DEVFN(slot, func) ((((slot) & 0x1f) << 3) | ((func) & 0x07)) > +#define PCI_BUS_NUM(x) (((x) >> 8) & 0xff) > #define PCI_SLOT(devfn) (((devfn) >> 3) & 0x1f) > #define PCI_FUNC(devfn) ((devfn) & 0x07) > #define PCI_BUILD_BDF(bus, devfn) ((bus << 8) | (devfn)) > +#define PCI_BUS_MAX 256 > +#define PCI_DEVFN_MAX 256 > #define PCI_SLOT_MAX 32 > #define PCI_FUNC_MAX 8 > > -- > 2.1.4 > -- peterx