From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 02/33] drm/i915: Do not overwrite the request with zero on reallocation Date: Mon, 8 Aug 2016 11:25:56 +0200 Message-ID: <20160808092556.GY6232@phenom.ffwll.local> References: <1470581141-14432-1-git-send-email-chris@chris-wilson.co.uk> <1470581141-14432-3-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6F5B26E383 for ; Mon, 8 Aug 2016 09:26:00 +0000 (UTC) Received: by mail-wm0-x242.google.com with SMTP id i5so14250471wmg.2 for ; Mon, 08 Aug 2016 02:26:00 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1470581141-14432-3-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, "Goel, Akash" List-Id: intel-gfx@lists.freedesktop.org T24gU3VuLCBBdWcgMDcsIDIwMTYgYXQgMDM6NDU6MTBQTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IFdoZW4gdXNpbmcgUkNVIGxvb2t1cCBmb3IgdGhlIHJlcXVlc3QsIGNvbW1pdCAwZWFm ZWM2ZDMyNDQgKCJkcm0vaTkxNToKPiBFbmFibGUgbG9ja2xlc3MgbG9va3VwIG9mIHJlcXVlc3Qg dHJhY2tpbmcgdmlhIFJDVSIpLCB3ZSBhY2tub3dsZWRnZSB0aGF0Cj4gd2UgbWF5IHJhY2Ugd2l0 aCBhbm90aGVyIHRocmVhZCB0aGF0IGNvdWxkIGhhdmUgcmVhbGxvY2F0ZWQgdGhlIHJlcXVlc3Qu Cj4gSW4gb3JkZXIgZm9yIHRoZSBmaXJzdCB0aHJlYWQgbm90IHRvIGJsb3cgdXAsIHRoZSBzZWNv bmQgdGhyZWFkIG11c3Qgbm90Cj4gY2xlYXIgdGhlIHJlcXVlc3QgY29tcGxldGVkIGJlZm9yZSBv dmVyd3JpdGluZyBpdC4gSW4gdGhlIFJDVSBsb29rdXAsIHdlCj4gYWxsb3cgZm9yIHRoZSBlbmdp bmUvc2Vxbm8gdG8gYmUgcmVwbGFjZWQgYnV0IHdlIGRvIG5vdCBhbGxvdyBmb3IgaXQgdG8KPiBi ZSB6ZXJvZWQuCj4gCj4gVGhlIGNob2ljZSB3ZSBtYWtlIGlzIHRvIGVpdGhlciBhZGQgZXh0cmEg Y2hlY2tpbmcgdG8gdGhlIFJDVSBsb29rdXAsIG9yCj4gZW1icmFjZSB0aGUgaW5oZXJlbnQgcmFj ZXMgKGFzIGludGVuZGVkKS4gSXQgaXMgbW9yZSBjb21wbGljYXRlZCBhcyB3ZQo+IG5lZWQgdG8g bWFudWFsbHkgY2xlYXIgZXZlcnl0aGluZyB3ZSBkZXBlbmQgdXBvbiBiZWluZyB6ZXJvIGluaXRp YWxpc2VkLAo+IGJ1dCB3ZSBiZW5lZml0IGZyb20gbm90IGVtaXRpbmcgdGhlIG1lbXNldCgpIHRv IGNsZWFyIHRoZSBlbnRpcmUKPiBmcmVxdWVudGx5IGFsbG9jYXRlZCBzdHJ1Y3R1cmUgKHRoYXQg bWVtc2V0IHR1cm5zIHVwIGluIHRocm91Z2hwdXQKPiBwcm9maWxlcykuIEFuZCBhdCB0aGUgc2Ft ZSB0aW1lLCB0aGUgbG9va3VwIHJlbWFpbnMgZmxleGlibGUgZm9yIGZ1dHVyZQo+IGFkanVzdG1l bnRzLgo+IAo+IHYyOiBPbGQgc3R5bGUgTFJDIHJlcXVpcmVzIGFub3RoZXIgdmFyaWFibGUgdG8g YmUgaW5pdGlhbGl6ZS4gKFRoZQo+IGRhbmdlciBpbmhlcmVudCBpbiBub3QgemVyb2luZyBldmVy eXRoaW5nLikKPiB2MzogcmVxdWVzdC0+YmF0Y2ggYWxzbyBuZWVkcyB0byBiZSBjbGVhcmVkCj4g Cj4gRml4ZXM6IDBlYWZlYzZkMzI0NCAoImRybS9pOTE1OiBFbmFibGUgbG9ja2xlc3MgbG9va3Vw IG9mIHJlcXVlc3QuLi4iKQo+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hy aXMtd2lsc29uLmNvLnVrPgo+IENjOiAiR29lbCwgQWthc2giIDxha2FzaC5nb2VsQGludGVsLmNv bT4KPiBDYzogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPiBDYzogSm9v bmFzIExhaHRpbmVuIDxqb29uYXMubGFodGluZW5AbGludXguaW50ZWwuY29tPgo+IC0tLQo+ICBk cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9yZXF1ZXN0LmMgfCAzNyArKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKy0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fcmVx dWVzdC5oIHwgMTEgKysrKysrKysrKwo+ICAyIGZpbGVzIGNoYW5nZWQsIDQ3IGluc2VydGlvbnMo KyksIDEgZGVsZXRpb24oLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9nZW1fcmVxdWVzdC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fcmVxdWVz dC5jCj4gaW5kZXggNmExNjYxNjQzZDNkLi5iN2ZmZGUwMDJhNjIgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fcmVxdWVzdC5jCj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9nZW1fcmVxdWVzdC5jCj4gQEAgLTM1NSw3ICszNTUsMzUgQEAgaTkxNV9n ZW1fcmVxdWVzdF9hbGxvYyhzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUsCj4gIAlpZiAo cmVxICYmIGk5MTVfZ2VtX3JlcXVlc3RfY29tcGxldGVkKHJlcSkpCj4gIAkJaTkxNV9nZW1fcmVx dWVzdF9yZXRpcmUocmVxKTsKPiAgCj4gLQlyZXEgPSBrbWVtX2NhY2hlX3phbGxvYyhkZXZfcHJp di0+cmVxdWVzdHMsIEdGUF9LRVJORUwpOwo+ICsJLyogQmV3YXJlOiBEcmFnb25zIGJlIGZseWlu ZyBvdmVyaGVhZC4KPiArCSAqCj4gKwkgKiBXZSB1c2UgUkNVIHRvIGxvb2sgdXAgcmVxdWVzdHMg aW4gZmxpZ2h0LiBUaGUgbG9va3VwcyBtYXkKPiArCSAqIHJhY2Ugd2l0aCB0aGUgcmVxdWVzdCBi ZWluZyBhbGxvY2F0ZWQgZnJvbSB0aGUgc2xhYiBmcmVlbGlzdC4KPiArCSAqIFRoYXQgaXMgdGhl IHJlcXVlc3Qgd2UgYXJlIHdyaXRpbmcgdG8gaGVyZSwgbWF5IGJlIGluIHRoZSBwcm9jZXNzCj4g KwkgKiBvZiBiZWluZyByZWFkIGJ5IF9faTkxNV9nZW1fYWN0aXZlX2dldF9yZXF1ZXN0X3JjdSgp LiBBcyBzdWNoLAo+ICsJICogd2UgaGF2ZSB0byBiZSB2ZXJ5IGNhcmVmdWwgd2hlbiBvdmVyd3Jp dGluZyB0aGUgY29udGVudHMuIER1cmluZwo+ICsJICogdGhlIFJDVSBsb29rdXAsIHdlIGNoYW5n ZSBjaGFzZSB0aGUgcmVxdWVzdC0+ZW5naW5lIHBvaW50ZXIsCj4gKwkgKiByZWFkIHRoZSByZXF1 ZXN0LT5mZW5jZS5zZXFubyBhbmQgaW5jcmVtZW50IHRoZSByZWZlcmVuY2UgY291bnQuCj4gKwkg Kgo+ICsJICogVGhlIHJlZmVyZW5jZSBjb3VudCBpcyBpbmNyZW1lbnRlZCBhdG9taWNhbGx5LiBJ ZiBpdCBpcyB6ZXJvLAo+ICsJICogdGhlIGxvb2t1cCBrbm93cyB0aGUgcmVxdWVzdCBpcyB1bmFs bG9jYXRlZCBhbmQgY29tcGxldGUuIE90aGVyd2lzZSwKPiArCSAqIGl0IGlzIGVpdGhlciBzdGls bCBpbiB1c2UsIG9yIGhhcyBiZWVuIHJlYWxsb2NhdGVkIGFuZCByZXNldAo+ICsJICogd2l0aCBm ZW5jZV9pbml0KCkuIFRoaXMgaW5jcmVtZW50IGlzIHNhZmUgZm9yIHJlbGVhc2UgYXMgd2UgY2hl Y2sKPiArCSAqIHRoYXQgdGhlIHJlcXVlc3Qgd2UgaGF2ZSBhIHJlZmVyZW5jZSB0byBhbmQgbWF0 Y2hlcyB0aGUgYWN0aXZlCj4gKwkgKiByZXF1ZXN0Lgo+ICsJICoKPiArCSAqIEJlZm9yZSB3ZSBp bmNyZW1lbnQgdGhlIHJlZmNvdW50LCB3ZSBjaGFzZSB0aGUgcmVxdWVzdC0+ZW5naW5lCj4gKwkg KiBwb2ludGVyLiBXZSBtdXN0IG5vdCBjYWxsIGttZW1fY2FjaGVfemFsbG9jKCkgb3IgZWxzZSB3 ZSBzZXQKPiArCSAqIHRoYXQgcG9pbnRlciB0byBOVUxMIGFuZCBjYXVzZSBhIGNyYXNoIGR1cmlu ZyB0aGUgbG9va3VwLiBJZgo+ICsJICogd2Ugc2VlIHRoZSByZXF1ZXN0IGlzIGNvbXBsZXRlZCAo YmFzZWQgb24gdGhlIHZhbHVlIG9mIHRoZQo+ICsJICogb2xkIGVuZ2luZSBhbmQgc2Vxbm8pLCB0 aGUgbG9va3VwIGlzIGNvbXBsZXRlIGFuZCByZXBvcnRzIE5VTEwuCj4gKwkgKiBJZiB3ZSBkZWNp ZGUgdGhlIHJlcXVlc3QgaXMgbm90IGNvbXBsZXRlZCAobmV3IGVuZ2luZSBvciBzZXFubyksCj4g KwkgKiB0aGVuIHdlIGdyYWIgYSByZWZlcmVuY2UgYW5kIGRvdWJsZSBjaGVjayB0aGF0IGl0IGlz IHN0aWxsIHRoZQo+ICsJICogYWN0aXZlIHJlcXVlc3QgLSB3aGljaCBpdCB3b24ndCBiZSBhbmQg cmVzdGFydCB0aGUgbG9va3VwLgo+ICsJICoKPiArCSAqIERvIG5vdCB1c2Uga21lbV9jYWNoZV96 YWxsb2MoKSBoZXJlIQo+ICsJICovCj4gKwlyZXEgPSBrbWVtX2NhY2hlX2FsbG9jKGRldl9wcml2 LT5yZXF1ZXN0cywgR0ZQX0tFUk5FTCk7Cj4gIAlpZiAoIXJlcSkKPiAgCQlyZXR1cm4gRVJSX1BU UigtRU5PTUVNKTsKPiAgCj4gQEAgLTM3NSw2ICs0MDMsMTMgQEAgaTkxNV9nZW1fcmVxdWVzdF9h bGxvYyhzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUsCj4gIAlyZXEtPmVuZ2luZSA9IGVu Z2luZTsKPiAgCXJlcS0+Y3R4ID0gaTkxNV9nZW1fY29udGV4dF9nZXQoY3R4KTsKClNlZSBteSBl YXJsaWVyIHJldmlldyAtIGlmIHdlIGdvIHdpdGggdGhpcyBJIHRoaW5rIHdlIHNob3VsZCBmdWxs eSBlbWJyYWNlCml0IGFuZCBub3QgY2xlYXIgYW55dGhpbmcgd2hlcmUgaXQncyBub3QgbmVlZGVk LiBPdGhlcndpc2Ugd2UgaGF2ZSBhIGZ1bm55Cm1peCBvZiBkZWZlbnNpdmUgY2xlYXJpbmcgdG8g TlVMTCBhbmQgbmVlZGluZyB0byBiZSBjYXJlZnVsLgogIAo+ICsJLyogTm8gemFsbG9jLCBtdXN0 IGNsZWFyIHdoYXQgd2UgbmVlZCBieSBoYW5kICovCj4gKwlyZXEtPnNpZ25hbGluZy53YWl0LnRz ayA9IE5VTEw7CgpUaGlzIHNob3VsZG4ndCBiZSBub24tTlVMTCBvbmNlIHRoZSByZWZjb3VudCBo YXMgZHJvcHBlZCB0byAwLiBNYXliZSBhCldBUk5fT04gaW5zdGVhZD8KCj4gKwlyZXEtPnByZXZp b3VzX2NvbnRleHQgPSBOVUxMOwoKV2UgdW5jb25kaXRpb25hbGx5IHNldCB0aGlzIGluIGFkdmFu Y2VfY29udGV4dCAodG9nZXRoZXIgd2l0aCBhIGJ1bmNoIG9mCm90aGVyIHJpbmcgc3RhdGUgdHJh Y2tlZCBpbiB0aGUgcmVxdWVzdCkuIERvIHdlIHJlYWxseSBuZWVkIHRvIHJlc2V0IHRoaXMKaGVy ZT8KCj4gKwlyZXEtPmZpbGVfcHJpdiA9IE5VTEw7CgpUaGlzIGlzIGFscmVhZHkgY2xlYXJlZCBp biBlaXRoZXIgcmVxdWVzdF9yZXRpcmUgb3IgX3JlbGVhc2UuIEFnYWluIG1heWJlCmp1c3QgYSBX QVJOX09OPy4KCj4gKwlyZXEtPmJhdGNoX29iaiA9IE5VTEw7CgpBZ3JlZWQgd2l0aCB0aGlzIG9u ZSwgd2UgbWlnaHQgcmV1c2UgdGhlIHJlcXVlc3QgZm9yIGEgbm9uLWV4ZWNidWYKcmVxdWVzdC4g QnV0IEkgdGhpbmsgd2UgYWxzbyBuZWVkIHRvIHJlc2V0IC0+cGlkIGhlcmUuCgo+ICsJcmVxLT5l bHNwX3N1Ym1pdHRlZCA9IDA7CgpOZWVkZWQsIGJ1dCBmZWVscyBtaXNwbGFjZWQgc2luY2UgaXQn cyBscmMgc3R1ZmYuIEkgdGhpbmsgaXQnZCBiZSBiZXR0ZXIKdG8gc3R1ZmYgdGhpcyBpbnRvIGlu dGVsX2xvZ2ljYWxfcmluZ19hbGxvY19yZXF1ZXN0X2V4dHJhcy4KCkFzaWRlLCB3aGlsZSByZXZp ZXdpbmcgdGhpcyBJIG5vdGljZWQgdGhhdCB0aGUgLyoqIGNvbW1lbnRzIGluCmk5MTVfZ2VtX3Jl cXVlc3QuaCBhcmVuJ3QgcmVhbGx5IGtlcm5lbGRvYyAtIHRoZSBtZXRhZGF0YSBpcyBtaXNzaW5n LiBBbHNvCndvdWxkIGJlIGdyZWF0IHRvIGluY2x1ZGUgYWxsIHRoYXQgaW50byBhIG5ldyBzZWN0 aW9uIGluIGk5MTUucnN0LgoKSSBkaWRuJ3Qgc3BvdCBhbnl0aGluZyBlbHNlIHRoYXQgY291bGQg cmVzdWx0IGluIGhhcm0gLSBidXQgSSBwcm9iYWJseQptaXNzZWQgc29tZXRoaW5nIHNvbWV3aGVy ZSA7LSkKCkknbSBoYXBweSB3aXRoIGFsbCB0aGUgY29tbWVudHMmb3RoZXIgY2hhbmdlcyBpbiB0 aGlzIHBhdGNoLgotRGFuaWVsCgo+ICsKPiAgCS8qCj4gIAkgKiBSZXNlcnZlIHNwYWNlIGluIHRo ZSByaW5nIGJ1ZmZlciBmb3IgYWxsIHRoZSBjb21tYW5kcyByZXF1aXJlZCB0bwo+ICAJICogZXZl bnR1YWxseSBlbWl0IHRoaXMgcmVxdWVzdC4gVGhpcyBpcyB0byBndWFyYW50ZWUgdGhhdCB0aGUK PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fcmVxdWVzdC5oIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fcmVxdWVzdC5oCj4gaW5kZXggYjI0NTZkZWRl M2FkLi43MjFlYjhjYmNlOWIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9nZW1fcmVxdWVzdC5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fcmVx dWVzdC5oCj4gQEAgLTUxLDYgKzUxLDEzIEBAIHN0cnVjdCBpbnRlbF9zaWduYWxfbm9kZSB7Cj4g ICAqIGVtaXNzaW9uIHRpbWUgdG8gYmUgYXNzb2NpYXRlZCB3aXRoIHRoZSByZXF1ZXN0IGZvciB0 cmFja2luZyBob3cgZmFyIGFoZWFkCj4gICAqIG9mIHRoZSBHUFUgdGhlIHN1Ym1pc3Npb24gaXMu Cj4gICAqCj4gKyAqIFdoZW4gbW9kaWZ5aW5nIHRoaXMgc3RydWN0dXJlIGJlIHZlcnkgYXdhcmUg dGhhdCB3ZSBwZXJmb3JtIGEgbG9ja2xlc3MKPiArICogUkNVIGxvb2t1cCBvZiBpdCB0aGF0IG1h eSByYWNlIGFnYWluc3QgcmVhbGxvY2F0aW9uIG9mIHRoZSBzdHJ1Y3QKPiArICogZnJvbSB0aGUg c2xhYiBmcmVlbGlzdC4gV2UgaW50ZW50aW9uYWxseSBkbyBub3QgemVybyB0aGUgc3RydWN0dXJl IG9uCj4gKyAqIGFsbG9jYXRpb24gc28gdGhhdCB0aGUgbG9va3VwIGNhbiB1c2UgdGhlIGRhbmds aW5nIHBvaW50ZXJzIChhbmQgaXMKPiArICogY29nbmlzY2VudCB0aGF0IHRob3NlIHBvaW50ZXJz IG1heSBiZSB3cm9uZykuIEluc3RlYWQsIGV2ZXJ5dGhpbmcgdGhhdAo+ICsgKiBuZWVkcyB0byBi ZSBpbml0aWFsaXNlZCBtdXN0IGJlIGRvbmUgc28gZXhwbGljaXRseS4KPiArICoKPiAgICogVGhl IHJlcXVlc3RzIGFyZSByZWZlcmVuY2UgY291bnRlZC4KPiAgICovCj4gIHN0cnVjdCBkcm1faTkx NV9nZW1fcmVxdWVzdCB7Cj4gQEAgLTQ2NSw2ICs0NzIsMTAgQEAgX19pOTE1X2dlbV9hY3RpdmVf Z2V0X3JjdShjb25zdCBzdHJ1Y3QgaTkxNV9nZW1fYWN0aXZlICphY3RpdmUpCj4gIAkgKiBqdXN0 IHJlcG9ydCB0aGUgYWN0aXZlIHRyYWNrZXIgaXMgaWRsZS4gSWYgdGhlIG5ldyByZXF1ZXN0IGlz Cj4gIAkgKiBpbmNvbXBsZXRlLCB0aGVuIHdlIGFjcXVpcmUgYSByZWZlcmVuY2Ugb24gaXQgYW5k IGNoZWNrIHRoYXQKPiAgCSAqIGl0IHJlbWFpbmVkIHRoZSBhY3RpdmUgcmVxdWVzdC4KPiArCSAq Cj4gKwkgKiBJdCBpcyB0aGVuIGltcGVyYXRpdmUgdGhhdCB3ZSBkbyBub3QgemVybyB0aGUgcmVx dWVzdCBvbgo+ICsJICogcmVhbGxvY2F0aW9uLCBzbyB0aGF0IHdlIGNhbiBjaGFzZSB0aGUgZGFu Z2xpbmcgcG9pbnRlcnMhCj4gKwkgKiBTZWUgaTkxNV9nZW1fcmVxdWVzdF9hbGxvYygpLgo+ICAJ ICovCj4gIAlkbyB7Cj4gIAkJc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXF1ZXN0Owo+ IC0tIAo+IDIuOC4xCj4gCgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50 ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==