From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH 02/33] drm/i915: Do not overwrite the
 request with zero on reallocation
Date: Mon, 8 Aug 2016 10:56:56 +0100
Message-ID: <20160808095656.GG11646@nuc-i3427.alporthouse.com>
References: <1470581141-14432-1-git-send-email-chris@chris-wilson.co.uk>
 <1470581141-14432-3-git-send-email-chris@chris-wilson.co.uk>
 <20160808092556.GY6232@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 9DBEC6E01E
 for <intel-gfx@lists.freedesktop.org>; Mon,  8 Aug 2016 09:57:08 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20160808092556.GY6232@phenom.ffwll.local>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org, "Goel, Akash" <akash.goel@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

T24gTW9uLCBBdWcgMDgsIDIwMTYgYXQgMTE6MjU6NTZBTSArMDIwMCwgRGFuaWVsIFZldHRlciB3
cm90ZToKPiBPbiBTdW4sIEF1ZyAwNywgMjAxNiBhdCAwMzo0NToxMFBNICswMTAwLCBDaHJpcyBX
aWxzb24gd3JvdGU6Cj4gPiBXaGVuIHVzaW5nIFJDVSBsb29rdXAgZm9yIHRoZSByZXF1ZXN0LCBj
b21taXQgMGVhZmVjNmQzMjQ0ICgiZHJtL2k5MTU6Cj4gPiBFbmFibGUgbG9ja2xlc3MgbG9va3Vw
IG9mIHJlcXVlc3QgdHJhY2tpbmcgdmlhIFJDVSIpLCB3ZSBhY2tub3dsZWRnZSB0aGF0Cj4gPiB3
ZSBtYXkgcmFjZSB3aXRoIGFub3RoZXIgdGhyZWFkIHRoYXQgY291bGQgaGF2ZSByZWFsbG9jYXRl
ZCB0aGUgcmVxdWVzdC4KPiA+IEluIG9yZGVyIGZvciB0aGUgZmlyc3QgdGhyZWFkIG5vdCB0byBi
bG93IHVwLCB0aGUgc2Vjb25kIHRocmVhZCBtdXN0IG5vdAo+ID4gY2xlYXIgdGhlIHJlcXVlc3Qg
Y29tcGxldGVkIGJlZm9yZSBvdmVyd3JpdGluZyBpdC4gSW4gdGhlIFJDVSBsb29rdXAsIHdlCj4g
PiBhbGxvdyBmb3IgdGhlIGVuZ2luZS9zZXFubyB0byBiZSByZXBsYWNlZCBidXQgd2UgZG8gbm90
IGFsbG93IGZvciBpdCB0bwo+ID4gYmUgemVyb2VkLgo+ID4gCj4gPiBUaGUgY2hvaWNlIHdlIG1h
a2UgaXMgdG8gZWl0aGVyIGFkZCBleHRyYSBjaGVja2luZyB0byB0aGUgUkNVIGxvb2t1cCwgb3IK
PiA+IGVtYnJhY2UgdGhlIGluaGVyZW50IHJhY2VzIChhcyBpbnRlbmRlZCkuIEl0IGlzIG1vcmUg
Y29tcGxpY2F0ZWQgYXMgd2UKPiA+IG5lZWQgdG8gbWFudWFsbHkgY2xlYXIgZXZlcnl0aGluZyB3
ZSBkZXBlbmQgdXBvbiBiZWluZyB6ZXJvIGluaXRpYWxpc2VkLAo+ID4gYnV0IHdlIGJlbmVmaXQg
ZnJvbSBub3QgZW1pdGluZyB0aGUgbWVtc2V0KCkgdG8gY2xlYXIgdGhlIGVudGlyZQo+ID4gZnJl
cXVlbnRseSBhbGxvY2F0ZWQgc3RydWN0dXJlICh0aGF0IG1lbXNldCB0dXJucyB1cCBpbiB0aHJv
dWdocHV0Cj4gPiBwcm9maWxlcykuIEFuZCBhdCB0aGUgc2FtZSB0aW1lLCB0aGUgbG9va3VwIHJl
bWFpbnMgZmxleGlibGUgZm9yIGZ1dHVyZQo+ID4gYWRqdXN0bWVudHMuCj4gPiAKPiA+IHYyOiBP
bGQgc3R5bGUgTFJDIHJlcXVpcmVzIGFub3RoZXIgdmFyaWFibGUgdG8gYmUgaW5pdGlhbGl6ZS4g
KFRoZQo+ID4gZGFuZ2VyIGluaGVyZW50IGluIG5vdCB6ZXJvaW5nIGV2ZXJ5dGhpbmcuKQo+ID4g
djM6IHJlcXVlc3QtPmJhdGNoIGFsc28gbmVlZHMgdG8gYmUgY2xlYXJlZAo+ID4gCj4gPiBGaXhl
czogMGVhZmVjNmQzMjQ0ICgiZHJtL2k5MTU6IEVuYWJsZSBsb2NrbGVzcyBsb29rdXAgb2YgcmVx
dWVzdC4uLiIpCj4gPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdp
bHNvbi5jby51az4KPiA+IENjOiAiR29lbCwgQWthc2giIDxha2FzaC5nb2VsQGludGVsLmNvbT4K
PiA+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+ID4gQ2M6IEpv
b25hcyBMYWh0aW5lbiA8am9vbmFzLmxhaHRpbmVuQGxpbnV4LmludGVsLmNvbT4KPiA+IC0tLQo+
ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX3JlcXVlc3QuYyB8IDM3ICsrKysrKysr
KysrKysrKysrKysrKysrKysrKysrKysrLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf
Z2VtX3JlcXVlc3QuaCB8IDExICsrKysrKysrKysKPiA+ICAyIGZpbGVzIGNoYW5nZWQsIDQ3IGlu
c2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv
Z3B1L2RybS9pOTE1L2k5MTVfZ2VtX3JlcXVlc3QuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5
MTVfZ2VtX3JlcXVlc3QuYwo+ID4gaW5kZXggNmExNjYxNjQzZDNkLi5iN2ZmZGUwMDJhNjIgMTAw
NjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9yZXF1ZXN0LmMKPiA+
ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX3JlcXVlc3QuYwo+ID4gQEAgLTM1
NSw3ICszNTUsMzUgQEAgaTkxNV9nZW1fcmVxdWVzdF9hbGxvYyhzdHJ1Y3QgaW50ZWxfZW5naW5l
X2NzICplbmdpbmUsCj4gPiAgCWlmIChyZXEgJiYgaTkxNV9nZW1fcmVxdWVzdF9jb21wbGV0ZWQo
cmVxKSkKPiA+ICAJCWk5MTVfZ2VtX3JlcXVlc3RfcmV0aXJlKHJlcSk7Cj4gPiAgCj4gPiAtCXJl
cSA9IGttZW1fY2FjaGVfemFsbG9jKGRldl9wcml2LT5yZXF1ZXN0cywgR0ZQX0tFUk5FTCk7Cj4g
PiArCS8qIEJld2FyZTogRHJhZ29ucyBiZSBmbHlpbmcgb3ZlcmhlYWQuCj4gPiArCSAqCj4gPiAr
CSAqIFdlIHVzZSBSQ1UgdG8gbG9vayB1cCByZXF1ZXN0cyBpbiBmbGlnaHQuIFRoZSBsb29rdXBz
IG1heQo+ID4gKwkgKiByYWNlIHdpdGggdGhlIHJlcXVlc3QgYmVpbmcgYWxsb2NhdGVkIGZyb20g
dGhlIHNsYWIgZnJlZWxpc3QuCj4gPiArCSAqIFRoYXQgaXMgdGhlIHJlcXVlc3Qgd2UgYXJlIHdy
aXRpbmcgdG8gaGVyZSwgbWF5IGJlIGluIHRoZSBwcm9jZXNzCj4gPiArCSAqIG9mIGJlaW5nIHJl
YWQgYnkgX19pOTE1X2dlbV9hY3RpdmVfZ2V0X3JlcXVlc3RfcmN1KCkuIEFzIHN1Y2gsCj4gPiAr
CSAqIHdlIGhhdmUgdG8gYmUgdmVyeSBjYXJlZnVsIHdoZW4gb3ZlcndyaXRpbmcgdGhlIGNvbnRl
bnRzLiBEdXJpbmcKPiA+ICsJICogdGhlIFJDVSBsb29rdXAsIHdlIGNoYW5nZSBjaGFzZSB0aGUg
cmVxdWVzdC0+ZW5naW5lIHBvaW50ZXIsCj4gPiArCSAqIHJlYWQgdGhlIHJlcXVlc3QtPmZlbmNl
LnNlcW5vIGFuZCBpbmNyZW1lbnQgdGhlIHJlZmVyZW5jZSBjb3VudC4KPiA+ICsJICoKPiA+ICsJ
ICogVGhlIHJlZmVyZW5jZSBjb3VudCBpcyBpbmNyZW1lbnRlZCBhdG9taWNhbGx5LiBJZiBpdCBp
cyB6ZXJvLAo+ID4gKwkgKiB0aGUgbG9va3VwIGtub3dzIHRoZSByZXF1ZXN0IGlzIHVuYWxsb2Nh
dGVkIGFuZCBjb21wbGV0ZS4gT3RoZXJ3aXNlLAo+ID4gKwkgKiBpdCBpcyBlaXRoZXIgc3RpbGwg
aW4gdXNlLCBvciBoYXMgYmVlbiByZWFsbG9jYXRlZCBhbmQgcmVzZXQKPiA+ICsJICogd2l0aCBm
ZW5jZV9pbml0KCkuIFRoaXMgaW5jcmVtZW50IGlzIHNhZmUgZm9yIHJlbGVhc2UgYXMgd2UgY2hl
Y2sKPiA+ICsJICogdGhhdCB0aGUgcmVxdWVzdCB3ZSBoYXZlIGEgcmVmZXJlbmNlIHRvIGFuZCBt
YXRjaGVzIHRoZSBhY3RpdmUKPiA+ICsJICogcmVxdWVzdC4KPiA+ICsJICoKPiA+ICsJICogQmVm
b3JlIHdlIGluY3JlbWVudCB0aGUgcmVmY291bnQsIHdlIGNoYXNlIHRoZSByZXF1ZXN0LT5lbmdp
bmUKPiA+ICsJICogcG9pbnRlci4gV2UgbXVzdCBub3QgY2FsbCBrbWVtX2NhY2hlX3phbGxvYygp
IG9yIGVsc2Ugd2Ugc2V0Cj4gPiArCSAqIHRoYXQgcG9pbnRlciB0byBOVUxMIGFuZCBjYXVzZSBh
IGNyYXNoIGR1cmluZyB0aGUgbG9va3VwLiBJZgo+ID4gKwkgKiB3ZSBzZWUgdGhlIHJlcXVlc3Qg
aXMgY29tcGxldGVkIChiYXNlZCBvbiB0aGUgdmFsdWUgb2YgdGhlCj4gPiArCSAqIG9sZCBlbmdp
bmUgYW5kIHNlcW5vKSwgdGhlIGxvb2t1cCBpcyBjb21wbGV0ZSBhbmQgcmVwb3J0cyBOVUxMLgo+
ID4gKwkgKiBJZiB3ZSBkZWNpZGUgdGhlIHJlcXVlc3QgaXMgbm90IGNvbXBsZXRlZCAobmV3IGVu
Z2luZSBvciBzZXFubyksCj4gPiArCSAqIHRoZW4gd2UgZ3JhYiBhIHJlZmVyZW5jZSBhbmQgZG91
YmxlIGNoZWNrIHRoYXQgaXQgaXMgc3RpbGwgdGhlCj4gPiArCSAqIGFjdGl2ZSByZXF1ZXN0IC0g
d2hpY2ggaXQgd29uJ3QgYmUgYW5kIHJlc3RhcnQgdGhlIGxvb2t1cC4KPiA+ICsJICoKPiA+ICsJ
ICogRG8gbm90IHVzZSBrbWVtX2NhY2hlX3phbGxvYygpIGhlcmUhCj4gPiArCSAqLwo+ID4gKwly
ZXEgPSBrbWVtX2NhY2hlX2FsbG9jKGRldl9wcml2LT5yZXF1ZXN0cywgR0ZQX0tFUk5FTCk7Cj4g
PiAgCWlmICghcmVxKQo+ID4gIAkJcmV0dXJuIEVSUl9QVFIoLUVOT01FTSk7Cj4gPiAgCj4gPiBA
QCAtMzc1LDYgKzQwMywxMyBAQCBpOTE1X2dlbV9yZXF1ZXN0X2FsbG9jKHN0cnVjdCBpbnRlbF9l
bmdpbmVfY3MgKmVuZ2luZSwKPiA+ICAJcmVxLT5lbmdpbmUgPSBlbmdpbmU7Cj4gPiAgCXJlcS0+
Y3R4ID0gaTkxNV9nZW1fY29udGV4dF9nZXQoY3R4KTsKPiAKPiBTZWUgbXkgZWFybGllciByZXZp
ZXcgLSBpZiB3ZSBnbyB3aXRoIHRoaXMgSSB0aGluayB3ZSBzaG91bGQgZnVsbHkgZW1icmFjZQo+
IGl0IGFuZCBub3QgY2xlYXIgYW55dGhpbmcgd2hlcmUgaXQncyBub3QgbmVlZGVkLiBPdGhlcndp
c2Ugd2UgaGF2ZSBhIGZ1bm55Cj4gbWl4IG9mIGRlZmVuc2l2ZSBjbGVhcmluZyB0byBOVUxMIGFu
ZCBuZWVkaW5nIHRvIGJlIGNhcmVmdWwuCj4gICAKPiA+ICsJLyogTm8gemFsbG9jLCBtdXN0IGNs
ZWFyIHdoYXQgd2UgbmVlZCBieSBoYW5kICovCj4gPiArCXJlcS0+c2lnbmFsaW5nLndhaXQudHNr
ID0gTlVMTDsKPiAKPiBUaGlzIHNob3VsZG4ndCBiZSBub24tTlVMTCBvbmNlIHRoZSByZWZjb3Vu
dCBoYXMgZHJvcHBlZCB0byAwLiBNYXliZSBhCj4gV0FSTl9PTiBpbnN0ZWFkPwoKVGhpcyBpcyBq
dXN0IGZyb20gb2xkZXIgY29kZSB3aGVyZSB3ZSBoYWQgdGhlIGlmICh3YWl0LnRzayAhPSBOVUxM
KQpza2lwLgoKPiA+ICsJcmVxLT5wcmV2aW91c19jb250ZXh0ID0gTlVMTDsKPiAKPiBXZSB1bmNv
bmRpdGlvbmFsbHkgc2V0IHRoaXMgaW4gYWR2YW5jZV9jb250ZXh0ICh0b2dldGhlciB3aXRoIGEg
YnVuY2ggb2YKPiBvdGhlciByaW5nIHN0YXRlIHRyYWNrZWQgaW4gdGhlIHJlcXVlc3QpLiBEbyB3
ZSByZWFsbHkgbmVlZCB0byByZXNldCB0aGlzCj4gaGVyZT8KClByZXZpb3VzX2NvbnRleHQgbWF5
IGJlIHVzZWQgdW5zZXQgKGFsb25nIGEgZmFpbHVyZSBwYXRoKSwgc28gcmVxdWlyZXMKaW5pdGlh
bGlzaW5nLgoKPiA+ICsJcmVxLT5maWxlX3ByaXYgPSBOVUxMOwo+IAo+IFRoaXMgaXMgYWxyZWFk
eSBjbGVhcmVkIGluIGVpdGhlciByZXF1ZXN0X3JldGlyZSBvciBfcmVsZWFzZS4gQWdhaW4gbWF5
YmUKPiBqdXN0IGEgV0FSTl9PTj8uCgpCdXQgd2UgbmV2ZXIgY2xlYXIgaXQgZmlyc3QsIHNvIGl0
IG1heSBiZSBwb2lzb25lZC4KCj4gPiArCXJlcS0+YmF0Y2hfb2JqID0gTlVMTDsKPiAKPiBBZ3Jl
ZWQgd2l0aCB0aGlzIG9uZSwgd2UgbWlnaHQgcmV1c2UgdGhlIHJlcXVlc3QgZm9yIGEgbm9uLWV4
ZWNidWYKPiByZXF1ZXN0LiBCdXQgSSB0aGluayB3ZSBhbHNvIG5lZWQgdG8gcmVzZXQgLT5waWQg
aGVyZS4KCldoYXQgcGlkPyBHYWguIChEb24ndCBoYXZlIHBpZCBoZXJlIGluIG15IHRyZWUuLi4p
Cgo+ID4gKwlyZXEtPmVsc3Bfc3VibWl0dGVkID0gMDsKPiAKPiBOZWVkZWQsIGJ1dCBmZWVscyBt
aXNwbGFjZWQgc2luY2UgaXQncyBscmMgc3R1ZmYuIEkgdGhpbmsgaXQnZCBiZSBiZXR0ZXIKPiB0
byBzdHVmZiB0aGlzIGludG8gaW50ZWxfbG9naWNhbF9yaW5nX2FsbG9jX3JlcXVlc3RfZXh0cmFz
LgoKTm8gbmVlZCBmb3IgdGhhdCBleHRyYSBjb21wbGV4aXR5LCBpdCBpcyB0byBiZSByZW1vdmVk
LgotQ2hyaXMKCi0tIApDaHJpcyBXaWxzb24sIEludGVsIE9wZW4gU291cmNlIFRlY2hub2xvZ3kg
Q2VudHJlCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCklu
dGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw
czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=