From: Stefan Hajnoczi <stefanha@gmail.com>
To: Peter Lieven <pl@kamp.de>
Cc: qemu-devel@nongnu.org, kwolf@redhat.com,
peter.maydell@linaro.org, mst@redhat.com, armbru@redhat.com,
dgilbert@redhat.com, mreitz@redhat.com, pbonzini@redhat.com,
rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH V5 6/6] coroutine: reduce stack size to 64kB
Date: Mon, 8 Aug 2016 11:45:29 +0100 [thread overview]
Message-ID: <20160808104529.GG30105@stefanha-x1.localdomain> (raw)
In-Reply-To: <1468340586-19304-7-git-send-email-pl@kamp.de>
[-- Attachment #1: Type: text/plain, Size: 663 bytes --]
On Tue, Jul 12, 2016 at 06:23:06PM +0200, Peter Lieven wrote:
> evaluation with the recently introduced maximum stack usage monitoring revealed
> that the actual used stack size was never above 4kB so allocating 1MB stack
> for each coroutine is a lot of wasted memory. So reduce the stack size to
> 64kB which should still give enough head room. The guard page added
> in qemu_alloc_stack will catch a potential stack overflow introduced
> by this commit.
>
> Signed-off-by: Peter Lieven <pl@kamp.de>
> ---
> include/qemu/coroutine_int.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-08-08 10:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-12 16:23 [Qemu-devel] [PATCH V5 0/6] Peter Lieven
2016-07-12 16:23 ` [Qemu-devel] [PATCH V5 1/6] oslib-posix: add helpers for stack alloc and free Peter Lieven
2016-07-12 17:30 ` Eric Blake
2016-08-08 10:37 ` Stefan Hajnoczi
2016-08-08 18:29 ` Peter Lieven
2016-08-11 9:05 ` Stefan Hajnoczi
2016-07-12 16:23 ` [Qemu-devel] [PATCH V5 2/6] coroutine: add a macro for the coroutine stack size Peter Lieven
2016-08-08 10:38 ` Stefan Hajnoczi
2016-08-08 10:38 ` Stefan Hajnoczi
2016-07-12 16:23 ` [Qemu-devel] [PATCH V5 3/6] coroutine-ucontext: use helper for allocating stack memory Peter Lieven
2016-08-08 10:39 ` Stefan Hajnoczi
2016-07-12 16:23 ` [Qemu-devel] [PATCH V5 4/6] coroutine-sigaltstack: " Peter Lieven
2016-08-08 10:39 ` Stefan Hajnoczi
2016-07-12 16:23 ` [Qemu-devel] [PATCH V5 5/6] oslib-posix: add a configure switch to debug stack usage Peter Lieven
2016-08-08 10:45 ` Stefan Hajnoczi
2016-07-12 16:23 ` [Qemu-devel] [PATCH V5 6/6] coroutine: reduce stack size to 64kB Peter Lieven
2016-07-12 17:39 ` Eric Blake
2016-08-08 10:45 ` Stefan Hajnoczi [this message]
2016-07-27 7:27 ` [Qemu-devel] [PATCH V5 0/6] coroutine: mmap stack memory and stack size Peter Lieven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160808104529.GG30105@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.