From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51382) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bWyzC-0001cr-GA for qemu-devel@nongnu.org; Tue, 09 Aug 2016 00:49:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bWyzB-0007aH-GD for qemu-devel@nongnu.org; Tue, 09 Aug 2016 00:49:54 -0400 Date: Tue, 9 Aug 2016 12:42:42 +0800 From: Fam Zheng Message-ID: <20160809044242.GD16125@al.usersys.redhat.com> References: <1470662013-19785-1-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v7 00/20] block: Image locking series for 2.8 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, qemu-block@nongnu.org, armbru@redhat.com, jcody@redhat.com, rjones@redhat.com, stefanha@redhat.com, den@openvz.org, pbonzini@redhat.com, mreitz@redhat.com, jsnow@redhat.com On Mon, 08/08 06:59, no-reply@ec2-52-6-146-230.compute-1.amazonaws.com wrot= e: > Checking PATCH 3/20: block: Add and parse "lock-mode" option for image lo= cking... > ERROR: do not use assignment in if condition > #80: FILE: blockdev.c:548: > + if ((buf =3D qemu_opt_get(opts, BDRV_OPT_LOCK_MODE)) !=3D NULL) { >=20 > total: 1 errors, 0 warnings, 86 lines checked I intentionally ignored this to be consistent with the several other occasi= ons in this function. >=20 > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. >=20 > Checking PATCH 4/20: block: Introduce image file locking... > Checking PATCH 5/20: osdep: Add qemu_lock_fd and qemu_unlock_fd... > Checking PATCH 6/20: raw-posix: Add image locking support... > Checking PATCH 7/20: qemu-io: Add "-L" option for BDRV_O_NO_LOCK... > Checking PATCH 8/20: qemu-img: Add "-L" option to sub commands... > Checking PATCH 9/20: qemu-img: Update documentation of "-L" option... > Checking PATCH 10/20: qemu-nbd: Add "--no-lock/-L" option... > Checking PATCH 11/20: block: Don't lock drive-backup target image in none= mode... > Checking PATCH 12/20: qemu-iotests: 046: Move version detection out from = verify_io... > Checking PATCH 13/20: qemu-iotests: Wait for QEMU processes before checki= ng image in 091... > Checking PATCH 14/20: qemu-iotests: 030: Disable image locking when check= ing test image... > Checking PATCH 15/20: iotests: 087: Disable image locking in cases where = file is shared... > Checking PATCH 16/20: iotests: 130: Check image info locklessly... > ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8 > #47: FILE: tests/qemu-iotests/130.out:13: > +(qemu) q=1B[K > ^ >=20 > ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8 > #55: FILE: tests/qemu-iotests/130.out:20: > +(qemu) q=1B[K > ^ And this one seems harmless. Fam