From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 02/33] drm/i915: Do not overwrite the
 request with zero on reallocation
Date: Tue, 9 Aug 2016 08:32:35 +0200
Message-ID: <20160809063235.GI6232@phenom.ffwll.local>
References: <1470581141-14432-1-git-send-email-chris@chris-wilson.co.uk>
 <1470581141-14432-3-git-send-email-chris@chris-wilson.co.uk>
 <20160808092556.GY6232@phenom.ffwll.local>
 <20160808095656.GG11646@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com
 [IPv6:2a00:1450:400c:c09::243])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 03F5A6E1CA
 for <intel-gfx@lists.freedesktop.org>; Tue,  9 Aug 2016 06:32:40 +0000 (UTC)
Received: by mail-wm0-x243.google.com with SMTP id o80so1153323wme.0
 for <intel-gfx@lists.freedesktop.org>; Mon, 08 Aug 2016 23:32:39 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20160808095656.GG11646@nuc-i3427.alporthouse.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, Daniel Vetter <daniel@ffwll.ch>, intel-gfx@lists.freedesktop.org, joonas.lahtinen@linux.intel.com, "Goel, Akash" <akash.goel@intel.com>, Daniel Vetter <daniel.vetter@ffwll.ch>
List-Id: intel-gfx@lists.freedesktop.org

T24gTW9uLCBBdWcgMDgsIDIwMTYgYXQgMTA6NTY6NTZBTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy
b3RlOgo+IE9uIE1vbiwgQXVnIDA4LCAyMDE2IGF0IDExOjI1OjU2QU0gKzAyMDAsIERhbmllbCBW
ZXR0ZXIgd3JvdGU6Cj4gPiBPbiBTdW4sIEF1ZyAwNywgMjAxNiBhdCAwMzo0NToxMFBNICswMTAw
LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4gPiA+IFdoZW4gdXNpbmcgUkNVIGxvb2t1cCBmb3IgdGhl
IHJlcXVlc3QsIGNvbW1pdCAwZWFmZWM2ZDMyNDQgKCJkcm0vaTkxNToKPiA+ID4gRW5hYmxlIGxv
Y2tsZXNzIGxvb2t1cCBvZiByZXF1ZXN0IHRyYWNraW5nIHZpYSBSQ1UiKSwgd2UgYWNrbm93bGVk
Z2UgdGhhdAo+ID4gPiB3ZSBtYXkgcmFjZSB3aXRoIGFub3RoZXIgdGhyZWFkIHRoYXQgY291bGQg
aGF2ZSByZWFsbG9jYXRlZCB0aGUgcmVxdWVzdC4KPiA+ID4gSW4gb3JkZXIgZm9yIHRoZSBmaXJz
dCB0aHJlYWQgbm90IHRvIGJsb3cgdXAsIHRoZSBzZWNvbmQgdGhyZWFkIG11c3Qgbm90Cj4gPiA+
IGNsZWFyIHRoZSByZXF1ZXN0IGNvbXBsZXRlZCBiZWZvcmUgb3ZlcndyaXRpbmcgaXQuIEluIHRo
ZSBSQ1UgbG9va3VwLCB3ZQo+ID4gPiBhbGxvdyBmb3IgdGhlIGVuZ2luZS9zZXFubyB0byBiZSBy
ZXBsYWNlZCBidXQgd2UgZG8gbm90IGFsbG93IGZvciBpdCB0bwo+ID4gPiBiZSB6ZXJvZWQuCj4g
PiA+IAo+ID4gPiBUaGUgY2hvaWNlIHdlIG1ha2UgaXMgdG8gZWl0aGVyIGFkZCBleHRyYSBjaGVj
a2luZyB0byB0aGUgUkNVIGxvb2t1cCwgb3IKPiA+ID4gZW1icmFjZSB0aGUgaW5oZXJlbnQgcmFj
ZXMgKGFzIGludGVuZGVkKS4gSXQgaXMgbW9yZSBjb21wbGljYXRlZCBhcyB3ZQo+ID4gPiBuZWVk
IHRvIG1hbnVhbGx5IGNsZWFyIGV2ZXJ5dGhpbmcgd2UgZGVwZW5kIHVwb24gYmVpbmcgemVybyBp
bml0aWFsaXNlZCwKPiA+ID4gYnV0IHdlIGJlbmVmaXQgZnJvbSBub3QgZW1pdGluZyB0aGUgbWVt
c2V0KCkgdG8gY2xlYXIgdGhlIGVudGlyZQo+ID4gPiBmcmVxdWVudGx5IGFsbG9jYXRlZCBzdHJ1
Y3R1cmUgKHRoYXQgbWVtc2V0IHR1cm5zIHVwIGluIHRocm91Z2hwdXQKPiA+ID4gcHJvZmlsZXMp
LiBBbmQgYXQgdGhlIHNhbWUgdGltZSwgdGhlIGxvb2t1cCByZW1haW5zIGZsZXhpYmxlIGZvciBm
dXR1cmUKPiA+ID4gYWRqdXN0bWVudHMuCj4gPiA+IAo+ID4gPiB2MjogT2xkIHN0eWxlIExSQyBy
ZXF1aXJlcyBhbm90aGVyIHZhcmlhYmxlIHRvIGJlIGluaXRpYWxpemUuIChUaGUKPiA+ID4gZGFu
Z2VyIGluaGVyZW50IGluIG5vdCB6ZXJvaW5nIGV2ZXJ5dGhpbmcuKQo+ID4gPiB2MzogcmVxdWVz
dC0+YmF0Y2ggYWxzbyBuZWVkcyB0byBiZSBjbGVhcmVkCj4gPiA+IAo+ID4gPiBGaXhlczogMGVh
ZmVjNmQzMjQ0ICgiZHJtL2k5MTU6IEVuYWJsZSBsb2NrbGVzcyBsb29rdXAgb2YgcmVxdWVzdC4u
LiIpCj4gPiA+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29u
LmNvLnVrPgo+ID4gPiBDYzogIkdvZWwsIEFrYXNoIiA8YWthc2guZ29lbEBpbnRlbC5jb20+Cj4g
PiA+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+ID4gPiBDYzog
Sm9vbmFzIExhaHRpbmVuIDxqb29uYXMubGFodGluZW5AbGludXguaW50ZWwuY29tPgo+ID4gPiAt
LS0KPiA+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX3JlcXVlc3QuYyB8IDM3ICsr
KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLQo+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2k5
MTUvaTkxNV9nZW1fcmVxdWVzdC5oIHwgMTEgKysrKysrKysrKwo+ID4gPiAgMiBmaWxlcyBjaGFu
Z2VkLCA0NyBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4gPiA+IAo+ID4gPiBkaWZmIC0t
Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fcmVxdWVzdC5jIGIvZHJpdmVycy9n
cHUvZHJtL2k5MTUvaTkxNV9nZW1fcmVxdWVzdC5jCj4gPiA+IGluZGV4IDZhMTY2MTY0M2QzZC4u
YjdmZmRlMDAyYTYyIDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1
X2dlbV9yZXF1ZXN0LmMKPiA+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1f
cmVxdWVzdC5jCj4gPiA+IEBAIC0zNTUsNyArMzU1LDM1IEBAIGk5MTVfZ2VtX3JlcXVlc3RfYWxs
b2Moc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lLAo+ID4gPiAgCWlmIChyZXEgJiYgaTkx
NV9nZW1fcmVxdWVzdF9jb21wbGV0ZWQocmVxKSkKPiA+ID4gIAkJaTkxNV9nZW1fcmVxdWVzdF9y
ZXRpcmUocmVxKTsKPiA+ID4gIAo+ID4gPiAtCXJlcSA9IGttZW1fY2FjaGVfemFsbG9jKGRldl9w
cml2LT5yZXF1ZXN0cywgR0ZQX0tFUk5FTCk7Cj4gPiA+ICsJLyogQmV3YXJlOiBEcmFnb25zIGJl
IGZseWluZyBvdmVyaGVhZC4KPiA+ID4gKwkgKgo+ID4gPiArCSAqIFdlIHVzZSBSQ1UgdG8gbG9v
ayB1cCByZXF1ZXN0cyBpbiBmbGlnaHQuIFRoZSBsb29rdXBzIG1heQo+ID4gPiArCSAqIHJhY2Ug
d2l0aCB0aGUgcmVxdWVzdCBiZWluZyBhbGxvY2F0ZWQgZnJvbSB0aGUgc2xhYiBmcmVlbGlzdC4K
PiA+ID4gKwkgKiBUaGF0IGlzIHRoZSByZXF1ZXN0IHdlIGFyZSB3cml0aW5nIHRvIGhlcmUsIG1h
eSBiZSBpbiB0aGUgcHJvY2Vzcwo+ID4gPiArCSAqIG9mIGJlaW5nIHJlYWQgYnkgX19pOTE1X2dl
bV9hY3RpdmVfZ2V0X3JlcXVlc3RfcmN1KCkuIEFzIHN1Y2gsCj4gPiA+ICsJICogd2UgaGF2ZSB0
byBiZSB2ZXJ5IGNhcmVmdWwgd2hlbiBvdmVyd3JpdGluZyB0aGUgY29udGVudHMuIER1cmluZwo+
ID4gPiArCSAqIHRoZSBSQ1UgbG9va3VwLCB3ZSBjaGFuZ2UgY2hhc2UgdGhlIHJlcXVlc3QtPmVu
Z2luZSBwb2ludGVyLAo+ID4gPiArCSAqIHJlYWQgdGhlIHJlcXVlc3QtPmZlbmNlLnNlcW5vIGFu
ZCBpbmNyZW1lbnQgdGhlIHJlZmVyZW5jZSBjb3VudC4KPiA+ID4gKwkgKgo+ID4gPiArCSAqIFRo
ZSByZWZlcmVuY2UgY291bnQgaXMgaW5jcmVtZW50ZWQgYXRvbWljYWxseS4gSWYgaXQgaXMgemVy
bywKPiA+ID4gKwkgKiB0aGUgbG9va3VwIGtub3dzIHRoZSByZXF1ZXN0IGlzIHVuYWxsb2NhdGVk
IGFuZCBjb21wbGV0ZS4gT3RoZXJ3aXNlLAo+ID4gPiArCSAqIGl0IGlzIGVpdGhlciBzdGlsbCBp
biB1c2UsIG9yIGhhcyBiZWVuIHJlYWxsb2NhdGVkIGFuZCByZXNldAo+ID4gPiArCSAqIHdpdGgg
ZmVuY2VfaW5pdCgpLiBUaGlzIGluY3JlbWVudCBpcyBzYWZlIGZvciByZWxlYXNlIGFzIHdlIGNo
ZWNrCj4gPiA+ICsJICogdGhhdCB0aGUgcmVxdWVzdCB3ZSBoYXZlIGEgcmVmZXJlbmNlIHRvIGFu
ZCBtYXRjaGVzIHRoZSBhY3RpdmUKPiA+ID4gKwkgKiByZXF1ZXN0Lgo+ID4gPiArCSAqCj4gPiA+
ICsJICogQmVmb3JlIHdlIGluY3JlbWVudCB0aGUgcmVmY291bnQsIHdlIGNoYXNlIHRoZSByZXF1
ZXN0LT5lbmdpbmUKPiA+ID4gKwkgKiBwb2ludGVyLiBXZSBtdXN0IG5vdCBjYWxsIGttZW1fY2Fj
aGVfemFsbG9jKCkgb3IgZWxzZSB3ZSBzZXQKPiA+ID4gKwkgKiB0aGF0IHBvaW50ZXIgdG8gTlVM
TCBhbmQgY2F1c2UgYSBjcmFzaCBkdXJpbmcgdGhlIGxvb2t1cC4gSWYKPiA+ID4gKwkgKiB3ZSBz
ZWUgdGhlIHJlcXVlc3QgaXMgY29tcGxldGVkIChiYXNlZCBvbiB0aGUgdmFsdWUgb2YgdGhlCj4g
PiA+ICsJICogb2xkIGVuZ2luZSBhbmQgc2Vxbm8pLCB0aGUgbG9va3VwIGlzIGNvbXBsZXRlIGFu
ZCByZXBvcnRzIE5VTEwuCj4gPiA+ICsJICogSWYgd2UgZGVjaWRlIHRoZSByZXF1ZXN0IGlzIG5v
dCBjb21wbGV0ZWQgKG5ldyBlbmdpbmUgb3Igc2Vxbm8pLAo+ID4gPiArCSAqIHRoZW4gd2UgZ3Jh
YiBhIHJlZmVyZW5jZSBhbmQgZG91YmxlIGNoZWNrIHRoYXQgaXQgaXMgc3RpbGwgdGhlCj4gPiA+
ICsJICogYWN0aXZlIHJlcXVlc3QgLSB3aGljaCBpdCB3b24ndCBiZSBhbmQgcmVzdGFydCB0aGUg
bG9va3VwLgo+ID4gPiArCSAqCj4gPiA+ICsJICogRG8gbm90IHVzZSBrbWVtX2NhY2hlX3phbGxv
YygpIGhlcmUhCj4gPiA+ICsJICovCj4gPiA+ICsJcmVxID0ga21lbV9jYWNoZV9hbGxvYyhkZXZf
cHJpdi0+cmVxdWVzdHMsIEdGUF9LRVJORUwpOwo+ID4gPiAgCWlmICghcmVxKQo+ID4gPiAgCQly
ZXR1cm4gRVJSX1BUUigtRU5PTUVNKTsKPiA+ID4gIAo+ID4gPiBAQCAtMzc1LDYgKzQwMywxMyBA
QCBpOTE1X2dlbV9yZXF1ZXN0X2FsbG9jKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSwK
PiA+ID4gIAlyZXEtPmVuZ2luZSA9IGVuZ2luZTsKPiA+ID4gIAlyZXEtPmN0eCA9IGk5MTVfZ2Vt
X2NvbnRleHRfZ2V0KGN0eCk7Cj4gPiAKPiA+IFNlZSBteSBlYXJsaWVyIHJldmlldyAtIGlmIHdl
IGdvIHdpdGggdGhpcyBJIHRoaW5rIHdlIHNob3VsZCBmdWxseSBlbWJyYWNlCj4gPiBpdCBhbmQg
bm90IGNsZWFyIGFueXRoaW5nIHdoZXJlIGl0J3Mgbm90IG5lZWRlZC4gT3RoZXJ3aXNlIHdlIGhh
dmUgYSBmdW5ueQo+ID4gbWl4IG9mIGRlZmVuc2l2ZSBjbGVhcmluZyB0byBOVUxMIGFuZCBuZWVk
aW5nIHRvIGJlIGNhcmVmdWwuCj4gPiAgIAo+ID4gPiArCS8qIE5vIHphbGxvYywgbXVzdCBjbGVh
ciB3aGF0IHdlIG5lZWQgYnkgaGFuZCAqLwo+ID4gPiArCXJlcS0+c2lnbmFsaW5nLndhaXQudHNr
ID0gTlVMTDsKPiA+IAo+ID4gVGhpcyBzaG91bGRuJ3QgYmUgbm9uLU5VTEwgb25jZSB0aGUgcmVm
Y291bnQgaGFzIGRyb3BwZWQgdG8gMC4gTWF5YmUgYQo+ID4gV0FSTl9PTiBpbnN0ZWFkPwo+IAo+
IFRoaXMgaXMganVzdCBmcm9tIG9sZGVyIGNvZGUgd2hlcmUgd2UgaGFkIHRoZSBpZiAod2FpdC50
c2sgIT0gTlVMTCkKPiBza2lwLgo+IAo+ID4gPiArCXJlcS0+cHJldmlvdXNfY29udGV4dCA9IE5V
TEw7Cj4gPiAKPiA+IFdlIHVuY29uZGl0aW9uYWxseSBzZXQgdGhpcyBpbiBhZHZhbmNlX2NvbnRl
eHQgKHRvZ2V0aGVyIHdpdGggYSBidW5jaCBvZgo+ID4gb3RoZXIgcmluZyBzdGF0ZSB0cmFja2Vk
IGluIHRoZSByZXF1ZXN0KS4gRG8gd2UgcmVhbGx5IG5lZWQgdG8gcmVzZXQgdGhpcwo+ID4gaGVy
ZT8KPiAKPiBQcmV2aW91c19jb250ZXh0IG1heSBiZSB1c2VkIHVuc2V0IChhbG9uZyBhIGZhaWx1
cmUgcGF0aCksIHNvIHJlcXVpcmVzCj4gaW5pdGlhbGlzaW5nLgo+IAo+ID4gPiArCXJlcS0+Zmls
ZV9wcml2ID0gTlVMTDsKPiA+IAo+ID4gVGhpcyBpcyBhbHJlYWR5IGNsZWFyZWQgaW4gZWl0aGVy
IHJlcXVlc3RfcmV0aXJlIG9yIF9yZWxlYXNlLiBBZ2FpbiBtYXliZQo+ID4ganVzdCBhIFdBUk5f
T04/Lgo+IAo+IEJ1dCB3ZSBuZXZlciBjbGVhciBpdCBmaXJzdCwgc28gaXQgbWF5IGJlIHBvaXNv
bmVkLgoKQXJnaCByaWdodCwgSSBmb3Jnb3R0ZW4gdGhhdCBpdCdzIG5vdCBqdXN0IG5vdCBtZW1z
ZXQgb24gcmVhbGxvYywgYnV0IGluCmdlbmVyYWwuIFRoZW4gd2UgaW5kZWVkIG5lZWQgdG8gY2xl
YXIgdGhlc2UgYWxsLgoKPiAKPiA+ID4gKwlyZXEtPmJhdGNoX29iaiA9IE5VTEw7Cj4gPiAKPiA+
IEFncmVlZCB3aXRoIHRoaXMgb25lLCB3ZSBtaWdodCByZXVzZSB0aGUgcmVxdWVzdCBmb3IgYSBu
b24tZXhlY2J1Zgo+ID4gcmVxdWVzdC4gQnV0IEkgdGhpbmsgd2UgYWxzbyBuZWVkIHRvIHJlc2V0
IC0+cGlkIGhlcmUuCj4gCj4gV2hhdCBwaWQ/IEdhaC4gKERvbid0IGhhdmUgcGlkIGhlcmUgaW4g
bXkgdHJlZS4uLikKCk90b2ggd2Ugc2hvdWxkbid0IGJlIHByaW50aW5nIHBpZCByZWFsbHkgd2hl
biBmaWxlX3ByaXYgPT0gTlVMTCwgc28gbm8KbmVlZCB0byBjbGVhci4KClJldmlld2VkLWJ5OiBE
YW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgoKPiAKPiA+ID4gKwlyZXEtPmVs
c3Bfc3VibWl0dGVkID0gMDsKPiA+IAo+ID4gTmVlZGVkLCBidXQgZmVlbHMgbWlzcGxhY2VkIHNp
bmNlIGl0J3MgbHJjIHN0dWZmLiBJIHRoaW5rIGl0J2QgYmUgYmV0dGVyCj4gPiB0byBzdHVmZiB0
aGlzIGludG8gaW50ZWxfbG9naWNhbF9yaW5nX2FsbG9jX3JlcXVlc3RfZXh0cmFzLgo+IAo+IE5v
IG5lZWQgZm9yIHRoYXQgZXh0cmEgY29tcGxleGl0eSwgaXQgaXMgdG8gYmUgcmVtb3ZlZC4KPiAt
Q2hyaXMKPiAKPiAtLSAKPiBDaHJpcyBXaWxzb24sIEludGVsIE9wZW4gU291cmNlIFRlY2hub2xv
Z3kgQ2VudHJlCgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29y
cG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlz
dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v
bGlzdGluZm8vaW50ZWwtZ2Z4Cg==