From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v2 5/6] drm/i915: Apply the PPS register unlock workaround more consistently Date: Tue, 9 Aug 2016 20:46:24 +0300 Message-ID: <20160809174624.GA4329@intel.com> References: <1470742452-5240-6-git-send-email-imre.deak@intel.com> <1470763294-7183-4-git-send-email-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id A1A5B6E61F for ; Tue, 9 Aug 2016 17:46:27 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1470763294-7183-4-git-send-email-imre.deak@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Imre Deak Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBBdWcgMDksIDIwMTYgYXQgMDg6MjE6MzRQTSArMDMwMCwgSW1yZSBEZWFrIHdyb3Rl Ogo+IEF0bSwgd2UgYXBwbHkgdGhpcyB3b3JrYXJvdW5kIHNvbWV3aGF0IGluY29uc2lzdGVudGx5 IGF0IHRoZSBmb2xsb3dpbmcKPiBwb2ludHM6IGRyaXZlciBsb2FkaW5nLCBMVkRTIGluaXQsIGVE UCBQUFMgaW5pdCwgc3lzdGVtIHJlc3VtZS4gQXMgdGhpcwo+IHdvcmthcm91bmQgYWxzbyBhZmZl Y3RzIHJlZ2lzdGVycyBvdGhlciB0aGFuIFBQUyAodGltaW5nLCBQTEwpIGEgbW9yZQo+IGNvbnNp c3RlbnQgd2F5IGlzIHRvIGFwcGx5IGl0IGVhcmx5IGFmdGVyIHRoZSBQUFMgSFcgY29udGV4dCBp cyBrbm93biB0bwo+IGJlIGxvc3Q6IGRyaXZlciBsb2FkaW5nLCBzeXN0ZW0gcmVzdW1lIGFuZCBv biBWTFYvQ0hWL0JYVCB3aGVuIHR1cm5pbmcKPiBvbiBwb3dlciBkb21haW5zLgo+IAo+IFRoaXMg aXMgbmVlZGVkIGJ5IHRoZSBuZXh0IHBhdGNoIHRoYXQgcmVtb3ZlcyBzYXZpbmcvcmVzdG9yaW5n IG9mIHRoZQo+IFBQX0NPTlRST0wgcmVnaXN0ZXIuCj4gCj4gVGhpcyBhbHNvIHJlbW92ZXMgdGhl IGluY29ycmVjdCBwcm9ncmFtbWluZyBvZiB0aGUgd29ya2Fyb3VuZCBvbiBIU1crCj4gUENIIHBs YXRmb3JtcyB3aGljaCBkb24ndCBoYXZlIHRoZSByZWdpc3RlciBsb2NraW5nIG1lY2hhbmlzbS4K PiAKPiB2MjogKFZpbGxlKQo+IC0gRG9uJ3QgYXBwbHkgdGhlIHdvcmthcm91bmQgb24gQlhULgo+ IC0gU2ltcGxpZnkgcGxhdGZvcm0gY2hlY2tzIHVzaW5nIEhBU19EREkoKS4KPiAKPiBTaWduZWQt b2ZmLWJ5OiBJbXJlIERlYWsgPGltcmUuZGVha0BpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMgICAgICAgICB8ICAxICsKPiAgZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZGlzcGxheS5jICAgIHwgMjYgKysrKysrKysrKysrKysrKysrKysrKysrKysK PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYyAgICAgICAgIHwgIDMgKystCj4gIGRy aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oICAgICAgICB8ICAxICsKPiAgZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfbHZkcy5jICAgICAgIHwgIDggLS0tLS0tLS0KPiAgZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfcnVudGltZV9wbS5jIHwgIDQgKysrKwo+ICA2IGZpbGVzIGNoYW5n ZWQsIDM0IGluc2VydGlvbnMoKyksIDkgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2Rydi5jCj4gaW5kZXggOGNmYzI2NC4uMGZjZDFjMCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X2Rydi5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9k cnYuYwo+IEBAIC0xNTYwLDYgKzE1NjAsNyBAQCBzdGF0aWMgaW50IGk5MTVfZHJtX3Jlc3VtZShz dHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICAJaTkxNV9nZW1fcmVzdW1lKGRldik7Cj4gIAo+ICAJ aTkxNV9yZXN0b3JlX3N0YXRlKGRldik7Cj4gKwlpbnRlbF9wcHNfdW5sb2NrX3JlZ3Nfd2EoZGV2 X3ByaXYpOwo+ICAJaW50ZWxfb3ByZWdpb25fc2V0dXAoZGV2X3ByaXYpOwo+ICAKPiAgCWludGVs X2luaXRfcGNoX3JlZmNsayhkZXYpOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMK PiBpbmRleCAzZDVmZDA2Li5iY2JmMjc3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2Rpc3BsYXkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rp c3BsYXkuYwo+IEBAIC0xNDYzNSw2ICsxNDYzNSwzMCBAQCBzdGF0aWMgYm9vbCBpbnRlbF9jcnRf cHJlc2VudChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICAJcmV0dXJuIHRydWU7Cj4gIH0KPiAg Cj4gK3ZvaWQgaW50ZWxfcHBzX3VubG9ja19yZWdzX3dhKHN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdikKPiArewo+ICsJaW50IHBwc19udW07Cj4gKwlpbnQgcHBzX2lkeDsKPiArCj4g KwlpZiAoSEFTX0RESShkZXZfcHJpdikpCj4gKwkJcmV0dXJuOwo+ICsJLyoKPiArCSAqIFRoaXMg dy9hIGlzIG5lZWRlZCBhdCBsZWFzdCBvbiBDUFQvUFBULCBidXQgdG8gYmUgc3VyZSBhcHBseSBp dAo+ICsJICogZXZlcnl3aGVyZSB3aGVyZSByZWdpc3RlcnMgY2FuIGJlIHdyaXRlIHByb3RlY3Rl ZC4KPiArCSAqLwo+ICsJaWYgKElTX1ZBTExFWVZJRVcoZGV2X3ByaXYpIHx8IElTX0NIRVJSWVZJ RVcoZGV2X3ByaXYpKQo+ICsJCXBwc19udW0gPSAyOwo+ICsJZWxzZQo+ICsJCXBwc19udW0gPSAx Owo+ICsKPiArCWZvciAocHBzX2lkeCA9IDA7IHBwc19pZHggPCBwcHNfbnVtOyBwcHNfaWR4Kysp IHsKPiArCQl1MzIgdmFsID0gSTkxNV9SRUFEKFBQX0NPTlRST0wocHBzX2lkeCkpOwo+ICsKPiAr CQl2YWwgPSAodmFsICYgflBBTkVMX1VOTE9DS19NQVNLKSB8IFBBTkVMX1VOTE9DS19SRUdTOwo+ ICsJCUk5MTVfV1JJVEUoUFBfQ09OVFJPTChwcHNfaWR4KSwgdmFsKTsKPiArCX0KPiArfQo+ICsK PiAgc3RhdGljIHZvaWQgaW50ZWxfcHBzX2luaXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl dl9wcml2KQo+ICB7Cj4gIAlpZiAoSEFTX1BDSF9TUExJVChkZXZfcHJpdikgfHwgSVNfQlJPWFRP TihkZXZfcHJpdikpCj4gQEAgLTE0NjQzLDYgKzE0NjY3LDggQEAgc3RhdGljIHZvaWQgaW50ZWxf cHBzX2luaXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAJCWRldl9wcml2 LT5wcHNfbW1pb19iYXNlID0gVkxWX1BQU19CQVNFOwo+ICAJZWxzZQo+ICAJCWRldl9wcml2LT5w cHNfbW1pb19iYXNlID0gUFBTX0JBU0U7Cj4gKwo+ICsJaW50ZWxfcHBzX3VubG9ja19yZWdzX3dh KGRldl9wcml2KTsKPiAgfQo+ICAKPiAgc3RhdGljIHZvaWQgaW50ZWxfc2V0dXBfb3V0cHV0cyhz dHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9kcC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+IGluZGV4IDJl ZjdiMTQuLjNkM2QzZmIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZHAuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiBAQCAtMTgyOSw3 ICsxODI5LDggQEAgc3RhdGljICB1MzIgaXJvbmxha2VfZ2V0X3BwX2NvbnRyb2woc3RydWN0IGlu dGVsX2RwICppbnRlbF9kcCkKPiAgCWxvY2tkZXBfYXNzZXJ0X2hlbGQoJmRldl9wcml2LT5wcHNf bXV0ZXgpOwo+ICAKPiAgCWNvbnRyb2wgPSBJOTE1X1JFQUQoX3BwX2N0cmxfcmVnKGludGVsX2Rw KSk7Cj4gLQlpZiAoIUlTX0JST1hUT04oZGV2KSkgewo+ICsJaWYgKFdBUk5fT04oIUhBU19EREko ZGV2X3ByaXYpICYmCj4gKwkJICAgICAoY29udHJvbCAmIFBBTkVMX1VOTE9DS19NQVNLKSAhPSBQ QU5FTF9VTkxPQ0tfUkVHUykpIHsKPiAgCQljb250cm9sICY9IH5QQU5FTF9VTkxPQ0tfTUFTSzsK PiAgCQljb250cm9sIHw9IFBBTkVMX1VOTE9DS19SRUdTOwo+ICAJfQo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2Rydi5oCj4gaW5kZXggYzI5YTQyOS4uY2JjZTc4NiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2Rydi5oCj4gQEAgLTExNTksNiArMTE1OSw3IEBAIHZvaWQgaW50ZWxfbWFya19idXN5KHN0 cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdik7Cj4gIHZvaWQgaW50ZWxfbWFya19pZGxl KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdik7Cj4gIHZvaWQgaW50ZWxfY3J0Y19y ZXN0b3JlX21vZGUoc3RydWN0IGRybV9jcnRjICpjcnRjKTsKPiAgaW50IGludGVsX2Rpc3BsYXlf c3VzcGVuZChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KTsKPiArdm9pZCBpbnRlbF9wcHNfdW5sb2Nr X3JlZ3Nfd2Eoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KTsKPiAgdm9pZCBpbnRl bF9lbmNvZGVyX2Rlc3Ryb3koc3RydWN0IGRybV9lbmNvZGVyICplbmNvZGVyKTsKPiAgaW50IGlu dGVsX2Nvbm5lY3Rvcl9pbml0KHN0cnVjdCBpbnRlbF9jb25uZWN0b3IgKik7Cj4gIHN0cnVjdCBp bnRlbF9jb25uZWN0b3IgKmludGVsX2Nvbm5lY3Rvcl9hbGxvYyh2b2lkKTsKPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHZkcy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfbHZkcy5jCj4gaW5kZXggOTM5ZjUxZi4uMzVkNTVmMSAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9sdmRzLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9sdmRzLmMKPiBAQCAtOTc3LDE0ICs5NzcsNiBAQCB2b2lkIGludGVsX2x2ZHNf aW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICAJaW50IHBpcGU7Cj4gIAl1OCBwaW47Cj4g IAo+IC0JLyoKPiAtCSAqIFVubG9jayByZWdpc3RlcnMgYW5kIGp1c3QgbGVhdmUgdGhlbSB1bmxv Y2tlZC4gRG8gdGhpcyBiZWZvcmUKPiAtCSAqIGNoZWNraW5nIHF1aXJrIGxpc3RzIHRvIGF2b2lk IGJvZ3VzIFdBUk5JTkdzLgo+IC0JICovCj4gLQlpZiAoSEFTX1BDSF9TUExJVChkZXZfcHJpdikg fHwgSU5URUxfR0VOKGRldl9wcml2KSA8PSA0KQo+IC0JCUk5MTVfV1JJVEUoUFBfQ09OVFJPTCgw KSwKPiAtCQkJICAgSTkxNV9SRUFEKFBQX0NPTlRST0woMCkpIHwgUEFORUxfVU5MT0NLX1JFR1Mp Owo+IC0KPiAgCWlmICghaW50ZWxfbHZkc19zdXBwb3J0ZWQoZGV2KSkKPiAgCQlyZXR1cm47Cj4g IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ydW50aW1lX3BtLmMg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ydW50aW1lX3BtLmMKPiBpbmRleCAxYzYwM2Ji Li44ZjUxYWUzIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3J1bnRp bWVfcG0uYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3J1bnRpbWVfcG0uYwo+ IEBAIC01OTIsNiArNTkyLDggQEAgdm9pZCBieHRfZGlzYWJsZV9kYzkoc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmRldl9wcml2KQo+ICAJRFJNX0RFQlVHX0tNUygiRGlzYWJsaW5nIERDOVxuIik7 Cj4gIAo+ICAJZ2VuOV9zZXRfZGNfc3RhdGUoZGV2X3ByaXYsIERDX1NUQVRFX0RJU0FCTEUpOwo+ ICsKPiArCWludGVsX3Bwc191bmxvY2tfcmVnc193YShkZXZfcHJpdik7Cj4gIH0KPiAgCj4gIHN0 YXRpYyB2b2lkIGFzc2VydF9jc3JfbG9hZGVkKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZf cHJpdikKPiBAQCAtMTE0NSw2ICsxMTQ3LDggQEAgc3RhdGljIHZvaWQgdmx2X2Rpc3BsYXlfcG93 ZXJfd2VsbF9lbmFibGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJdmx2 X3NldF9wb3dlcl93ZWxsKGRldl9wcml2LCBwb3dlcl93ZWxsLCB0cnVlKTsKPiAgCj4gIAl2bHZf ZGlzcGxheV9wb3dlcl93ZWxsX2luaXQoZGV2X3ByaXYpOwo+ICsKPiArCWludGVsX3Bwc191bmxv Y2tfcmVnc193YShkZXZfcHJpdik7CgpJJ2QgcHV0IHRoZSBjYWxsIGluc2lkZSB2bHZfZGlzcGxh eV9wb3dlcl93ZWxsX2luaXQoKS4gVGhhdCdzIHdoZXJlIHdlCmluaXRpYWxpemUgYWxsIHRoZSBv dGhlciBkaXNwbGF5IHJlZ2lzdGVycy4KCkVpdGhlciB3YXkKUmV2aWV3ZWQtYnk6IFZpbGxlIFN5 cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cgo+ICB9Cj4gIAo+ICBzdGF0 aWMgdm9pZCB2bHZfZGlzcGxheV9wb3dlcl93ZWxsX2Rpc2FibGUoc3RydWN0IGRybV9pOTE1X3By aXZhdGUgKmRldl9wcml2LAo+IC0tIAo+IDIuNS4wCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVs IE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRl bC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK