[Qemu-devel] [PATCH] checkpatch: ignore automatically imported Linux headers

[Qemu-devel] [PATCH] checkpatch: ignore automatically imported Linux headers

[Radim Krčmář]

Linux uses tabs for indentation and checkpatch always complained about
automatically imported headers.  update-linux-headers.sh could be modified to
expand tabs, but there is no real reason to complain about any ugly code in
Linux headers, so skip all hunk-related checks.

Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
---
 Line offset of the diff assumes that Paolo's "[PATCH 0/3] checkpatch tweaks"
 is applied first.  Context remains the same, though.

 scripts/checkpatch.pl | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 0f9ae512ae55..873a50292442 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1312,6 +1312,9 @@ sub process {
 # ignore non-hunk lines and lines being removed
 		next if (!$hunk_line || $line =~ /^-/);
 
+# ignore files that are being periodically imported from Linux
+		next if ($realfile =~ /^(linux-headers|include\/standard-headers)\//);
+
 #trailing whitespace
 		if ($line =~ /^\+.*\015/) {
 			my $herevet = "$here\n" . cat_vet($rawline) . "\n";
-- 
2.9.2

Re: [Qemu-devel] [PATCH] checkpatch: ignore automatically imported Linux headers

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Message-id: 20160809173841.716-1-rkrcmar@redhat.com
Type: series
Subject: [Qemu-devel] [PATCH] checkpatch: ignore automatically imported Linux headers

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
b43ef9c checkpatch: ignore automatically imported Linux headers

=== OUTPUT BEGIN ===
Checking PATCH 1/1: checkpatch: ignore automatically imported Linux headers...
WARNING: line over 80 characters
#26: FILE: scripts/checkpatch.pl:1323:
+		next if ($realfile =~ /^(linux-headers|include\/standard-headers)\//);

ERROR: code indent should never use tabs
#26: FILE: scripts/checkpatch.pl:1323:
+^I^Inext if ($realfile =~ /^(linux-headers|include\/standard-headers)\//);$

total: 1 errors, 1 warnings, 9 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org

Re: [Qemu-devel] [PATCH] checkpatch: ignore automatically imported Linux headers

[Paolo Bonzini]

On 09/08/2016 19:38, Radim Krčmář wrote:
> Linux uses tabs for indentation and checkpatch always complained about
> automatically imported headers.  update-linux-headers.sh could be modified to
> expand tabs, but there is no real reason to complain about any ugly code in
> Linux headers, so skip all hunk-related checks.
> 
> Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
> ---
>  Line offset of the diff assumes that Paolo's "[PATCH 0/3] checkpatch tweaks"
>  is applied first.  Context remains the same, though.
> 
>  scripts/checkpatch.pl | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 0f9ae512ae55..873a50292442 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1312,6 +1312,9 @@ sub process {
>  # ignore non-hunk lines and lines being removed
>  		next if (!$hunk_line || $line =~ /^-/);
>  
> +# ignore files that are being periodically imported from Linux
> +		next if ($realfile =~ /^(linux-headers|include\/standard-headers)\//);
> +
>  #trailing whitespace
>  		if ($line =~ /^\+.*\015/) {
>  			my $herevet = "$here\n" . cat_vet($rawline) . "\n";
> 

Queued, thanks.

Paolo

Re: [Qemu-devel] [PATCH] checkpatch: ignore automatically imported Linux headers

[Cornelia Huck]

On Tue,  9 Aug 2016 19:38:41 +0200
Radim Krčmář <rkrcmar@redhat.com> wrote:

> Linux uses tabs for indentation and checkpatch always complained about
> automatically imported headers.  update-linux-headers.sh could be modified to
> expand tabs, but there is no real reason to complain about any ugly code in
> Linux headers, so skip all hunk-related checks.
> 
> Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
> ---
>  Line offset of the diff assumes that Paolo's "[PATCH 0/3] checkpatch tweaks"
>  is applied first.  Context remains the same, though.
> 
>  scripts/checkpatch.pl | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 0f9ae512ae55..873a50292442 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1312,6 +1312,9 @@ sub process {
>  # ignore non-hunk lines and lines being removed
>  		next if (!$hunk_line || $line =~ /^-/);
>  
> +# ignore files that are being periodically imported from Linux
> +		next if ($realfile =~ /^(linux-headers|include\/standard-headers)\//);
> +
>  #trailing whitespace
>  		if ($line =~ /^\+.*\015/) {
>  			my $herevet = "$here\n" . cat_vet($rawline) . "\n";

Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>