From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937716AbcHJTMa (ORCPT ); Wed, 10 Aug 2016 15:12:30 -0400 Received: from mail-wm0-f46.google.com ([74.125.82.46]:34905 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753411AbcHJTM1 (ORCPT ); Wed, 10 Aug 2016 15:12:27 -0400 Date: Wed, 10 Aug 2016 08:01:34 +0000 From: Karl Beldan To: Sekhar Nori Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Rob Herring , Mark Rutland , Russell King , Santosh Shilimkar , Kevin Hilman , Karl Beldan Subject: Re: [PATCH 2/4] ARM: dts: da850: Add an aemif node Message-ID: <20160810080134.GA16481@gobelin> References: <20160809171518.22690-1-kbeldan@baylibre.com> <20160809171518.22690-3-kbeldan@baylibre.com> <57AADC63.90405@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <57AADC63.90405@ti.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 10, 2016 at 01:18:51PM +0530, Sekhar Nori wrote: > On Tuesday 09 August 2016 10:45 PM, Karl Beldan wrote: > > Currently the davinci da8xx boards use the mach-davinci aemif code. > > Instantiating an aemif node into the DT allows to use the ti-aemif > > memory driver and is another step to better DT support. > > Also it will allow to properly pass the emif timings via DT. > > > > Signed-off-by: Karl Beldan > > --- > > arch/arm/boot/dts/da850.dtsi | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi > > index bc10e7e..f62928c 100644 > > --- a/arch/arm/boot/dts/da850.dtsi > > +++ b/arch/arm/boot/dts/da850.dtsi > > @@ -411,6 +411,16 @@ > > dma-names = "tx", "rx"; > > }; > > }; > > + aemif: aemif@68000000 { > > + compatible = "ti,da850-aemif"; > > + #address-cells = <2>; > > + #size-cells = <1>; > > + > > + reg = <0x68000000 0x00008000>; > > + ranges = <0 0 0x60000000 0x08000000 > > + 1 0 0x68000000 0x00008000>; > > + status = "disabled"; > > + }; > > nand_cs3@62000000 { > > compatible = "ti,davinci-nand"; > > reg = <0x62000000 0x807ff > > The nand node should be part of aemif node like it is done for keystone > boards. > Hmm, this is exactly what I have done. Karl From mboxrd@z Thu Jan 1 00:00:00 1970 From: Karl Beldan Subject: Re: [PATCH 2/4] ARM: dts: da850: Add an aemif node Date: Wed, 10 Aug 2016 08:01:34 +0000 Message-ID: <20160810080134.GA16481@gobelin> References: <20160809171518.22690-1-kbeldan@baylibre.com> <20160809171518.22690-3-kbeldan@baylibre.com> <57AADC63.90405@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <57AADC63.90405@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Sekhar Nori Cc: Mark Rutland , devicetree@vger.kernel.org, Karl Beldan , Kevin Hilman , linux-kernel@vger.kernel.org, Russell King , Rob Herring , Santosh Shilimkar , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On Wed, Aug 10, 2016 at 01:18:51PM +0530, Sekhar Nori wrote: > On Tuesday 09 August 2016 10:45 PM, Karl Beldan wrote: > > Currently the davinci da8xx boards use the mach-davinci aemif code. > > Instantiating an aemif node into the DT allows to use the ti-aemif > > memory driver and is another step to better DT support. > > Also it will allow to properly pass the emif timings via DT. > > > > Signed-off-by: Karl Beldan > > --- > > arch/arm/boot/dts/da850.dtsi | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi > > index bc10e7e..f62928c 100644 > > --- a/arch/arm/boot/dts/da850.dtsi > > +++ b/arch/arm/boot/dts/da850.dtsi > > @@ -411,6 +411,16 @@ > > dma-names = "tx", "rx"; > > }; > > }; > > + aemif: aemif@68000000 { > > + compatible = "ti,da850-aemif"; > > + #address-cells = <2>; > > + #size-cells = <1>; > > + > > + reg = <0x68000000 0x00008000>; > > + ranges = <0 0 0x60000000 0x08000000 > > + 1 0 0x68000000 0x00008000>; > > + status = "disabled"; > > + }; > > nand_cs3@62000000 { > > compatible = "ti,davinci-nand"; > > reg = <0x62000000 0x807ff > > The nand node should be part of aemif node like it is done for keystone > boards. > Hmm, this is exactly what I have done. Karl From mboxrd@z Thu Jan 1 00:00:00 1970 From: kbeldan@baylibre.com (Karl Beldan) Date: Wed, 10 Aug 2016 08:01:34 +0000 Subject: [PATCH 2/4] ARM: dts: da850: Add an aemif node In-Reply-To: <57AADC63.90405@ti.com> References: <20160809171518.22690-1-kbeldan@baylibre.com> <20160809171518.22690-3-kbeldan@baylibre.com> <57AADC63.90405@ti.com> Message-ID: <20160810080134.GA16481@gobelin> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Aug 10, 2016 at 01:18:51PM +0530, Sekhar Nori wrote: > On Tuesday 09 August 2016 10:45 PM, Karl Beldan wrote: > > Currently the davinci da8xx boards use the mach-davinci aemif code. > > Instantiating an aemif node into the DT allows to use the ti-aemif > > memory driver and is another step to better DT support. > > Also it will allow to properly pass the emif timings via DT. > > > > Signed-off-by: Karl Beldan > > --- > > arch/arm/boot/dts/da850.dtsi | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi > > index bc10e7e..f62928c 100644 > > --- a/arch/arm/boot/dts/da850.dtsi > > +++ b/arch/arm/boot/dts/da850.dtsi > > @@ -411,6 +411,16 @@ > > dma-names = "tx", "rx"; > > }; > > }; > > + aemif: aemif at 68000000 { > > + compatible = "ti,da850-aemif"; > > + #address-cells = <2>; > > + #size-cells = <1>; > > + > > + reg = <0x68000000 0x00008000>; > > + ranges = <0 0 0x60000000 0x08000000 > > + 1 0 0x68000000 0x00008000>; > > + status = "disabled"; > > + }; > > nand_cs3 at 62000000 { > > compatible = "ti,davinci-nand"; > > reg = <0x62000000 0x807ff > > The nand node should be part of aemif node like it is done for keystone > boards. > Hmm, this is exactly what I have done. Karl